Bug#879280: fakeupstream.cgi: Use a 5xx HTTP status code in case of error

[Gioele Barabucci <gioele@svario.it>]

Package: qa.debian.org
Tags: patch

Dear fakeupstream.cgi maintainers,

HTTP calls to fakeupstream.cgi should return a 5xx HTTP status code in 
case an error occurred while processing the request.

Luckily there is already in the code a single point of exit for all 
errors. The following patch implements returning a 500 code in case of 
error.

Bikeshedding time! :) I used a "500 Internal Server Error" status code. 
"400 Bad Request" would also be OK. Actually every status code in the 
4xx and 5xx range would be better than the current "200 OK".

Regards,

--- fakeupstream.cgi.orig	2017-10-21 14:24:26.493174836 +0200
+++ fakeupstream.cgi	2017-10-21 15:25:01.940837493 +0200
@@ -71,7 +71,7 @@
 {
 	chdir( "/" ); # for removal of vcs_tempdir
 	my $message = shift;
-	print $q->header( "text/plain" );
+	print $q->header( "text/plain", "500 Internal Server Error" );
 	print "$message\n";
 	exit 0;
 }

--
Gioele Barabucci <gioele@svario.it>