On Sun, 20 Aug 2017 10:13:47 +0200, Mattia Rizzolo wrote: > On Sat, Aug 19, 2017 at 11:20:50AM -0700, Chris Lamb wrote: > > Updated patch attached, although the last hunk is probably unnecessary > > anyway. > > Although, I'm not a perl guy so I must ask before applying: > * shouldn't that function be `escape_html()` instead of `html_escape()` ? > (i.e., what is cited in the `use`) > * does that thing requires a new dependency? The closer thing I could > find on the net is > http://search.cpan.org/dist/HTML-Escape/lib/HTML/Escape.pm which > doesn't seem like something that is in the standard lib… > * in the last chunk you escaped the first $me but not the latter in the > line below, probably best to at least be consistent? AFAICS HTML::Escape is not packaged for Debian. (Ack on the other points). HTML::Entities might be an option: https://metacpan.org/pod/HTML::Entities Included in the libhtml-parser-perl package. Cheers, gregor -- .''`. https://info.comodo.priv.at/ - Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Bob Dylan: This Dream Of You
Attachment:
signature.asc
Description: Digital Signature