Control: tag -1 moreinfo
On Sat, Aug 19, 2017 at 11:20:50AM -0700, Chris Lamb wrote:
> Updated patch attached, although the last hunk is probably unnecessary
> anyway.
Thanks for the patch!
Although, I'm not a perl guy so I must ask before applying:
* shouldn't that function be `escape_html()` instead of `html_escape()` ?
(i.e., what is cited in the `use`)
* does that thing requires a new dependency? The closer thing I could
find on the net is
http://search.cpan.org/dist/HTML-Escape/lib/HTML/Escape.pm which
doesn't seem like something that is in the standard lib…
* in the last chunk you escaped the first $me but not the latter in the
line below, probably best to at least be consistent?
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature