[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#757443: html markup does not validate



Control: retitle -1 html markup does not validate
Control: severity -1 minor
Control: tag -1 newcomer

Konqueror seems to cope nicely with tracker using the following fix.

There remain markup imperfections: 

 - A few action items (bugs and autoremoval) should be rewritten in
   order to have the target of their links properly escaped. (& should
   be escaped as &)
 - The acronym element is obsolete, use the abbr element instead
 - The aria-labelledby attribute must point to an element in the same
   document
 - Be html4 markup compliant

Cheers,
Christophe
>From 691c76425312c9a3e5103aa9192b2e1b473dc888 Mon Sep 17 00:00:00 2001
From: Christophe Siraut <d@tobald.eu.org>
Date: Fri, 5 Dec 2014 10:58:33 +0100
Subject: [PATCH] templates: <div> not allowed as child of element <ul> in this
 context

---
 distro_tracker/core/templates/core/panels/binaries.html | 2 --
 distro_tracker/core/templates/core/panels/news.html     | 2 --
 distro_tracker/vendor/debian/templates/debian/bugs.html | 4 +---
 3 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/distro_tracker/core/templates/core/panels/binaries.html b/distro_tracker/core/templates/core/panels/binaries.html
index cbb50e0..0377326 100644
--- a/distro_tracker/core/templates/core/panels/binaries.html
+++ b/distro_tracker/core/templates/core/panels/binaries.html
@@ -2,7 +2,6 @@
 
 {% block panel-body %}
 <ul class="list-group list-group-flush">
-    <div class="scrollable">
     {% with items=panel.context|dictsort:'name' %}
     {% for item in items %}
     <li class="list-group-item">
@@ -39,6 +38,5 @@
     </li>
     {% endfor %}
     {% endwith %}
-    </div>
 </ul>
 {% endblock %}
diff --git a/distro_tracker/core/templates/core/panels/news.html b/distro_tracker/core/templates/core/panels/news.html
index 1ff8e01..1cc38fd 100644
--- a/distro_tracker/core/templates/core/panels/news.html
+++ b/distro_tracker/core/templates/core/panels/news.html
@@ -15,7 +15,6 @@
 
 {% block panel-body %}
 <ul class="list-group list-group-flush">
-    <div class="scrollable">
     {% for news_item in panel.context.news %}
     <li class="list-group-item">
         [<span class="news-date">{{ news_item.datetime_created|date:"Y-m-d" }}</span>]
@@ -37,6 +36,5 @@
         {% endwith %}
     </li>
     {% endfor %}
-    </div>
 </ul>
 {% endblock %}
diff --git a/distro_tracker/vendor/debian/templates/debian/bugs.html b/distro_tracker/vendor/debian/templates/debian/bugs.html
index 0e76494..69ad7f0 100644
--- a/distro_tracker/vendor/debian/templates/debian/bugs.html
+++ b/distro_tracker/vendor/debian/templates/debian/bugs.html
@@ -8,7 +8,6 @@
 
 {% block bugs-list %}
     {% for category in panel.context.categories %}
-    <div class="row-fluid">
     <li class="list-group-item">
         <div class="list-item-key">
             {% if category.display_name == "gift" %}
@@ -44,6 +43,5 @@
         </div>
         <div class="clear"></div>
     </li>
-    </div>
     {% endfor %}
-{% endblock %}
\ No newline at end of file
+{% endblock %}
-- 
2.1.3


Reply to: