Bug#757443: tracker html syntax
Hi,
Checking the tracker pages against W3C validator spots quite a few
errors, here are littles fixes.
Cheers,
Christophe
>From ae49c9176f34b95ad9a57d85608a4ca0b8f6541e Mon Sep 17 00:00:00 2001
From: Christophe Siraut <d@tobald.eu.org>
Date: Sun, 30 Nov 2014 20:39:22 +0100
Subject: [PATCH 1/3] core/templates: avoid empty headings
---
distro_tracker/core/templates/core/package.html | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/distro_tracker/core/templates/core/package.html b/distro_tracker/core/templates/core/package.html
index 3402eb8..99b8834 100644
--- a/distro_tracker/core/templates/core/package.html
+++ b/distro_tracker/core/templates/core/package.html
@@ -16,7 +16,7 @@
</div>
<div class="span6 col col-lg-6 text-center">
<h1>{{ package }}</h1>
- <h4>{{ package.short_description }}</h4>
+ <h4>{{ package.short_description }}{% if not package.short_description %} {% endif %}</h4>
</div>
<div class="span3 col col-lg-3">
{% include 'core/package-search-form.html' %}
--
2.1.3
>From 24ff1b74faa4fba5dcc7b8868ef6530137e31758 Mon Sep 17 00:00:00 2001
From: Christophe Siraut <d@tobald.eu.org>
Date: Sun, 30 Nov 2014 20:41:18 +0100
Subject: [PATCH 2/3] core/templates: The element button must not appear as a
descendant of the a element
---
distro_tracker/core/templates/core/package.html | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/distro_tracker/core/templates/core/package.html b/distro_tracker/core/templates/core/package.html
index 99b8834..672f7d7 100644
--- a/distro_tracker/core/templates/core/package.html
+++ b/distro_tracker/core/templates/core/package.html
@@ -56,7 +56,7 @@
{% else %}
{# When the user is not authenticated, the subscribe button leads to the log in page instead #}
<div class="btn-group" style="margin-left: 10px;{% if is_subscribed %}display: none;{% endif %}">
- <a href="{% url 'dtracker-accounts-login' %}"><button id='subscribe-not-logged-in-button' class="btn">Subscribe</button></a>
+ <a href="{% url 'dtracker-accounts-login' %}" id='subscribe-not-logged-in-button' class="btn">Subscribe</a>
</div>
{% endif %}
--
2.1.3
>From 4d1a0eaf7715a63775a12893b3d942427d03bbc5 Mon Sep 17 00:00:00 2001
From: Christophe Siraut <d@tobald.eu.org>
Date: Mon, 1 Dec 2014 09:40:17 +0100
Subject: [PATCH 3/3] core/templates: Element div not allowed as child of
element ul in this context
---
distro_tracker/core/templates/core/panels/action-needed.html | 2 --
distro_tracker/core/templates/core/panels/bugs.html | 2 --
distro_tracker/core/templates/core/panels/versioned-links.html | 2 --
distro_tracker/core/templates/core/panels/versions.html | 4 ----
4 files changed, 10 deletions(-)
diff --git a/distro_tracker/core/templates/core/panels/action-needed.html b/distro_tracker/core/templates/core/panels/action-needed.html
index 002963b..bb54538 100644
--- a/distro_tracker/core/templates/core/panels/action-needed.html
+++ b/distro_tracker/core/templates/core/panels/action-needed.html
@@ -3,7 +3,6 @@
{% block panel-body %}
<ul class="list-group list-group-flush">
{% for item in panel.context.items %}
- <div class="row-fluid">
<li class="list-group-item">
{# The short description is allowed to contain some HTML markup #}
<span>{{ item.short_description|safe }}</span>
@@ -15,7 +14,6 @@
</span>
{% endif %}
</li>
- </div>
{% endfor %}
</ul>
{% endblock %}
diff --git a/distro_tracker/core/templates/core/panels/bugs.html b/distro_tracker/core/templates/core/panels/bugs.html
index 8b3ac53..0d1b6ec 100644
--- a/distro_tracker/core/templates/core/panels/bugs.html
+++ b/distro_tracker/core/templates/core/panels/bugs.html
@@ -4,7 +4,6 @@
<ul class="list-group list-group-flush">
{% block bugs-list %}
{% for category in panel.context %}{% if category.category_name %}
- <div class="row-fluid">
<li class="list-group-item">
{% with name=category.display_name|default:category.category_name %}
<div class="list-item-key"><b><span title="{{ category.description }}">{{ category.category_name }}:</span></b></div>
@@ -14,7 +13,6 @@
</div>
<div class="clear"></div>
</li>
- </div>
{% endif %}{% endfor %}
{% endblock %}
</ul>
diff --git a/distro_tracker/core/templates/core/panels/versioned-links.html b/distro_tracker/core/templates/core/panels/versioned-links.html
index 7ed716e..c44b751 100644
--- a/distro_tracker/core/templates/core/panels/versioned-links.html
+++ b/distro_tracker/core/templates/core/panels/versioned-links.html
@@ -3,7 +3,6 @@
{% block panel-body %}
<ul class="list-group list-group-flush">
{% for version in panel.context %}
- <div class="row-fluid">
<li class="list-group-item">
<div class="list-item-key versioned-links-version"><b>{{ version.number }}:</b></div>
<div class="list-item-value versioned-links-icons">
@@ -17,7 +16,6 @@
</div>
<div class="clear"></div>
</li>
- </div>
{% endfor %}
</ul>
{% endblock %}
diff --git a/distro_tracker/core/templates/core/panels/versions.html b/distro_tracker/core/templates/core/panels/versions.html
index dcffa7c..d958b3f 100644
--- a/distro_tracker/core/templates/core/panels/versions.html
+++ b/distro_tracker/core/templates/core/panels/versions.html
@@ -25,7 +25,6 @@
<ul class="list-group list-group-flush">
{% with versions=panel.context.version_info %}
{% for item in versions.version_list %}
- <div class="row-fluid">
<li class="list-group-item">
<div class="list-item-key versions-repository"><b><span title="{{ item.repository.name }}">{{ item.repository.shorthand }}:</span></b></div>
<div class="list-item-value">
@@ -35,13 +34,11 @@
</div>
<div class="clear"></div>
</li>
- </div>
{% endfor %}
{% endwith %}
{# Add any vendor provided versions #}
{% for item in panel.context.vendor_versions %}
- <div class="row-fluid">
<li class="list-group-item">
<div class="list-item-key versions-repository">
{% if item.repository_link %}<a href="{{ item.repository_link }}">{% endif %}
@@ -55,7 +52,6 @@
</div>
<div class="clear"></div>
</li>
- </div>
{% endfor %}
</ul>
{% endblock %}
--
2.1.3
Reply to: