[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: My recent bpo-uploads not appearing in my qa page



* Nicolas Dandrimont <olasd@debian.org> [2013-10-25 12:30:46 CEST]:
> [Trimming down the Cc: list a bit]
> * Mike Gabriel <mike.gabriel@das-netzwerkteam.de> [2013-10-25 09:39:41 +0000]:
> 
> > I really wished someone with sufficient privileges could look at
> > this rather sooner than later. I start loosing track of my uploads
> > to wheezy-bpo (the scrap of paper gets scribbled more and more...).
> > I guess, other package maintainer feel similar about this.
> 
> Please find attached a patch to the qa svn repository that makes
> extract_incoming.pl look in the right place for !squeeze bpo sources.

 Great.  Just one nitpick:

> Index: data/ddpo/extract_incoming.pl
> ===================================================================
> --- data/ddpo/extract_incoming.pl	(révision 3079)
> +++ data/ddpo/extract_incoming.pl	(copie de travail)
> @@ -65,7 +65,6 @@
>  my $delayed_summary = "http://people.debian.org/~myon/delayed/delayed-summary";;
>  my $delayed_http = "http://people.debian.org/~djpig/delayed/";;
>  my $queue_summary = "http://ftp-master.debian.org/new.822";;
> -my $bpo_url = "http://backports.debian.org/debian-backports";;
>  
>  # global variables
>  my %db;
> @@ -239,8 +238,16 @@
>      next if ($distkey =~ /^(unstable|testing)/);
>      my $dist = $active_dists{$distkey} . "-backports";
>      my $codename = $distkey eq "stable" ? "bpo" : "$distkey-bpo";
> +
> +    my $archive = "ftp.debian.org";
> +    my $bpo_url = "http://ftp.debian.org/debian";;
> +    if ($dist eq "squeeze-backports") {
> +        $archive = "backports.org";
> +        $bpo_url = "http://backports.debian.org/debian-backports";;
> +    }
> +

 I wouldn't move the definition my "my $bpo_url" from the other URL
definitions.  Reason being, the special casing for squeeze-backports
will eventually fade and can get removed, and the URL definitions should
stick together.  There's a reason why they are next to each other right
now.  :)

 Maybe also put my $archive next to it and put an additional comment
that the special casing can get removed after squeeze gets archived.

 Enjoy, and thanks!
Rhonda
-- 
Fühlst du dich mutlos, fass endlich Mut, los      |
Fühlst du dich hilflos, geh raus und hilf, los    | Wir sind Helden
Fühlst du dich machtlos, geh raus und mach, los   | 23.55: Alles auf Anfang
Fühlst du dich haltlos, such Halt und lass los    |


Reply to: