[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#416473: DDPO: <title> should contain the name of the developer in question



Control: tag -1 + patch

Hi,

while working on ddpo, I implemented this.

Greetings,
Joachim


-- 
Joachim "nomeata" Breitner
Debian Developer
  nomeata@debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C
  JID: nomeata@joachim-breitner.de | http://people.debian.org/~nomeata

From 95b24e4f6edd09f92e9b206bd181a595d91e849b Mon Sep 17 00:00:00 2001
From: Joachim Breitner <mail@joachim-breitner.de>
Date: Sat, 25 May 2013 18:04:01 +0200
Subject: [PATCH 2/2] Show developer name in title

Closes: #416473
---
 wml/developer.wml | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/wml/developer.wml b/wml/developer.wml
index 8f8a6c3..78e5fe0 100644
--- a/wml/developer.wml
+++ b/wml/developer.wml
@@ -127,7 +127,7 @@ if($_GET['reset'] != 'yes')
     if ($_GET['set'] == 'yes') setcookie('columnsinfo', base64_encode(serialize($arg_cookie)), strtotime('+3 month'));
 }
 
-function start_output ()
+function start_output ( $name )
 {
     global $called_start_output;
 
@@ -141,8 +141,14 @@ function start_output ()
     header('Content-Style-Type: text/css');
     header('Pragma: no-cache');
 
+    /* We build the title from the value passed in the first invocation of start_output
+       which is almost always right, and never completely wrong. */
+    $title = "";
+    if ($name)
+        $title = " for $name";
+
 ?>
-#use wml::templ::template title="Debian Developer's Packages Overview" author="Igor Genibel, Christoph Berg, and others"
+#use wml::templ::template title="Debian Developer's Packages Overview<? print $title ?>" author="Igor Genibel, Christoph Berg, and others"
 
 {#style#:
   <link rel="stylesheet" type="text/css" href="developer.css" />
@@ -1461,7 +1467,6 @@ function output_emails( $emails )
     {
         if( email_has_packages( $email ) )
         {
-            start_output();
             $name = dba_fetch( "name:".strtolower($email), $pack_db );
             if( ! $name )
             {
@@ -1469,6 +1474,7 @@ function output_emails( $emails )
                 $name = $names[0];
             }
             $global_carnivoreid = carnivoreemail2carnivoreid( $email );
+            start_output( $name );
             print_developer( $email, $name );
             $global_carnivoreid = "";
         }
@@ -1540,8 +1546,6 @@ function output_carnivoreid( $carnivoreid )
     global $seen_packages;
     $seen_packages = array();
 
-    start_output();
-
     $email = "";
     foreach( $emails as $email_candidate )
         if( preg_match( "/\@debian\.org$/", $email_candidate ) )
@@ -1556,6 +1560,7 @@ function output_carnivoreid( $carnivoreid )
         $name = $names[0];
     }
 
+    start_output( $name );
     print html_h(htmlspecialchars("Packages overview for $name"), 2, "center");
 
     foreach( $emails as $email )
-- 
1.8.3.rc3

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: