Bug#702908: PTS: upload signature parsing patch

[Raphael Hertzog <hertzog@debian.org>]

Hi,

On Wed, 13 Mar 2013, Markus Wanner wrote:
> > I noticed in particular that you used <xsl:when> a few times where a simple
> > <xsl:if> would have been more appropriate.
> 
> I didn't find any place where <xsl:if> would have been sufficient.
> 
> However, I guess that's also a bit a matter of taste. I prefer
> <xsl:choose> whenever I need <xsl:otherwise> (i.e. an else clause).
> AFAIK there's no such thing for an <xsl:if>. With that, you'd have to
> repeat the test with a negation. While a bit less clutter with xml tags,
> I think that's more prone to error.

Ok, fine.

> attached is an updated patch. I sanitized the body pseudo-header
> parsing, especially when combined with an OpenPGP signature.

Thanks. The patch looks good for me. But we need to get python-gpgme
installed on the server. We should also ask DSA to mirror the keyring
on the machine. They do it for many other machines where it's needed.

Paul, can you take care of that as well?

Markus, ideally it would be nice if you could provide some configuration
parameters where we can list supplementary keyrings to include for looking
up the signatures.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Get the Debian Administrator's Handbook:
→ http://debian-handbook.info/get/