Bug#702908: PTS: upload signature parsing patch
Hi,
On Wed, 13 Mar 2013, Paul Wise wrote:
> > A public key may have multiple uids and the signature is only specific
> > to the key, not any specific uid. But I only want to display a single
> > uid. The way I implemented this now is: we take the first uid. Only if a
> > later uid has an email ending in "@debian.org", we prefer that one.
> > That's certainly not ideal. We could possibly do an LDAP lookup via the
> > key's fingerprint on db.debian.org instead...
>
> Hmmm, not sure what to say there. It seems like a reasonable approach for now.
Yes.
> > In the news.xml file, I replaced the "from" attribute of the news item
> > with more fine grained "from_address" and "from_realname". However, I
> > think existing entries will be kept, so the XSL-templates need to be
> > able to parse both. At least that's how I've implemented it. If a
> > complete rewrite of all news.xml files is feasible, the XSLTs could be
> > simplified quite a bit.
>
> I guess this is needed for the developer.php links, fair enough.
I don't understand your comment. Markus, it's certainly possible to update
all news.xml once with a new structure.
$ bin/list_packages.sh | bin/update_news.py
So if you can simplify, please do it.
I noticed in particular that you used <xsl:when> a few times where a simple
<xsl:if> would have been more appropriate. I also saw a "print" that you
probably left while debugging (print "signature uid: …).
Cheers,
--
Raphaël Hertzog ◈ Debian Developer
Get the Debian Administrator's Handbook:
→ http://debian-handbook.info/get/
Reply to: