[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Prototype script to determine last commit and last upload.



Stefano Zacchiroli wrote:
> On Fri, Apr 09, 2010 at 04:35:10PM +0200, Niels Thykier wrote:
>> Recently the Pkg-Java Team decided to try and remove inactive people
>> from the team and from the Uploaders Field of packages.
> 
> Hi Niels, thank for this couple of scripts. Personally, I'd like to have
> some similar helpers in devscripts instead of several debian/rules
> snippets that various teams are using, opening up for very different
> behaviors across teams. That said, I think your solution is a bit
> over-engineered, let me explain why.
> 

Hi

I do not see how these scripts could ever have been useful in
debian/rules. Nevertheless, if you feel I should have sent the scripts
to devscripts, I do not mind doing forwarding the scripts there.

> The fact that you look for commits hints, to me, that somehow you don't
> trust debian/changelog as documentation of who-did-what. I understand
> one can commit to a package repository without changing
> debian/changelog, but this is not a recommended practice. Additionally
> the integration of debian/changelog with tools like debcommit is somehow
> reassuring in having changes documented there.
> 

I can see how you might have come to this conclusion, but rest assured.
I do trust changelogs as a documentation of who-did-what. It was a
question of us setting with a list of some 50 user-names and wanted to
know who was active.
  We noticed that we could find the user-name in the emails to the
commit logs, which solved our problem of mapping (user-)names to
packages. So it was a question of what data I had available.


The day after - when I started on the other script - Damien suggested I
used grep-dctrl to find the packages.


Nevertheless, it sounds like there is little interest in the mailing
list scanner, so I will put that away for now.

> If you add the assumption that you only consider changes which are
> documented in debian/changelog, you can basically get rid of all the
> mailing list archive retrieving and parsing dance.  At that point, also
> debian/changelog parsing can be a bit easier, instead of looking for
> proper email addresses you just look for names that can appear either in
> changelog "signatures" or inside brackets "[ Name Family ]".
> 

I am using dpkg's perl modules for parsing the changelog, so it is
already pretty straight forward. The reason why it only checks the
signature line is because it is a prototype.
  It already allows you to specify a regex instead of an email provided
you invoke grep-dctrl yourself. However, it still only checks the
signature line. I know how to fix it and can do it when I get about 30
minutes to do a bit of perl.

> What do you think?
> Thanks for raising this subject.
> Cheers.
> 

~Niels

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: