[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: windowlab (QA upload, fixes RC bug)

On Saturday 21 June 2008, Ansgar Burchardt wrote:
> Hi!


> > Your changes seems to bring improvements..., yet could you please also
> > fix debian/rules so that both the binary-arch (buildd's call
> > `/usr/bin/fakeroot debian/rules binary-arch') and binary-indep targets
> > exist (see Policy 4.9) and so that `fakeroot debian/rules binary' works
> > as well.
> Done. Thanks for noticing.


> > > I also changed the packaging to use debhelper and quilt instead of
> > > cdbs, and updated the package to conform to the latest version of
> > > Debian policy.
> >
> > Did you check with
> > /usr/share/doc/debian-policy/upgrading-checklist.txt.gz since
> > debian/changelog only reads "Bump Standards Version to 3.8.0", but
> > doesn't list the exact changes done to align the package with 3.8.0, or
> > there were no changes needed to comply with 3.8.0; if any please say so,
> > probably by means of sub-bullets ;-)
> There are several changes: the Homepage field in debian/control, the
> README.source, and the get-orig-source target.  These changes are listed in
> the changelog.  As two of them are already sub-bullets of other changes, I
> think it isn't a good idea to move them.


> > By the way, if you need a more expressive get-orig-source you can borrow
> > some bits from the stealth package for instance.
> I added an md5sum check in the get-orig-source target for windowlab.
> The get-orig-source from stealth seems to require to be started in the
> package directory in order to inspect debian/changelog and doesn't leave
> the generated tarball in the current directory, which doesn't seem policy
> compliant, so I did not do this in windowlab.

Yes, it was created after svn-buildpackage default layout 
(package/{trunk,tags,branches,tarballs}), but it is probably a good idea not 
to occupy the get-orig-source target for that, but use another one instead. 
Thanks for the good catch.

> I uploaded an updated package to mentors:
> http://mentors.debian.net/debian/pool/main/w/windowlab/windowlab_1.34-1.dsc
> Thanks for the review!

At least the updated package is better than the one currently found in the 
archive ;-) As a further improvement you can use something like ucf for 
instance to gracefully handle configuration files in /etc/X11/windowlab/.

pub 4096R/0E4BD0AB 2003-03-18 <people.fccf.net/danchev/key pgp.mit.edu>
fingerprint 1AE7 7C66 0A26 5BFF DF22 5D55 1C57 0C89 0E4B D0AB 

Reply to: