[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: windowlab (QA upload, fixes RC bug)

On Saturday 21 June 2008, Ansgar Burchardt wrote:
> Hi,


thanks for hunting RC bugs ;-)

> I prepared a QA upload for the latest upstream version of windowlab, a
> small and simple windowmanager.
> The upload would close the following bugs:
>  - 486978 (serious): FTBFS: windowlab.h:37:34: error:
>    X11/extensions/shape.h: No such file or directory
>  - 438264 (wishlist): not handling nostrip build option (policy 10.1)

Your changes seems to bring improvements..., yet could you please also fix 
debian/rules so that both the binary-arch (buildd's call `/usr/bin/fakeroot 
debian/rules binary-arch') and binary-indep targets exist (see Policy 4.9) 
and so that `fakeroot debian/rules binary' works as well.

> I also changed the packaging to use debhelper and quilt instead of cdbs,
> and updated the package to conform to the latest version of Debian policy.

Did you check with /usr/share/doc/debian-policy/upgrading-checklist.txt.gz 
since debian/changelog only reads "Bump Standards Version to 3.8.0", but 
doesn't list the exact changes done to align the package with 3.8.0, or there 
were no changes needed to comply with 3.8.0; if any please say so, probably 
by means of sub-bullets ;-)

By the way, if you need a more expressive get-orig-source you can borrow some 
bits from the stealth package for instance.

pub 4096R/0E4BD0AB 2003-03-18 <people.fccf.net/danchev/key pgp.mit.edu>
fingerprint 1AE7 7C66 0A26 5BFF DF22 5D55 1C57 0C89 0E4B D0AB 

Reply to: