[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#457169: patch for qa.debian.org



On la, 2007-12-22 at 12:48 +0100, Stefano Zacchiroli wrote:
> A patch for this bug would be changing the font sizes so that they use
> relative units instead of absolute ones (as you suggest in the end of
> your last message) preserving the current look and feel. 

Attached is a patch that attempts to make all font sizes relative to the
browser's default base font size (which is what the user can be expected
to have chosen to suit their particular needs).

> The tricky part
> of doing that is that according to my tests "em" units are not
> cross-browsers compatible

They are compatible, but they do not guarantee identical rendering in
different browsers. Neither do absolute font size units. It is almost
impossible to get exactly the same looks with every browser. Nor should
that be a goal for a functional site such as the PTS (as opposed to a
site that is a replacement for paper ads).

For example, different browsers might have different font configurations
(different base font size, different restrictions on minimum font size),
or they might be using different fonts, or different versions of the the
font libraries, or different widget libraries, all of which may result
in text being rendered differently.

--- revamp.css	2007-12-22 14:57:00.000000000 +0200
+++ revamp.css.new	2007-12-22 14:51:32.000000000 +0200
@@ -13,7 +13,7 @@
     font-family: "DejaVu Sans", "Bitstream Vera Sans", sans-serif; /*Prefer Free Fonts*/
     background: #fff url('debian.png') no-repeat 18px 7px;
     color: #000;
-    font-size: 11pt;
+    font-size: 110%;
 }
 
 a:link    { color: #0755d7; text-decoration: underline; }
@@ -27,7 +27,7 @@
 /* --- Header --- */
 body > form { /* "Jump to package" */
     margin: 0.3em;
-    font-size: 10pt;
+    font-size: 100%;
     padding: 0.5em;
     border: 1px solid #aaa;
     background-color: #dfdfdf;
@@ -36,7 +36,7 @@
 h1 {
     margin: 0 0 0 0;
     padding: 20px 0 0 220px;
-    font-size: 18pt;
+    font-size: 180%;
     min-height: 60px;
     height: auto !important; /* "Min-Height Fast Hack" */
     height: 60px; 
@@ -73,7 +73,7 @@
 td.titlecell {
     padding: 0.2em 0.2em 0.1em 0.2em;
     font-weight: bold;
-    font-size: 12pt;
+    font-size: 120%;
     background: #d70751;
     color: #fff;
     border-top: 3px solid #999;
@@ -99,10 +99,10 @@
 }
 
 /* - Edge Tables - */
-tr#bugs_rc { font-size: 9pt; }
-tr#bugs_in { font-size: 9pt; }
-tr#bugs_mw { font-size: 9pt; }
-tr#bugs_fp { font-size: 9pt; }
+tr#bugs_rc { font-size: 90%; }
+tr#bugs_in { font-size: 90%; }
+tr#bugs_mw { font-size: 90%; }
+tr#bugs_fp { font-size: 90%; }
 span.indented { padding-left: 1.5em; }
 
 td > form { margin: 0.4em 0 0.4em 0.4em; padding: 0; } /* PTS subscribe */
@@ -146,7 +146,7 @@
     border-color: #fc9 #630 #330 #f96 !important;
     padding: 0 3px                    !important;
     font-weight: bold                 !important;
-    font-size: 8pt                    !important;
+    font-size: 80%                    !important;
     text-decoration: none             !important;
     vertical-align: 0.2em             !important;
     /* Without !important, inherets from td.titlecell a:* */

Reply to: