[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#58259: Patch?



I confess to knowing almost nothing about writing Perl XS modules, but the
typemap file here really shouldn't be using anything with a double underscore
in front of it.  Also, isn't this all unnecessary because the XS language
already provide a way to get at a variable number of arguments?  The
documentation seems to indicate this, but I'm not comfortable enough with XS to
try the conversion.

Meanwhile, I was able to get it to compile on Alpha using this patch:

--- libnewt-perl-1.08/typemap   Sat Apr 14 19:10:51 2001
+++ libnewt-perl-1.08+mdz/typemap       Sat Apr 14 19:10:19 2001
@@ -34,8 +34,7 @@
 INPUT
 T_VALIST
        if (sv_derived_from($arg, \"${ntype}\")) {
-           IV tmp = SvIV((SV*)SvRV($arg));
-           __va_copy($var, tmp);
+           $var = *(va_list *)SvANY((SV*)SvRV($arg));
        }
        else
            croak(\"$var is not of type ${ntype}\")

But there are no self-tests, and I don't have an Alpha available where I can
install and test it.  If someone else could give it a whirl, maybe we can
get these old bugs closed.

-- 
 - mdz



Reply to: