Bug#67657: marked as done (infinite loop in drawtree and drawgram)
Your message dated Tue, 23 Oct 2001 15:07:50 -0400
with message-id <E15w6ty-0003uL-00@auric.debian.org>
and subject line Bug#67657: fixed in phylip 3.573c-5
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Darren Benham
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 24 Jul 2000 12:07:53 +0000
>From pgodard@pasteur.fr Mon Jul 24 07:07:53 2000
Return-path: <pgodard@pasteur.fr>
Received: from nefertiti.pasteur.fr [157.99.64.20]
by master.debian.org with esmtp (Exim 3.12 2 (Debian))
id 13Gh1V-0000PZ-00; Mon, 24 Jul 2000 07:07:53 -0500
Received: from ishtar.sis.pasteur.fr (mail@ishtar.sis.pasteur.fr [157.99.60.44])
by nefertiti.pasteur.fr (8.11.0/8.11.0) with ESMTP id e6OC7pJ03314;
Mon, 24 Jul 2000 14:07:51 +0200 (MET DST)
Received: from pgodard by ishtar.sis.pasteur.fr with local (Exim 3.12 #1 (Debian))
id 13Gh1S-0006DJ-00; Mon, 24 Jul 2000 14:07:50 +0200
From: Patrice Godard <pgodard@pasteur.fr>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: infinite loop in drawtree and drawgram
X-Reportbug-Version: 0.54
X-Mailer: reportbug 0.54
Date: Mon, 24 Jul 2000 14:07:50 +0200
Message-Id: <E13Gh1S-0006DJ-00@ishtar.sis.pasteur.fr>
Sender: Patrice Godard <pgodard@pasteur.fr>
Delivered-To: submit@bugs.debian.org
Package: phylip
Version: 3.573c-1
Severity: normal
experiment:
$ touch treefile
$ phylip drawtree
$ phylip drawgram
patch:
*** drawgram.c.old Thu Jan 28 21:25:57 MET 1999
--- drawgram.c Thu Jan 28 21:26:05 MET 1999
***************
*** 171,176 ****
--- 171,179 ----
getc(treefile);
}
ch = getc(treefile);
+ if (ch == EOF) {
+ fprintf(stderr, "Unexpected EOF, not a valid tree\n");
+ exit(1); }
n++;
} while (ch != ':' && ch != ',' && ch != ')');
if (n > maxnch)
*** drawtree.c~ Mon Jan 25 15:20:03 MET 1999
--- drawtree.c Fri Jan 29 09:47:45 MET 1999
***************
*** 192,197 ****
--- 192,200 ----
(void)getc(treefile);
}
ch = getc(treefile);
+ if (ch == EOF) {
+ fprintf(stderr, "Unexpected EOF, not a valid tree\n");
+ exit(1); }
if (ch == '\n')
ch = ' ';
n++;
-- System Information
Debian Release: 2.2
Architecture: i386
Kernel: Linux ishtar 2.2.17 #1 Sun Jun 25 09:24:41 EST 2000 i586
Versions of packages phylip depends on:
ii libc6 2.1.3-10 GNU C Library: Shared libraries an
---------------------------------------
Received: (at 67657-close) by bugs.debian.org; 23 Oct 2001 19:10:00 +0000
>From troup@auric.debian.org Tue Oct 23 14:10:00 2001
Return-path: <troup@auric.debian.org>
Received: from auric.debian.org [206.246.226.45]
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 15w6w4-0001SF-00; Tue, 23 Oct 2001 14:10:00 -0500
Received: from troup by auric.debian.org with local (Exim 3.12 1 (Debian))
id 15w6ty-0003uL-00; Tue, 23 Oct 2001 15:07:50 -0400
From: Andreas Tille <tille@debian.org>
To: 67657-close@bugs.debian.org
X-Katie: $Revision: 1.59 $
Subject: Bug#67657: fixed in phylip 3.573c-5
Message-Id: <E15w6ty-0003uL-00@auric.debian.org>
Sender: James Troup <troup@auric.debian.org>
Date: Tue, 23 Oct 2001 15:07:50 -0400
Delivered-To: 67657-close@bugs.debian.org
We believe that the bug you reported is fixed in the latest version of
phylip, which has been installed in the Debian FTP archive:
phylip_3.573c-5.dsc
to pool/non-free/p/phylip/phylip_3.573c-5.dsc
phylip_3.573c-5.diff.gz
to pool/non-free/p/phylip/phylip_3.573c-5.diff.gz
phylip_3.573c-5_i386.deb
to pool/non-free/p/phylip/phylip_3.573c-5_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 67657@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Andreas Tille <tille@debian.org> (supplier of updated phylip package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Tue, 23 Oct 2001 12:35:14 +0200
Source: phylip
Binary: phylip
Architecture: source i386
Version: 3.573c-5
Distribution: unstable
Urgency: low
Maintainer: Andreas Tille <tille@debian.org>
Changed-By: Andreas Tille <tille@debian.org>
Description:
phylip - [Biology] A package of programs for inferring phylogenies.
Closes: 67657
Changes:
phylip (3.573c-5) unstable; urgency=low
.
* New Maintainer
* A patch by Patrice Godard <pgodard@pasteur.fr> fo fix #67657 is
applied because it compiles well for me in contrast to 3.573c-2
where it was enclosed as patch.diff.
closes: #67657
* Standards-Version: 3.5.6
Files:
d082c7ef42f4a62b3edd0d3b1458123e 611 non-free/misc optional phylip_3.573c-5.dsc
97628e06a6feab046f5ce3d7b5d79f51 10179 non-free/misc optional phylip_3.573c-5.diff.gz
5854545319fc69a592ee9dd7787a94f9 672766 non-free/misc optional phylip_3.573c-5_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: Weitere Infos: siehe http://www.gnupg.org
iD8DBQE71U/RYDBbMcCf01oRAksLAKCaP9LkjSFZlNp6iNGwrpybmbXfKACgnzDw
T0kJJSDC4s9bCYozEWF9KQM=
=GXcm
-----END PGP SIGNATURE-----
Reply to: