Bug#81033: marked as done (queued bombs out with fatal error.)
Your message dated Thu, 04 Jan 2001 15:07:35 -0500
with message-id <E14EGff-0007aM-00@auric.debian.org>
and subject line Bug#81033: fixed in queue 1.30.1-2
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Darren Benham
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 2 Jan 2001 05:53:36 +0000
>From suckfish@ihug.co.nz Mon Jan 01 23:53:36 2001
Return-path: <suckfish@ihug.co.nz>
Received: from smtp4.ihug.co.nz [203.109.252.5] (root)
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 14DKO7-0005iB-00; Mon, 01 Jan 2001 23:53:35 -0600
Received: from sucky.fish (p5-tnt3.akl.ihug.co.nz [203.173.214.5])
by smtp4.ihug.co.nz (8.9.3/8.9.3/Debian 8.9.3-21) with ESMTP id SAA23565
for <submit@bugs.debian.org>; Tue, 2 Jan 2001 18:53:30 +1300
From: suckfish@ihug.co.nz
Received: (from ralph@localhost)
by sucky.fish (8.11.1/8.11.1/Debian 8.11.0-6) id f025rSN17170;
Tue, 2 Jan 2001 18:53:28 +1300
X-Authentication-Warning: sucky.fish: ralph set sender to suckfish@ihug.co.nz using -f
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="F8w0QkdnRG"
Content-Transfer-Encoding: 7bit
Message-ID: <[🔎] 14929.27864.604818.216707@sucky.fish>
Date: Tue, 2 Jan 2001 18:53:28 +1300 (NZDT)
To: submit@bugs.debian.org
Subject: queued bombs out with fatal error.
X-Mailer: VM 6.75 under 21.2 (patch 38) "Peisino,Ak(B" XEmacs Lucid
Delivered-To: submit@bugs.debian.org
--F8w0QkdnRG
Content-Type: text/plain; charset=us-ascii
Content-Description: message body text
Content-Transfer-Encoding: 7bit
Package: queue
Version: 1.30.1-1
On running 'queue -i -- ls' from a terminal window, queued sends the
attached email.
The problem is the for loop at line 3226 of queued.c; an incorrect bound is
used in the for statement.
The enclosed patch cures the problem, by changing the loop bound from
RLIM_NLIMITS to the size of the appropriate array.
Ralph
--F8w0QkdnRG
Content-Type: message/rfc822
Content-Description: forwarded message
Content-Transfer-Encoding: 7bit
Return-Path: <queued>
Received: (from root@localhost)
by sucky.fish (8.11.1/8.11.1/Debian 8.11.0-6) id f025kLA17159
for root; Tue, 2 Jan 2001 18:46:21 +1300
Message-Id: <200101020546.f025kLA17159@sucky.fish>
From: The Queue Daemon <root>
To: root
Subject: queued error on sucky.fish: QUEUED fatal error; queued terminating:
- 7: invalid integer rlimit value
Date: Tue, 2 Jan 2001 18:46:21 +1300
MIME-Version: 1.0
QUEUED fatal error; queued terminating:
- 7: invalid integer rlimit value
--F8w0QkdnRG
Content-Type: text/plain; charset=us-ascii
Content-Description: message body text
Content-Transfer-Encoding: 7bit
--- queue-1.30.1.orig/queued.c
+++ queue-1.30.1/queued.c
@@ -92,6 +92,44 @@
#include "lex.h"
+#ifdef HAVE_GETRLIMIT
+/*
+ * Structure to match lex keywords to RLIMIT values and to small
+ * integers to index the q_rlimit array.
+ */
+static struct {
+ int r;
+ enum keyword kwd;
+} rtab[] = {
+#ifdef RLIMIT_CPU
+ RLIMIT_CPU, K_RLIMITCPU,
+#endif
+#ifdef RLIMIT_FSIZE
+ RLIMIT_FSIZE, K_RLIMITFSIZE,
+#endif
+#ifdef RLIMIT_DATA
+ RLIMIT_DATA, K_RLIMITDATA,
+#endif
+#ifdef RLIMIT_STACK
+ RLIMIT_STACK, K_RLIMITSTACK,
+#endif
+#ifdef RLIMIT_CORE
+ RLIMIT_CORE, K_RLIMITCORE,
+#endif
+#ifdef RLIMIT_RSS
+ RLIMIT_RSS, K_RLIMITRSS,
+#endif
+#ifdef RLIMIT_NOFILE
+ RLIMIT_NOFILE, K_RLIMITNOFILE,
+#endif
+#ifdef RLIMIT_VMEM
+ RLIMIT_VMEM, K_RLIMITVMEM,
+#endif
+};
+
+#define NUM_RLIMITS (sizeof (rtab) / sizeof (rtab[0]))
+
+#endif
/*
* Generic queue_b structure. The set of queues, jobs, and running
@@ -3223,7 +3261,7 @@
/*Eric Deal <eric.deal@conexant.com> found that this setrlimit
code breaks Solaris. Should test to see if it breaks other platforms
as well. GNU/Linux seems OK.*/
- for( i=0; i<RLIM_NLIMITS; i++ ){
+ for( i=0; i<NUM_RLIMITS; i++ ){
register struct rlimit *rlp = &(qp->q_rlimit[i]);
if( rlp->rlim_cur >= 0 && rlp->rlim_max >= 0 )
(void) setrlimit( itorl(i), rlp );
@@ -3292,40 +3330,6 @@
}
#ifdef HAVE_GETRLIMIT
-/*
- * Structure to match lex keywords to RLIMIT values and to small
- * integers to index the q_rlimit array.
- */
-static struct {
- int r;
- enum keyword kwd;
-} rtab[] = {
-#ifdef RLIMIT_CPU
- RLIMIT_CPU, K_RLIMITCPU,
-#endif
-#ifdef RLIMIT_FSIZE
- RLIMIT_FSIZE, K_RLIMITFSIZE,
-#endif
-#ifdef RLIMIT_DATA
- RLIMIT_DATA, K_RLIMITDATA,
-#endif
-#ifdef RLIMIT_STACK
- RLIMIT_STACK, K_RLIMITSTACK,
-#endif
-#ifdef RLIMIT_CORE
- RLIMIT_CORE, K_RLIMITCORE,
-#endif
-#ifdef RLIMIT_RSS
- RLIMIT_RSS, K_RLIMITRSS,
-#endif
-#ifdef RLIMIT_NOFILE
- RLIMIT_NOFILE, K_RLIMITNOFILE,
-#endif
-#ifdef RLIMIT_VMEM
- RLIMIT_VMEM, K_RLIMITVMEM,
-#endif
-};
-
/* Turn RLIMIT manifest number into a small Integer 0 <= i < RLIM_NLIMITS
* used to index the q_rlimit array.
*/
@@ -3334,7 +3338,7 @@
{
register int i;
- for (i = 0; i < sizeof rtab/sizeof rtab[0]; i++)
+ for (i = 0; i < NUM_RLIMITS; i++)
if (rtab[i].r == rl)
return i;
error1("%d: invalid RLIMIT value\n", rl);
@@ -3348,7 +3352,7 @@
{
register int i;
- for (i = 0; i < sizeof rtab/sizeof rtab[0]; i++)
+ for (i = 0; i < NUM_RLIMITS; i++)
if (rtab[i].kwd == kwd)
return rtab[i].r;
error1("%d: invalid keyword value\n", (int)kwd);
@@ -3360,7 +3364,7 @@
int
itorl(int i)
{
- if ((unsigned)i < sizeof rtab/sizeof rtab[0])
+ if ((unsigned)i < NUM_RLIMITS)
return rtab[i].r;
error1("%d: invalid integer rlimit value\n", i);
/*NOTREACHED*/
--F8w0QkdnRG--
---------------------------------------
Received: (at 81033-close) by bugs.debian.org; 4 Jan 2001 20:08:52 +0000
>From troup@auric.debian.org Thu Jan 04 14:08:52 2001
Return-path: <troup@auric.debian.org>
Received: from auric.debian.org [206.246.226.45] (mail)
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 14EGgu-0003j3-00; Thu, 04 Jan 2001 14:08:52 -0600
Received: from troup by auric.debian.org with local (Exim 3.12 1 (Debian))
id 14EGff-0007aM-00; Thu, 04 Jan 2001 15:07:35 -0500
From: Debian QA Group <debian-qa@lists.debian.org>
To: 81033-close@bugs.debian.org
Subject: Bug#81033: fixed in queue 1.30.1-2
Message-Id: <E14EGff-0007aM-00@auric.debian.org>
Sender: James Troup <troup@auric.debian.org>
Date: Thu, 04 Jan 2001 15:07:35 -0500
Delivered-To: 81033-close@bugs.debian.org
We believe that the bug you reported is fixed in the latest version of
queue, which has been installed in the Debian FTP archive:
queue_1.30.1-2_i386.deb
to pool/main/q/queue/queue_1.30.1-2_i386.deb
queue_1.30.1-2.diff.gz
to pool/main/q/queue/queue_1.30.1-2.diff.gz
queue_1.30.1-2.dsc
to pool/main/q/queue/queue_1.30.1-2.dsc
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 81033@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Debian QA Group <debian-qa@lists.debian.org> (supplier of updated queue package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Tue, 2 Jan 2001 10:46:02 -0800
Source: queue
Binary: queue
Architecture: source i386
Version: 1.30.1-2
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <debian-qa@lists.debian.org>
Changed-By: Joey Hess <joeyh@debian.org>
Description:
queue - transparent load balancing system
Closes: 81033
Changes:
queue (1.30.1-2) unstable; urgency=medium
.
* Applied patch from suckfish@ihug.co.nz to fix a crash on any trivial
command, related to rlimits. Closes: #81033
Files:
8102dab41e87c99ff144915b8a877500 607 admin optional queue_1.30.1-2.dsc
d0db5ed51d9727209a3b826deffc52af 5743 admin optional queue_1.30.1-2.diff.gz
9799affd0940df7ff392edcdf6882db6 108736 admin optional queue_1.30.1-2_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE6UiLA2tp5zXiKP0wRAiWiAJ0ctfMvG3IguVjmS7//Eil4aGFlaACaAlG6
HSguHrTsY2IEGvBSSjdbhA4=
=SPj+
-----END PGP SIGNATURE-----
Reply to: