[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1036249: closure-compiler: #1036159



Control: tags -1 patch

Hello,

I have been working on #1036159 and before I go ahead with my solution I would
like to hear your opinion whether this is acceptable.

Apparently closure-compiler embeds rhino classes and thus every time rhino is
updated, closure-compiler must be rebuilt too. I did just that in revision -14
but still half of the reverse-dependencies FTBFS because of a parsing error. I
tried to narrow this issue down and even reverted a commit in rhino which made
closure-compiler FTBFS. We addressed the initial FTBFS in revision -13. Still
that made no difference. Although rhino 1.7.14 and our ten year old closure-
compiler package are seemingly compatible at the source level, there must be
some subtle differences which cause the Javascript parsing errors.

Since I could not find a targeted fix I decided to remove the dependency on
rhino 1.7.14 and embedded rhino 1.7.7.2 instead, the last version that worked
well for closure-compiler. You can find the results here:

https://salsa.debian.org/java-team/closure-compiler/-/tree/bookworm

I have rebuilt all reverse-dependencies and this would resolve the problem.

The only exception is ckbuilder / ckeditor. The solution here is simple though.
ckbuilder must be rebuilt against rhino 1.7.14. This is the original solution
for #1026639 but the rebuilding part was forgotten. I have filed #1036778 as a
reminder.

Regards,

Markus


Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: