[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1023316: marked as done (9base: re-adds /bin/rc to /etc/shells on upgrade)



Your message dated Sat, 12 Nov 2022 16:34:07 +0000
with message-id <E1ottSJ-001TeA-UP@fasolo.debian.org>
and subject line Bug#1023316: fixed in 9base 1:6-13
has caused the Debian Bug report #1023316,
regarding 9base: re-adds /bin/rc to /etc/shells on upgrade
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1023316: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1023316
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Source: 9base
Version: 1:6-12
Tags: patch
Severity: serious
Justification: Debian policy 10.7.3

If I remove /bin/rc from /etc/shells and then upgrade or reinstall
9base, it will re-add itself to /etc/shells. Such behaviour violates
Debian policy section 10.7.3. I propose moving to dpkg triggers and
update-shells to fix this issue and attach a patch for your convenience.

Helmut
diff --minimal -Nru 9base-6/debian/changelog 9base-6/debian/changelog
--- 9base-6/debian/changelog	2022-03-17 21:15:01.000000000 +0100
+++ 9base-6/debian/changelog	2022-11-02 09:45:01.000000000 +0100
@@ -1,3 +1,9 @@
+9base (1:6-13) UNRELEASED; urgency=medium
+
+  * Update /etc/shells via dpkg triggers. (Closes: #-1)
+
+ -- Helmut Grohne <helmut@subdivi.de>  Wed, 02 Nov 2022 09:45:01 +0100
+
 9base (1:6-12) unstable; urgency=medium
 
   * QA upload.
diff --minimal -Nru 9base-6/debian/control 9base-6/debian/control
--- 9base-6/debian/control	2022-03-17 21:15:01.000000000 +0100
+++ 9base-6/debian/control	2022-11-02 09:45:01.000000000 +0100
@@ -11,7 +11,7 @@
 
 Package: 9base
 Architecture: any
-Depends: ${misc:Depends}, ${shlibs:Depends}
+Depends: ${misc:Depends}, ${shlibs:Depends}, debianutils (>= 5.3-1~)
 Description: Plan 9 userland tools
  9base is a port of following original Plan 9 userland tools to Unix:
  ascii, awk, basename, bc, cal, cat, cleanname, cmp, date, dc, dd, diff, du,
diff --minimal -Nru 9base-6/debian/postinst 9base-6/debian/postinst
--- 9base-6/debian/postinst	2022-03-17 21:15:01.000000000 +0100
+++ 9base-6/debian/postinst	2022-11-02 09:45:01.000000000 +0100
@@ -5,10 +5,6 @@
 # and so we can maintain compatibility with rc scripts expecting /bin/rc
 update-alternatives --install /bin/rc rc /usr/lib/plan9/bin/rc 20
 
-# allow use of 9base' rc as a login shell:
-add-shell /bin/rc
-add-shell /usr/lib/plan9/bin/rc
-
 #DEBHELPER#
 
 exit 0
diff --minimal -Nru 9base-6/debian/postrm 9base-6/debian/postrm
--- 9base-6/debian/postrm	2022-03-17 21:15:01.000000000 +0100
+++ 9base-6/debian/postrm	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if [ "$1" = "remove" ]; then
-    remove-shell /bin/rc
-    remove-shell /usr/lib/plan9/bin/rc
-fi
-
-#DEBHELPER#
diff --minimal -Nru 9base-6/debian/rules 9base-6/debian/rules
--- 9base-6/debian/rules	2022-03-17 21:15:01.000000000 +0100
+++ 9base-6/debian/rules	2022-11-02 09:45:01.000000000 +0100
@@ -52,6 +52,8 @@
 		mv $$MANPAGE $${MANPAGE}$(MANEXT); \
 	done
 
+	install -D -m644 debian/shells $(PKGDIR)$(DATADIR)/debianutils/shells.d/plan9
+
 override_dh_fixperms:
 	dh_fixperms
 
diff --minimal -Nru 9base-6/debian/shells 9base-6/debian/shells
--- 9base-6/debian/shells	1970-01-01 01:00:00.000000000 +0100
+++ 9base-6/debian/shells	2022-11-02 09:45:01.000000000 +0100
@@ -0,0 +1,2 @@
+/bin/rc
+/usr/lib/plan9/bin/rc

--- End Message ---
--- Begin Message ---
Source: 9base
Source-Version: 1:6-13
Done: Bo YU <tsu.yubo@gmail.com>

We believe that the bug you reported is fixed in the latest version of
9base, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1023316@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bo YU <tsu.yubo@gmail.com> (supplier of updated 9base package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 12 Nov 2022 21:48:16 +0800
Source: 9base
Architecture: source
Version: 1:6-13
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Bo YU <tsu.yubo@gmail.com>
Closes: 1023316
Changes:
 9base (1:6-13) unstable; urgency=medium
 .
   * QA upload.
   * Update /etc/shells via dpkg triggers. Thanks Helmut Grohne
     (closes: #1023316)
Checksums-Sha1:
 3507e141513ca8900b657ec1e15ff6b79cf9afb3 1802 9base_6-13.dsc
 a2102c3a066d15cf5de410a3939ea03b240efa73 18584 9base_6-13.debian.tar.xz
 56291feb7c39838ad74be4660468728223fad846 5516 9base_6-13_source.buildinfo
Checksums-Sha256:
 5d236c164942cb846e069c87194c12e12605a07bcae2e9f0b298560d3bd527ca 1802 9base_6-13.dsc
 57abb223c4467b9a6fb75be0f66e5840284d3af6cc08a0d4b0faff8f371c80e7 18584 9base_6-13.debian.tar.xz
 dcbb0d3be2b544dc796bb0707cfe3d72340a5beb310106eb38bfb46547513e79 5516 9base_6-13_source.buildinfo
Files:
 7fb66d92c3c11f67d3bb68e0894d2123 1802 utils optional 9base_6-13.dsc
 e656c06fbc53d1cfe5bf1e4c9045eb34 18584 utils optional 9base_6-13.debian.tar.xz
 cc3c6be605fa6a18ebb6c0eeacf5aaa0 5516 utils optional 9base_6-13_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEkjZVexcMh/iCHArDweDZLphvfH4FAmNvxdkACgkQweDZLphv
fH7zlBAA3gs6FHSyz5TJPdMgR/9HdXm7sB9J/BK9F5z5AXFRW3O5gVauZ3l9vZu4
XIFTy5YaWDzOUtseLHS8P/VliJsOhn1EQNfNOLRiYPI0ZAbweBq5iByjs3YnlS7x
7kZNswlQQ4lrgagznZMhgdmhDaSAKA+iryW0ZHoGQ2cL5fuiD8BPywOeVAy5Bmz7
HgOsTW53Zl+WYmovBmo8A6ozYF+/H/XOWi7gJxpEj7pcemrmBbUXEUTLSDh46QtG
lHTFvgYZruRB38FNl6gVlY31vYqCJQHR4A51LYxWiXJ9VUq4fNjFUv7dJ5qMZa6W
aoV8EXtJMwO9S3EeEVHVbznxxiJPABOTwf//JtcvZPP9H5xpSLp4xxXebagylCFq
GOLg8lLnEoc+I5W8OWH0PW1TydE8X3YiZYS/x0KTOHaQUCBYmFHsG8RCIMgxyNxv
TbBk7iTFux0Qu0k7r/K3Ltgj8lM4e+Ym6SMomGfdAUrsZ6V9+Ws2T4V2otKA95zp
Ir3KqNoSketYbGzBzC45KPrvLA1Levrvzv0sNaf5fR+/WWUYwAIwGQiJge9zon79
Xwdb+OzQxKBnGA3bR0gxHnX9VRQrlQiWKmKUqlJVM23xheC2SdbBOxNz5TmP2b1V
utCnM68ZleDgOTroNj6TZv2/XyEFIq2J+K5KM1C4SB+3+qBHGDg=
=i831
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: