[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1023316: 9base: re-adds /bin/rc to /etc/shells on upgrade



Source: 9base
Version: 1:6-12
Tags: patch
Severity: serious
Justification: Debian policy 10.7.3

If I remove /bin/rc from /etc/shells and then upgrade or reinstall
9base, it will re-add itself to /etc/shells. Such behaviour violates
Debian policy section 10.7.3. I propose moving to dpkg triggers and
update-shells to fix this issue and attach a patch for your convenience.

Helmut
diff --minimal -Nru 9base-6/debian/changelog 9base-6/debian/changelog
--- 9base-6/debian/changelog	2022-03-17 21:15:01.000000000 +0100
+++ 9base-6/debian/changelog	2022-11-02 09:45:01.000000000 +0100
@@ -1,3 +1,9 @@
+9base (1:6-13) UNRELEASED; urgency=medium
+
+  * Update /etc/shells via dpkg triggers. (Closes: #-1)
+
+ -- Helmut Grohne <helmut@subdivi.de>  Wed, 02 Nov 2022 09:45:01 +0100
+
 9base (1:6-12) unstable; urgency=medium
 
   * QA upload.
diff --minimal -Nru 9base-6/debian/control 9base-6/debian/control
--- 9base-6/debian/control	2022-03-17 21:15:01.000000000 +0100
+++ 9base-6/debian/control	2022-11-02 09:45:01.000000000 +0100
@@ -11,7 +11,7 @@
 
 Package: 9base
 Architecture: any
-Depends: ${misc:Depends}, ${shlibs:Depends}
+Depends: ${misc:Depends}, ${shlibs:Depends}, debianutils (>= 5.3-1~)
 Description: Plan 9 userland tools
  9base is a port of following original Plan 9 userland tools to Unix:
  ascii, awk, basename, bc, cal, cat, cleanname, cmp, date, dc, dd, diff, du,
diff --minimal -Nru 9base-6/debian/postinst 9base-6/debian/postinst
--- 9base-6/debian/postinst	2022-03-17 21:15:01.000000000 +0100
+++ 9base-6/debian/postinst	2022-11-02 09:45:01.000000000 +0100
@@ -5,10 +5,6 @@
 # and so we can maintain compatibility with rc scripts expecting /bin/rc
 update-alternatives --install /bin/rc rc /usr/lib/plan9/bin/rc 20
 
-# allow use of 9base' rc as a login shell:
-add-shell /bin/rc
-add-shell /usr/lib/plan9/bin/rc
-
 #DEBHELPER#
 
 exit 0
diff --minimal -Nru 9base-6/debian/postrm 9base-6/debian/postrm
--- 9base-6/debian/postrm	2022-03-17 21:15:01.000000000 +0100
+++ 9base-6/debian/postrm	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if [ "$1" = "remove" ]; then
-    remove-shell /bin/rc
-    remove-shell /usr/lib/plan9/bin/rc
-fi
-
-#DEBHELPER#
diff --minimal -Nru 9base-6/debian/rules 9base-6/debian/rules
--- 9base-6/debian/rules	2022-03-17 21:15:01.000000000 +0100
+++ 9base-6/debian/rules	2022-11-02 09:45:01.000000000 +0100
@@ -52,6 +52,8 @@
 		mv $$MANPAGE $${MANPAGE}$(MANEXT); \
 	done
 
+	install -D -m644 debian/shells $(PKGDIR)$(DATADIR)/debianutils/shells.d/plan9
+
 override_dh_fixperms:
 	dh_fixperms
 
diff --minimal -Nru 9base-6/debian/shells 9base-6/debian/shells
--- 9base-6/debian/shells	1970-01-01 01:00:00.000000000 +0100
+++ 9base-6/debian/shells	2022-11-02 09:45:01.000000000 +0100
@@ -0,0 +1,2 @@
+/bin/rc
+/usr/lib/plan9/bin/rc

Reply to: