[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#941296: marked as done (tuxcmd-modules FTCBFS: uses build architecture build tools)

Your message dated Tue, 29 Nov 2022 10:27:17 +0000
with message-id <E1ozxpd-007F1M-Gz@fasolo.debian.org>
and subject line Bug#941296: fixed in tuxcmd-modules 0.6.70+ds-6
has caused the Debian Bug report #941296,
regarding tuxcmd-modules FTCBFS: uses build architecture build tools
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
941296: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=941296
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: tuxcmd-modules
Version: 0.6.70+ds-5
Tags: patch upstream
User: debian-cross@lists.debian.org
Usertags: ftcbfs

tuxcmd-modules fails to cross build from source, because it uses build
architecture build tools. Some (like pkg-config) are simply hard coded.
For others it uses wildly varying variable names making substitution
impossible. The attached patch makes tuxcmd-modules use standard
variables. Please consider applying it.

Helmut

--- tuxcmd-modules-0.6.70+ds.orig/zip/Makefile
+++ tuxcmd-modules-0.6.70+ds/zip/Makefile
@@ -6,7 +6,8 @@
 
 # compiler options
 CC = gcc
-CPP = g++
+CXX = g++
+PKG_CONFIG ?= pkg-config
 CFLAGS =-I. -I$(DIR_ZIPARCHIVE) -I/usr/include \
 	-Wall -fPIC -O2 -g \
 	-DG_DISABLE_DEPRECATED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_GNU_SOURCE \
@@ -21,15 +22,15 @@
 
 .SUFFIXES: .c .cpp
 .c.o:
-	$(CPP) $(CFLAGS) `pkg-config glib-2.0 --cflags` -c $<
+	$(CXX) $(CFLAGS) `$(PKG_CONFIG) glib-2.0 --cflags` -c $<
 .cpp.o:
-	$(CPP) $(CFLAGS) `pkg-config glib-2.0 --cflags` -c $<
+	$(CXX) $(CFLAGS) `$(PKG_CONFIG) glib-2.0 --cflags` -c $<
 
 
 all shared static: libzip_plugin.so
 
 libzip_plugin.so: ziparchive $(VFS_COMMON_OBJECTS) $(VFS_CPP_OBJECTS) $(VFS_C_OBJECTS)
-	$(CPP) -shared -o libzip_plugin.so zip.o $(VFS_COMMON_OBJECTS) $(DIR_ZIPARCHIVE)libziparch.a -lz -lm $(CFLAGS) `pkg-config glib-2.0 --libs`
+	$(CXX) -shared -o libzip_plugin.so zip.o $(VFS_COMMON_OBJECTS) $(DIR_ZIPARCHIVE)libziparch.a -lz -lm $(CFLAGS) `$(PKG_CONFIG) glib-2.0 --libs`
 
 ziparchive:
 	( cd $(DIR_ZIPARCHIVE) && make -f ../Makefile.ziparch ) || exit 1
--- tuxcmd-modules-0.6.70+ds.orig/zip/Makefile.ziparch
+++ tuxcmd-modules-0.6.70+ds/zip/Makefile.ziparch
@@ -10,12 +10,6 @@
 #otherwise, the system's bzip2 library will be used
 #INTERNAL_BZIP2 = 1
 
-CC=g++
-
-CCC=cc
-#CCC=gcc
-	
-
 CFLAGS = -D ZIP_ARCHIVE_LNX -fPIC -g -O2
 #CFLAGS =
 
@@ -56,9 +50,9 @@
 
 .SUFFIXES: .c .cpp
 .c.o:
-	$(CCC) $(CFLAGS) $(INCLUDES) -c -o $*.o $<
+	$(CC) $(CFLAGS) $(INCLUDES) -c -o $*.o $<
 .cpp.o:
-	$(CC) $(CFLAGS) $(INCLUDES) -c $<
+	$(CXX) $(CFLAGS) $(INCLUDES) -c $<
 
 OBJS = $(ZLIBLOCATION)adler32.o $(ZLIBLOCATION)compress.o $(ZLIBLOCATION)crc32.o $(ZLIBLOCATION)uncompr.o $(ZLIBLOCATION)deflate.o $(ZLIBLOCATION)trees.o \
 $(ZLIBLOCATION)zutil.o $(ZLIBLOCATION)inflate.o $(ZLIBLOCATION)infback.o $(ZLIBLOCATION)inftrees.o $(ZLIBLOCATION)inffast.o\
@@ -148,7 +142,7 @@
 	-rm -f *.o *~ $(ZIPARCHLIB) $(ZLIBLOCATION)*.o $(ZLIBLOCATION)*~ $(BZIP2LOCATION)*.o $(BZIP2LOCATION)*~
 
 zippie:
-	$(CC) -I$(zipardir) $(CFLAGS) -o zippie $(ZIPPIELOCATION)zippie.cpp $(ZIPPIELOCATION)CmdLine.cpp $(LIBS)
+	$(CXX) -I$(zipardir) $(CFLAGS) -o zippie $(ZIPPIELOCATION)zippie.cpp $(ZIPPIELOCATION)CmdLine.cpp $(LIBS)
 	#$(CC) -I$(zipardir) -L$(libdir) $(CFLAGS) -o zippie $(ZIPPIELOCATION)zippie.cpp $(ZIPPIELOCATION)CmdLine.cpp $(LIBS)
 
 cleanzippie:
--- tuxcmd-modules-0.6.70+ds.orig/libarchive/Makefile
+++ tuxcmd-modules-0.6.70+ds/libarchive/Makefile
@@ -7,7 +7,8 @@
 
 # compiler options
 CC = gcc
-CPP = g++
+CXX = g++
+PKG_CONFIG ?= pkg-config
 CFLAGS =-I. -I/usr/include -I$(DIR_COMMON) \
 	-Wall -fPIC -O2 -g \
 	-DG_DISABLE_DEPRECATED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_GNU_SOURCE \
@@ -20,20 +21,20 @@
 
 .SUFFIXES: .c .cpp
 .c.o:
-	$(CC) $(CFLAGS) `pkg-config glib-2.0 --cflags` -c $<
+	$(CC) $(CFLAGS) `$(PKG_CONFIG) glib-2.0 --cflags` -c $<
 .cpp.o:
-	$(CPP) $(CFLAGS) `pkg-config glib-2.0 --cflags` -c $<
+	$(CXX) $(CFLAGS) `$(PKG_CONFIG) glib-2.0 --cflags` -c $<
 
 
 all: static
 
 
 shared: $(VFS_COMMON_OBJECTS) $(VFS_OBJECTS)
-	$(CC) -shared -o libarchive_plugin.so $(VFS_COMMON_OBJECTS) $(VFS_OBJECTS) $(CFLAGS) `pkg-config glib-2.0 --libs` -larchive -lz -lbz2
+	$(CC) -shared -o libarchive_plugin.so $(VFS_COMMON_OBJECTS) $(VFS_OBJECTS) $(CFLAGS) `$(PKG_CONFIG) glib-2.0 --libs` -larchive -lz -lbz2
 
 static: CFLAGS += -I$(DIR_LIBARCHIVE)/libarchive
 static: lib_libarchive_compile $(VFS_COMMON_OBJECTS) $(VFS_OBJECTS)
-	$(CC) -shared -o libarchive_plugin.so $(VFS_COMMON_OBJECTS) $(VFS_OBJECTS) $(DIR_LIBARCHIVE)/.libs/libarchive.a $(CFLAGS) `pkg-config glib-2.0 --libs` -lz -lbz2
+	$(CC) -shared -o libarchive_plugin.so $(VFS_COMMON_OBJECTS) $(VFS_OBJECTS) $(DIR_LIBARCHIVE)/.libs/libarchive.a $(CFLAGS) `$(PKG_CONFIG) glib-2.0 --libs` -lz -lbz2
 
 lib_libarchive_compile:
 	@which uudecode > /dev/null || exit 1;
--- tuxcmd-modules-0.6.70+ds.orig/gvfs/Makefile
+++ tuxcmd-modules-0.6.70+ds/gvfs/Makefile
@@ -5,6 +5,7 @@
 
 # compiler options
 CC = gcc
+PKG_CONFIG ?= pkg-config
 CFLAGS =-I. -I/usr/include \
 	-Wall -fPIC -O2 -g \
 	-DG_DISABLE_DEPRECATED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_GNU_SOURCE
@@ -18,13 +19,13 @@
 
 .SUFFIXES: .c
 .c.o:
-	$(CC) $(CFLAGS) `pkg-config glib-2.0 gio-2.0 --cflags` -c $<
+	$(CC) $(CFLAGS) `$(PKG_CONFIG) glib-2.0 gio-2.0 --cflags` -c $<
 
 
 all shared static: libgvfs_plugin.so
 
 libgvfs_plugin.so: $(VFS_COMMON_OBJECTS) $(VFS_OBJECTS)
-	$(CC) -shared -o libgvfs_plugin.so $(VFS_COMMON_OBJECTS) $(VFS_OBJECTS) $(CFLAGS) `pkg-config glib-2.0 gio-2.0 --libs`
+	$(CC) -shared -o libgvfs_plugin.so $(VFS_COMMON_OBJECTS) $(VFS_OBJECTS) $(CFLAGS) `$(PKG_CONFIG) glib-2.0 gio-2.0 --libs`
 
 strutils.o: strutils.c strutils.h
 treepathutils.o: treepathutils.c treepathutils.h

--- End Message ---
--- Begin Message --- 
Source: tuxcmd-modules
Source-Version: 0.6.70+ds-6
Done: Chris Lamb <lamby@debian.org>

We believe that the bug you reported is fixed in the latest version of
tuxcmd-modules, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 941296@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated tuxcmd-modules package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 29 Nov 2022 09:41:07 +0000
Source: tuxcmd-modules
Binary: tuxcmd-modules tuxcmd-modules-dbgsym
Architecture: source amd64
Version: 0.6.70+ds-6
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 tuxcmd-modules - VFS modules for tuxcmd file manager
Closes: 941296
Changes:
 tuxcmd-modules (0.6.70+ds-6) unstable; urgency=medium
 .
   * QA upload.
   * Actually apply a patch by Helmut Grohne to make it possible to cross-build
     tuxcmd-modules. This change was missing from the previous 0.6.70+ds-5.1
     upload; thanks to Vagrant Cascadian for spotting this. (Closes: #941296)
Checksums-Sha1:
 aedfb404b13f9cb28ab368c90bdf9f013b0feb7f 1867 tuxcmd-modules_0.6.70+ds-6.dsc
 bd233e743db6949ad28e506161cb93d4af9d2af9 334896 tuxcmd-modules_0.6.70+ds.orig.tar.gz
 df871563b49cf57a98927af70bd218779a4501fb 8012 tuxcmd-modules_0.6.70+ds-6.debian.tar.xz
 1b69859564a75d1979c936432483bb9dfae20b4c 1307432 tuxcmd-modules-dbgsym_0.6.70+ds-6_amd64.deb
 aeb32a8e2e8e900634aa75d7de24b7f91ea2c340 9100 tuxcmd-modules_0.6.70+ds-6_amd64.buildinfo
 cfb1de188d1cb4cbf5edd70fe65fb65413b9c337 138500 tuxcmd-modules_0.6.70+ds-6_amd64.deb
Checksums-Sha256:
 d4fd200986d559679d8f3186e761a15949a7a840d18892638405b997740fcd9b 1867 tuxcmd-modules_0.6.70+ds-6.dsc
 2577a41c065b359fde332612432b069b95a107a9dde86ba7362b74c01fc5f907 334896 tuxcmd-modules_0.6.70+ds.orig.tar.gz
 48fe1af8ecdd249898962c6d0dc781f36b0d3ea1ecd92b0a26e25f2286b0b418 8012 tuxcmd-modules_0.6.70+ds-6.debian.tar.xz
 d459c89a42d7e0057f90037b6829870eaabbf6aeecaf75ac5b4d18451ed1043c 1307432 tuxcmd-modules-dbgsym_0.6.70+ds-6_amd64.deb
 db850ee76b4fe6935bce8e29666b0f15d72579f55f03d50de2469db65bc54c21 9100 tuxcmd-modules_0.6.70+ds-6_amd64.buildinfo
 56a00de07d4257bf74e1af5df8694feaf74fd1f2589428dcbf6616fac7ee21a1 138500 tuxcmd-modules_0.6.70+ds-6_amd64.deb
Files:
 f57b8d20cf3aa89c131afae2d33f9ae9 1867 utils optional tuxcmd-modules_0.6.70+ds-6.dsc
 e62ee5fbf34fd29b7e5af2b303e3938b 334896 utils optional tuxcmd-modules_0.6.70+ds.orig.tar.gz
 f8fff7f62aa458dc2cdec36d1c6e49c5 8012 utils optional tuxcmd-modules_0.6.70+ds-6.debian.tar.xz
 ed9b74a4a12d4242100d8e65e7f58f5f 1307432 debug optional tuxcmd-modules-dbgsym_0.6.70+ds-6_amd64.deb
 efcabd60918377ef0192e550ff7dc9b9 9100 utils optional tuxcmd-modules_0.6.70+ds-6_amd64.buildinfo
 f6af94c0f47e9db9726596ef67337980 138500 utils optional tuxcmd-modules_0.6.70+ds-6_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAmOF1doACgkQHpU+J9Qx
Hlj/ZQ//RX695j5CIvd11sOM7W20LMtSVYvnFmF2YY1SyvyO4RmGx/WnhoyFpG7H
OjSvjk3yWByWMCz3qsxjUGNMw6vLsQZdpH/5Ag3SkZiYCrfrr6E2UoO9cw+Ba88t
EYO37rw63cSud9Jc0tZ/0P43c6WF8T70mbHnKNgL0wKTbOzOD6R9RteQVye0o1Y1
aSc/LI7j2bqu8fhhHx5JWojAKUfiGPng2SyA+S//isRks25+DpIq/fr3z6jX0uke
0gfPDng3O7/xLCELKzu1pVt/b/ZHRWTD5Is33gAqChD+u5BIepOt4o2I4Ff9iKVG
s9/HqXcsuGPjX/5+AM7NHdiYJMOklN2m1R91YmVncUvp3Ef7N1xyd/nl5AOZSATf
YQjqjBJ93kQFVjmYPZzscJ9b2qlyf25RWgYqGWpKBcxqeBbBgMR5SqrYM2w9S4gl
pllpKMYvneseEoE339A1qrq9vY8Xmowr847/kRYB69WOmEDXJE1DaJdn+obIIGEG
HijxAKEP0ljheWANxSDElvOBS/uaK76zPL2iDmUpIaJryZSXXcgv0SgChwiI49p8
bwFW5fg/ElnW7cJGvGJSrkBEnwCL8wQlHdBU/Jv/Y9wzv+6p0CQydi/OST9cqCjB
FvVr8lmKfp4ciLaH64ShmYy5tcj7IApoBX4D4tzPGhYjkCvZ17M=
=5dfm
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: