[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#941296: marked as done (tuxcmd-modules FTCBFS: uses build architecture build tools)

Your message dated Sun, 27 Nov 2022 18:22:12 +0000
with message-id <E1ozMI8-00Ew3G-VM@fasolo.debian.org>
and subject line Bug#941296: fixed in tuxcmd-modules 0.6.70+ds-5.1
has caused the Debian Bug report #941296,
regarding tuxcmd-modules FTCBFS: uses build architecture build tools
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
941296: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=941296
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: tuxcmd-modules
Version: 0.6.70+ds-5
Tags: patch upstream
User: debian-cross@lists.debian.org
Usertags: ftcbfs

tuxcmd-modules fails to cross build from source, because it uses build
architecture build tools. Some (like pkg-config) are simply hard coded.
For others it uses wildly varying variable names making substitution
impossible. The attached patch makes tuxcmd-modules use standard
variables. Please consider applying it.

Helmut

--- tuxcmd-modules-0.6.70+ds.orig/zip/Makefile
+++ tuxcmd-modules-0.6.70+ds/zip/Makefile
@@ -6,7 +6,8 @@
 
 # compiler options
 CC = gcc
-CPP = g++
+CXX = g++
+PKG_CONFIG ?= pkg-config
 CFLAGS =-I. -I$(DIR_ZIPARCHIVE) -I/usr/include \
 	-Wall -fPIC -O2 -g \
 	-DG_DISABLE_DEPRECATED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_GNU_SOURCE \
@@ -21,15 +22,15 @@
 
 .SUFFIXES: .c .cpp
 .c.o:
-	$(CPP) $(CFLAGS) `pkg-config glib-2.0 --cflags` -c $<
+	$(CXX) $(CFLAGS) `$(PKG_CONFIG) glib-2.0 --cflags` -c $<
 .cpp.o:
-	$(CPP) $(CFLAGS) `pkg-config glib-2.0 --cflags` -c $<
+	$(CXX) $(CFLAGS) `$(PKG_CONFIG) glib-2.0 --cflags` -c $<
 
 
 all shared static: libzip_plugin.so
 
 libzip_plugin.so: ziparchive $(VFS_COMMON_OBJECTS) $(VFS_CPP_OBJECTS) $(VFS_C_OBJECTS)
-	$(CPP) -shared -o libzip_plugin.so zip.o $(VFS_COMMON_OBJECTS) $(DIR_ZIPARCHIVE)libziparch.a -lz -lm $(CFLAGS) `pkg-config glib-2.0 --libs`
+	$(CXX) -shared -o libzip_plugin.so zip.o $(VFS_COMMON_OBJECTS) $(DIR_ZIPARCHIVE)libziparch.a -lz -lm $(CFLAGS) `$(PKG_CONFIG) glib-2.0 --libs`
 
 ziparchive:
 	( cd $(DIR_ZIPARCHIVE) && make -f ../Makefile.ziparch ) || exit 1
--- tuxcmd-modules-0.6.70+ds.orig/zip/Makefile.ziparch
+++ tuxcmd-modules-0.6.70+ds/zip/Makefile.ziparch
@@ -10,12 +10,6 @@
 #otherwise, the system's bzip2 library will be used
 #INTERNAL_BZIP2 = 1
 
-CC=g++
-
-CCC=cc
-#CCC=gcc
-	
-
 CFLAGS = -D ZIP_ARCHIVE_LNX -fPIC -g -O2
 #CFLAGS =
 
@@ -56,9 +50,9 @@
 
 .SUFFIXES: .c .cpp
 .c.o:
-	$(CCC) $(CFLAGS) $(INCLUDES) -c -o $*.o $<
+	$(CC) $(CFLAGS) $(INCLUDES) -c -o $*.o $<
 .cpp.o:
-	$(CC) $(CFLAGS) $(INCLUDES) -c $<
+	$(CXX) $(CFLAGS) $(INCLUDES) -c $<
 
 OBJS = $(ZLIBLOCATION)adler32.o $(ZLIBLOCATION)compress.o $(ZLIBLOCATION)crc32.o $(ZLIBLOCATION)uncompr.o $(ZLIBLOCATION)deflate.o $(ZLIBLOCATION)trees.o \
 $(ZLIBLOCATION)zutil.o $(ZLIBLOCATION)inflate.o $(ZLIBLOCATION)infback.o $(ZLIBLOCATION)inftrees.o $(ZLIBLOCATION)inffast.o\
@@ -148,7 +142,7 @@
 	-rm -f *.o *~ $(ZIPARCHLIB) $(ZLIBLOCATION)*.o $(ZLIBLOCATION)*~ $(BZIP2LOCATION)*.o $(BZIP2LOCATION)*~
 
 zippie:
-	$(CC) -I$(zipardir) $(CFLAGS) -o zippie $(ZIPPIELOCATION)zippie.cpp $(ZIPPIELOCATION)CmdLine.cpp $(LIBS)
+	$(CXX) -I$(zipardir) $(CFLAGS) -o zippie $(ZIPPIELOCATION)zippie.cpp $(ZIPPIELOCATION)CmdLine.cpp $(LIBS)
 	#$(CC) -I$(zipardir) -L$(libdir) $(CFLAGS) -o zippie $(ZIPPIELOCATION)zippie.cpp $(ZIPPIELOCATION)CmdLine.cpp $(LIBS)
 
 cleanzippie:
--- tuxcmd-modules-0.6.70+ds.orig/libarchive/Makefile
+++ tuxcmd-modules-0.6.70+ds/libarchive/Makefile
@@ -7,7 +7,8 @@
 
 # compiler options
 CC = gcc
-CPP = g++
+CXX = g++
+PKG_CONFIG ?= pkg-config
 CFLAGS =-I. -I/usr/include -I$(DIR_COMMON) \
 	-Wall -fPIC -O2 -g \
 	-DG_DISABLE_DEPRECATED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_GNU_SOURCE \
@@ -20,20 +21,20 @@
 
 .SUFFIXES: .c .cpp
 .c.o:
-	$(CC) $(CFLAGS) `pkg-config glib-2.0 --cflags` -c $<
+	$(CC) $(CFLAGS) `$(PKG_CONFIG) glib-2.0 --cflags` -c $<
 .cpp.o:
-	$(CPP) $(CFLAGS) `pkg-config glib-2.0 --cflags` -c $<
+	$(CXX) $(CFLAGS) `$(PKG_CONFIG) glib-2.0 --cflags` -c $<
 
 
 all: static
 
 
 shared: $(VFS_COMMON_OBJECTS) $(VFS_OBJECTS)
-	$(CC) -shared -o libarchive_plugin.so $(VFS_COMMON_OBJECTS) $(VFS_OBJECTS) $(CFLAGS) `pkg-config glib-2.0 --libs` -larchive -lz -lbz2
+	$(CC) -shared -o libarchive_plugin.so $(VFS_COMMON_OBJECTS) $(VFS_OBJECTS) $(CFLAGS) `$(PKG_CONFIG) glib-2.0 --libs` -larchive -lz -lbz2
 
 static: CFLAGS += -I$(DIR_LIBARCHIVE)/libarchive
 static: lib_libarchive_compile $(VFS_COMMON_OBJECTS) $(VFS_OBJECTS)
-	$(CC) -shared -o libarchive_plugin.so $(VFS_COMMON_OBJECTS) $(VFS_OBJECTS) $(DIR_LIBARCHIVE)/.libs/libarchive.a $(CFLAGS) `pkg-config glib-2.0 --libs` -lz -lbz2
+	$(CC) -shared -o libarchive_plugin.so $(VFS_COMMON_OBJECTS) $(VFS_OBJECTS) $(DIR_LIBARCHIVE)/.libs/libarchive.a $(CFLAGS) `$(PKG_CONFIG) glib-2.0 --libs` -lz -lbz2
 
 lib_libarchive_compile:
 	@which uudecode > /dev/null || exit 1;
--- tuxcmd-modules-0.6.70+ds.orig/gvfs/Makefile
+++ tuxcmd-modules-0.6.70+ds/gvfs/Makefile
@@ -5,6 +5,7 @@
 
 # compiler options
 CC = gcc
+PKG_CONFIG ?= pkg-config
 CFLAGS =-I. -I/usr/include \
 	-Wall -fPIC -O2 -g \
 	-DG_DISABLE_DEPRECATED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_GNU_SOURCE
@@ -18,13 +19,13 @@
 
 .SUFFIXES: .c
 .c.o:
-	$(CC) $(CFLAGS) `pkg-config glib-2.0 gio-2.0 --cflags` -c $<
+	$(CC) $(CFLAGS) `$(PKG_CONFIG) glib-2.0 gio-2.0 --cflags` -c $<
 
 
 all shared static: libgvfs_plugin.so
 
 libgvfs_plugin.so: $(VFS_COMMON_OBJECTS) $(VFS_OBJECTS)
-	$(CC) -shared -o libgvfs_plugin.so $(VFS_COMMON_OBJECTS) $(VFS_OBJECTS) $(CFLAGS) `pkg-config glib-2.0 gio-2.0 --libs`
+	$(CC) -shared -o libgvfs_plugin.so $(VFS_COMMON_OBJECTS) $(VFS_OBJECTS) $(CFLAGS) `$(PKG_CONFIG) glib-2.0 gio-2.0 --libs`
 
 strutils.o: strutils.c strutils.h
 treepathutils.o: treepathutils.c treepathutils.h

--- End Message ---
--- Begin Message --- 
Source: tuxcmd-modules
Source-Version: 0.6.70+ds-5.1
Done: Chris Lamb <lamby@debian.org>

We believe that the bug you reported is fixed in the latest version of
tuxcmd-modules, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 941296@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated tuxcmd-modules package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 17 Nov 2022 17:15:30 +0000
Source: tuxcmd-modules
Binary: tuxcmd-modules tuxcmd-modules-dbgsym
Architecture: source amd64
Version: 0.6.70+ds-5.1
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 tuxcmd-modules - VFS modules for tuxcmd file manager
Closes: 941296 1011500
Changes:
 tuxcmd-modules (0.6.70+ds-5.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Apply a patch by Vagrant Cascadian to ensure that tuxcmd-modules does not
     embed build paths in various binaries. (Closes: #1011500)
   * Apply a patch by Helmut Grohne to make it possible to cross-build
     tuxcmd-modules. (Closes: #941296)
Checksums-Sha1:
 6fc6ac3504be05519bc4b735f90243e135729577 1875 tuxcmd-modules_0.6.70+ds-5.1.dsc
 bd233e743db6949ad28e506161cb93d4af9d2af9 334896 tuxcmd-modules_0.6.70+ds.orig.tar.gz
 a264c655b39265b65c4065d58fab6572c96b0257 6868 tuxcmd-modules_0.6.70+ds-5.1.debian.tar.xz
 42dc661e2086ac54df0c42e5ffbd1b6ae7dbc4fa 1307420 tuxcmd-modules-dbgsym_0.6.70+ds-5.1_amd64.deb
 e4e4014005f9d087cd810769b5e32986a8f879ed 9119 tuxcmd-modules_0.6.70+ds-5.1_amd64.buildinfo
 bfb94903a3657ed8b33ffe5ad0ae7737b1eb20a3 138300 tuxcmd-modules_0.6.70+ds-5.1_amd64.deb
Checksums-Sha256:
 96e8930d7de3491aac8ae313fe0899e955de9da168342e7f9a0f8474146aa29d 1875 tuxcmd-modules_0.6.70+ds-5.1.dsc
 2577a41c065b359fde332612432b069b95a107a9dde86ba7362b74c01fc5f907 334896 tuxcmd-modules_0.6.70+ds.orig.tar.gz
 d234e066ce887b420b25abf77d8049ccc3297ecde7f1f49c5625eb57f81a6783 6868 tuxcmd-modules_0.6.70+ds-5.1.debian.tar.xz
 2d5f5f09ec8e65f3b596833fe61a02663cd5cc5219b7fce50da7703860eadea5 1307420 tuxcmd-modules-dbgsym_0.6.70+ds-5.1_amd64.deb
 df12ddf7cb6e14f13e9b05d935411db7d0459d8f0e947b89a0b47468db147058 9119 tuxcmd-modules_0.6.70+ds-5.1_amd64.buildinfo
 2692687ea478b023ece770fa70a1e351992e9fec72e66c8f6192187176c4861a 138300 tuxcmd-modules_0.6.70+ds-5.1_amd64.deb
Files:
 3c8e452d7fb0b5425894a5691f529ca0 1875 utils optional tuxcmd-modules_0.6.70+ds-5.1.dsc
 e62ee5fbf34fd29b7e5af2b303e3938b 334896 utils optional tuxcmd-modules_0.6.70+ds.orig.tar.gz
 fce9c00c254fd7d7f563dceacc40d4fa 6868 utils optional tuxcmd-modules_0.6.70+ds-5.1.debian.tar.xz
 3b3327be788e6252da55671fa7344905 1307420 debug optional tuxcmd-modules-dbgsym_0.6.70+ds-5.1_amd64.deb
 7b920c4425f943703b4367474ffc21fd 9119 utils optional tuxcmd-modules_0.6.70+ds-5.1_amd64.buildinfo
 7322b7342f4388b0b66ea75cc32ca8bf 138300 utils optional tuxcmd-modules_0.6.70+ds-5.1_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAmN2bc8ACgkQHpU+J9Qx
Hli7MxAApPcmR/mNDPgbS/zFEaYK0QrBJopaehbvtr/Tv2xUPAEd6DQoN+RPSIou
lp/u8/x+AYSmOBkoPZwx5arN+rbowVIMocSrmgMtc3GzrAdDGVwNU1LbTfczT5BV
PAgTQnnt6WYmXza0rixRpWYH/e3McpEJXL+zyq/G/P6C9ACsURstwY5aKwhK4k8u
H1kCpeEylpzxq68s2rV7OZPPMyTPkbcQ3fStfTGBw2k/qtEQ/2ruRcgdn/r49bSb
KCut+YsZ+xLB2TbPxWOMl1tvlx+J17ShhOQJB5mbA5nlq+NqunCQWLqrSZFTk3P2
0JyA5ncIkyPf+crGKmfQSZp/icXgHDOTJgYgSTcu4BUKjUm283bZrg0b1egajgVA
4MLJRXK4ddWkbpLqYbrJLi5jt9AcPKF5H/8L3Tp6RHvutORgAob7bQ9jRDTiD9Pe
HXzI07lKAGir+VZuE65K129B+lmJvSpcfKEEltxdlE5hgOzeuCXVIXGItdN2LHOI
qpskOFrqENXnLJnJoJ6hcONr3JhTDk+qziNNdwaaD1VjASErGauriK98Y3uzdHok
ORjQ3s5TzzQVaoX/hjbSnKXqQW17umZpD9CJ81ECFkBvlgZ8zZ+sRxdhafwYCr6j
5TdgXEcN0sBunDEQb1jIVI6/yBD3iU3nzrRMU1MMx/sWssHFY38=
=n8IO
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: