Your message dated Sun, 15 Dec 2019 23:35:49 +0000 with message-id <E1igdQT-0004ch-JA@fasolo.debian.org> and subject line Bug#946386: fixed in opendkim 2.11.0~alpha-13 has caused the Debian Bug report #946386, regarding miltertest’s mt.data() always results in timeout to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org immediately.) -- 946386: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=946386 Debian Bug Tracking System Contact owner@bugs.debian.org with problems
--- Begin Message ---
- To: submit@bugs.debian.org
- Subject: miltertest’s mt.data() always results in timeout
- From: David Bürgin <dbuergin@gluet.ch>
- Date: Sun, 8 Dec 2019 13:02:22 +0100
- Message-id: <[🔎] 20191208120222.GA2892@azadi>
Package: opendkim-tools Version: 2.11.0~alpha-12 The implementation of mt.data() is broken. The state management uses the wrong constants, thereby causing any use of mt.data() to time out: miltertest: select(): timeout on fd 3 The fix is straightforward. Align the mistaken use of STATE_* constants in mt_data and mt_header with how it’s done elsewhere. The review is also straightforward, just glance at the other functions, and you’ll see immediately that it is a trivial bug and fix. Unfortunately this bug renders miltertest unusable for milters that use the ‘data’ stage. I would much appreciate if we could get this patch in. Please let me know if I can assist you in any way. Thank you! --- a/miltertest/miltertest.c 2014-03-20 05:36:13.000000000 +0100 +++ b/miltertest/miltertest.c 2019-12-08 12:46:55.531515893 +0100 @@ -2566,7 +2566,7 @@ ctx = (struct mt_context *) lua_touserdata(l, 1); lua_pop(l, 1); - if (!mt_assert_state(ctx, STATE_DATA)) + if (!mt_assert_state(ctx, STATE_ENVRCPT)) lua_error(l); if (CHECK_MPOPTS(ctx, SMFIP_NODATA)) @@ -2663,7 +2663,7 @@ #endif /* SMFIP_HDR_LEADSPC */ memcpy(bp, value, strlen(value) + 1); - if (!mt_assert_state(ctx, STATE_ENVRCPT)) + if (!mt_assert_state(ctx, STATE_DATA)) lua_error(l); if (CHECK_MPOPTS(ctx, SMFIP_NOHDRS))Attachment: signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
- To: 946386-close@bugs.debian.org
- Subject: Bug#946386: fixed in opendkim 2.11.0~alpha-13
- From: David Bürgin <dbuergin@gluet.ch>
- Date: Sun, 15 Dec 2019 23:35:49 +0000
- Message-id: <E1igdQT-0004ch-JA@fasolo.debian.org>
Source: opendkim Source-Version: 2.11.0~alpha-13 We believe that the bug you reported is fixed in the latest version of opendkim, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 946386@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. David Bürgin <dbuergin@gluet.ch> (supplier of updated opendkim package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmaster@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Sat, 14 Dec 2019 17:00:36 +0100 Source: opendkim Architecture: source Version: 2.11.0~alpha-13 Distribution: unstable Urgency: medium Maintainer: David Bürgin <dbuergin@gluet.ch> Changed-By: David Bürgin <dbuergin@gluet.ch> Closes: 946386 Changes: opendkim (2.11.0~alpha-13) unstable; urgency=medium . * miltertest: Fix broken mt.data() function (Closes: #946386) * Set maintainer to David Bürgin, who intends to adopt the package Checksums-Sha1: 2ced61c7eb13001eb095084b0ca5d1e22961828c 2365 opendkim_2.11.0~alpha-13.dsc 8e45a589243554442dae6a8182aa2bc81e022d1c 26284 opendkim_2.11.0~alpha-13.debian.tar.xz 8577a6ed45f980d62b4bf33e110f56aaa6b95bd2 5940 opendkim_2.11.0~alpha-13_source.buildinfo Checksums-Sha256: 71fc9cfe160baa445af970a2d6cf4fbbdadf9bed63c866219e9d2022fd0080a9 2365 opendkim_2.11.0~alpha-13.dsc ed476e4a78b42a6041328d25f35f5a207e84992a584c84d14fb15cc0e593d0ad 26284 opendkim_2.11.0~alpha-13.debian.tar.xz 970fdfa3f1f86fbe4150e317c0fd2a6e9e096712ce3be957fb67be0ed6c77160 5940 opendkim_2.11.0~alpha-13_source.buildinfo Files: e65e967abe8b895aaa7c4e4c68502b73 2365 mail extra opendkim_2.11.0~alpha-13.dsc 1dde0c0f77ffaa87f54a0b1537f55ea5 26284 mail extra opendkim_2.11.0~alpha-13.debian.tar.xz 46aa615d4d466356b472f868026574c2 5940 mail extra opendkim_2.11.0~alpha-13_source.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEkjZVexcMh/iCHArDweDZLphvfH4FAl32vqcACgkQweDZLphv fH4yvw/9FUmpYln0/e/sCthwUCJRMFwuOujs0pTK7bD6FFYnzEfJwlXD3349NbyF zcg7IkXYrBEDpl+4fFzOS/Zju6HYrRKAJgGR6bwgh0N5FMi14rmwtQ13XeOZp4hO k5AK6TVycnM8YBjwwG6CFbS7p/d6wyz2l0EATVNXOPhVWpNiPDxZerJptrpz0+hI Cj7q7xQfkp3RIMyaNPCjPKinlQ1oEY7ZZ8Tx4xPvwdp3VF9ZNvDmr2FEHbKUkN/3 GDXw1ryM06I0kLGxVAZvea9/LI+XA6ojs7NSwhth6IH1D3MxsfsVszmEm3wq+3Yk EtYN1ced0hP6JPb7Hs5dnArd3U4EU82jI2K9JGoZXQspfw5NaWmNnOE9qk5rD6Yd 2DR4TICt9/zAd7jMGfaibvBN4cwZQilMniuTRXnSYwWOa9jrTdoo2BszZBAGC9XW ljHfdsn3vtIkhNVKqUjIxID5GP2rc3jHr4UvClidOq/7L9LBbF+M5NT1VRIRbKzq EdQCpU6+ipAWZQ9DNBfauYAC+yjCLecE6dv9oNxm/U7xd5zrr1/yam7AtP5WpyJG TNPrBRMTbGdP5sUEOebBfWrKgo4kJukgJ+joMuCpUhlZo0REEmlGSbxs0FwOKxLc 1NFeHHJm3PUdL3y4RXjRbjePdDiklrIASRMdUMs/ULYhHHwWrGU= =wtmQ -----END PGP SIGNATURE-----
--- End Message ---