Package: opendkim-tools
Version: 2.11.0~alpha-12
The MT_SMTPREPLY case in mt_eom_check prints two possibly-NULL char
pointers via format string %s. This triggers undefined behaviour. On my
machine, these pointers are printed as the string ‘(null)’. In any case
this distorts the test result.
The attached patch fixes this by making sure the two char pointers ‘esc’
and ‘text’ are only passed to snprintf when they are not NULL.
--- a/miltertest/miltertest.c 2014-03-20 05:36:13.000000000 +0100
+++ b/miltertest/miltertest.c 2019-12-08 14:17:53.539942468 +0100
@@ -3645,8 +3645,8 @@
snprintf(rbuf, sizeof rbuf, "%s%s%s%s%s",
smtp,
- esc == NULL ? "" : " ", esc,
- text == NULL ? "" : " ", text);
+ esc == NULL ? "" : " ", esc == NULL ? "" : esc,
+ text == NULL ? "" : " ", text == NULL ? "" : text);
if (strcmp(rbuf, (char *) r->eom_rdata) == 0)
{
Attachment:
signature.asc
Description: PGP signature