[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#945773: [PATCH] Log mi_stop flag on debug level when closing socket



On 28/11/2019 14:00, Andreas Beckmann wrote:
> On 28/11/2019 13.39, David Bürgin wrote:
>> Given all this, I want to propose changing the log level of this message
>> to debug (SMI_LOG_DEBUG), guarded by ‘if (dbg > 0)’ as elsewhere.
> 
> Your reasoning sounds plausible. Can you provide a patch?

Sure, it’s a tiny patch. Thank you!

---
 libmilter/listener.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libmilter/listener.c b/libmilter/listener.c
index 11d92bb..d009621 100644
--- a/libmilter/listener.c
+++ b/libmilter/listener.c
@@ -979,8 +979,8 @@ mi_listener(conn, dbg, smfi, timeout, backlog)
 		mi_stop_milters(MILTER_ABRT);
 	else
 	{
-		if (mistop != MILTER_CONT)
-			smi_log(SMI_LOG_INFO, "%s: mi_stop=%d",
+		if (mistop != MILTER_CONT && dbg > 0)
+			smi_log(SMI_LOG_DEBUG, "%s: mi_stop=%d",
 				smfi->xxfi_name, mistop);
 		mi_closener();
 	}
-- 
2.17.1


Reply to: