[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#945773: Unnecessary debug message logged at info level on shutdown



Package: libmilter-dev
Version: 8.15.2-15

Every time a milter exits a log message like the following appears in
syslog:

Nov 26 11:35:22 buster my_milter[13781]: my_milter: mi_stop=1

This message is logged at info level, but it looks like a debug message:
it refers to the internal function name ‘mi_stop’, and shows a numeric
exit code that can only be understood by referring to the libmilter
source code or header file. It is not a message aimed at end users. It
is also not clear to me from inspecting the source what the meaning of
the two numeric codes (1 and 2) is, or what use the distinction is to
users.

This message is the only info-level diagnostic in libmilter; the only
other similar message is the one reporting successful opening of a
listening socket. That message uses the debug log level (the only
occurrence of the debug log level in libmilter). All other messages use
the error/warning log levels.

Finally, libmilter is a milter programming *library*. Actual milter
applications are the clients of this library; it is their business to
log application start and stop at an appropriate level.

Given all this, I want to propose changing the log level of this message
to debug (SMI_LOG_DEBUG), guarded by ‘if (dbg > 0)’ as elsewhere.

Attachment: signature.asc
Description: PGP signature


Reply to: