Bug#902454: bochs: FTBFS in buster/sid ('AmlCode' undeclared)

[Santiago Vila <sanvila@debian.org>]

Package: src:bochs
Version: 2.6-5
Severity: serious
Tags: ftbfs

Dear maintainer:

I tried to build this package in buster with "dpkg-buildpackage -A"
but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh_testdir
libtoolize -c
libtoolize: putting auxiliary files in '.'.
libtoolize: copying file './compile'
libtoolize: copying file './config.guess'
libtoolize: copying file './config.sub'
libtoolize: copying file './depcomp'
libtoolize: copying file './install-sh'
libtoolize: copying file './missing'
libtoolize: copying file './ltmain.sh'
libtoolize: putting macros in 'libltdl/m4'.
libtoolize: copying file 'libltdl/m4/libtool.m4'

[... snipped ...]


acpi-dsdt.dsl.i    631:             Return(0x01)
Warning  3104 -                              ^ Reserved method should not return a value (_L0E)

acpi-dsdt.dsl.i    634:             Return(0x01)
Warning  3104 -                              ^ Reserved method should not return a value (_L0F)


Intel ACPI Component Architecture
ASL+ Optimizing Compiler/Disassembler version 20180508
Copyright (c) 2000 - 2018 Intel Corporation

ASL Input:     acpi-dsdt.dsl.i - 639 lines, 29236 bytes, 707 keywords
AML Output:    acpi-dsdt.aml - 7585 bytes, 253 named objects, 454 executable opcodes
Hex Dump:      acpi-dsdt.hex - 71586 bytes

Compilation complete. 0 Errors, 51 Warnings, 10 Remarks, 494 Optimizations, 93 Constants Folded
rm acpi-dsdt.dsl.i
sed -i -e's/^unsigned/const unsigned/' acpi-dsdt.hex
gcc -m32 -fno-stack-protector -O2 -Wall -c -o rombios32.o rombios32.c
rombios32.c: In function 'setup_mtrr':
rombios32.c:501:23: warning: variable 'wc' set but not used [-Wunused-but-set-variable]
     int i, vcnt, fix, wc;
                       ^~
In file included from rombios32.c:1454:0:
acpi-dsdt.hex: At top level:
acpi-dsdt.hex:13:15: warning: extra tokens at end of #ifndef directive
 #ifndef __ACPI-DSDT_HEX__
               ^
acpi-dsdt.hex:14:15: warning: ISO C99 requires whitespace after the macro name
 #define __ACPI-DSDT_HEX__
               ^
acpi-dsdt.hex:16:25: error: expected '=', ',', ';', 'asm' or '__attribute__' before '-' token
 const unsigned char acpi-dsdt_aml_code[] =
                         ^
rombios32.c: In function 'acpi_bios_init':
rombios32.c:1609:20: error: 'AmlCode' undeclared (first use in this function)
     addr += sizeof(AmlCode);
                    ^~~~~~~
rombios32.c:1609:20: note: each undeclared identifier is reported only once for each function it appears in
Makefile:125: recipe for target 'rombios32.o' failed
make[1]: *** [rombios32.o] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>/bios'
debian/rules:135: recipe for target 'build-indep' failed
make: *** [build-indep] Error 2
dpkg-buildpackage: error: debian/rules build-indep subprocess returned exit status 2
--------------------------------------------------------------------------------

The above is how the build ends in my autobuilder and it's not
necessarily the relevant part.

The failure is not, however, related to using dpkg-buildpackage -A,
as it also fails in reproducible builds:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/bochs.html

If this is really a bug in one of the build-depends, please use reassign and affects,
so that this is still visible in the page for this package.

Thanks.