[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#826982: marked as done (hoichess: please make the build reproducible)

Your message dated Fri, 09 Sep 2016 22:09:38 +0000
with message-id <E1biTzO-0004R7-GD@franck.debian.org>
and subject line Bug#826982: fixed in hoichess 0.19.0-3
has caused the Debian Bug report #826982,
regarding hoichess: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
826982: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=826982
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: hoichess
Version: 0.10.3-6.1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: fileordering
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that hoichess could not be built reproducibly.
The list of object files is unsorted, which causes a non-deterministic
linking order.

The attached patch fixes this.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds

diff --git a/debian/patches/06-reproducible-build b/debian/patches/06-reproducible-build
new file mode 100644
index 0000000..d6e6e80
--- /dev/null
+++ b/debian/patches/06-reproducible-build
@@ -0,0 +1,13 @@
+--- a/src/Makefile
++++ b/src/Makefile
+@@ -35,8 +35,8 @@
+ OBJS_CHESS   = $(patsubst %.cc,%.o,$(SOURCES_CHESS))
+ OBJS_XIANGQI = $(patsubst %.cc,%.o,$(SOURCES_XIANGQI))
+ 
+-BUILDDIR_OBJS_CHESS   = $(foreach f,$(OBJS_COMMON) $(OBJS_CHESS),$(BUILDDIR_CHESS)/$(f))
+-BUILDDIR_OBJS_XIANGQI = $(foreach f,$(OBJS_COMMON) $(OBJS_XIANGQI),$(BUILDDIR_XIANGQI)/$(f))
++BUILDDIR_OBJS_CHESS   = $(sort $(foreach f,$(OBJS_COMMON) $(OBJS_CHESS),$(BUILDDIR_CHESS)/$(f)))
++BUILDDIR_OBJS_XIANGQI = $(sort $(foreach f,$(OBJS_COMMON) $(OBJS_XIANGQI),$(BUILDDIR_XIANGQI)/$(f)))
+ 
+ 
+ INCLUDE = -I.
diff --git a/debian/patches/series b/debian/patches/series
index bc6946b..4ba8907 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -3,3 +3,4 @@
 03-config.h
 04-debug_printconfig.h
 05-ftbfs-gcc-4.7
+06-reproducible-build

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: hoichess
Source-Version: 0.19.0-3

We believe that the bug you reported is fixed in the latest version of
hoichess, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 826982@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Samuel Henrique <samueloph@gmail.com> (supplier of updated hoichess package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 09 Sep 2016 11:57:30 -0300
Source: hoichess
Binary: hoichess
Architecture: source
Version: 0.19.0-3
Distribution: unstable
Urgency: medium
Maintainer: Samuel Henrique <samueloph@gmail.com>
Changed-By: Samuel Henrique <samueloph@gmail.com>
Description:
 hoichess   - xboard compatible chess engine to play chess with
Closes: 826982 835307
Changes:
 hoichess (0.19.0-3) unstable; urgency=medium
 .
   * New maintainer. Thanks to all previous people that have worked on this
     package, special mention to Joao Eriberto Mota Filho <eriberto@debian.org>,
     whom sponsored me and dedicated a lot of time and effort into reviewing my
     changes (closes: #835307).
   * debian/copyright: Switch to DEP-5 format.
   * debian/patches:
     - reproducible-build.patch: New patch, sort source files for deterministic
       linking order, thanks to Reiner Herrmann (closes: #826982).
Checksums-Sha1:
 a2259c6d86f915c50fc8f806f6b389c91f351d42 1842 hoichess_0.19.0-3.dsc
 6b5ab0ba777dd310698107e7f81a0990b218258a 6396 hoichess_0.19.0-3.debian.tar.xz
Checksums-Sha256:
 adf8668116c2a39df59449cbe9fcdcfd9ad6dd67013bc462a43e7f917434c930 1842 hoichess_0.19.0-3.dsc
 cf5057628363641205b23d09839283dd2505c3c4f49a59b0b01e99fe640ec2f9 6396 hoichess_0.19.0-3.debian.tar.xz
Files:
 ea74c9c3cf5b729257880fb1ef179f3c 1842 games optional hoichess_0.19.0-3.dsc
 3ed3619ed3a4ec3c08fe30d65a3eb897 6396 games optional hoichess_0.19.0-3.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJX0yg1AAoJEN5juccE6+nvdwgQAJIPnPCQ16uPBLSCmiKbAG8s
C9JCoqIH6nkmJoXm/dVzHBwCtJVzAISQlnjxGKF3fW4ZW5Ro89I11r3wmH0o/SWf
vjZ0eefZAmi3diGfrZnCCD+h/ucwfb08qJ8f6fVPyPr3CFsyVSiLEyvRb2qEihPY
4Q4OOXa2zJjohbPLktVkJvQIO7Qgjw5aq566rg2oYjhGUwsrNjY+jpBdNbGF0W0G
kuLoyB7Y5WrDmTKtS7eWHHhLvSXI4raDoiRhNAqU5XSDHIn/x/K9kdmbtm5eh2zl
sUWsW9wuo0lfq2h/ag4Lp9f0nxZk/YGFt0mEok1JwRNB5INXxRHwFMzV5EITCg8a
E+NlnaN1vLltQoSR+CpbEwKF9C/0vvFk2WVhShzw1hGVuR/MXFC5pPcz/Tv2F9DX
NJtc5ujuN+PoCyKnQOXYLWWEr6A76cUHIT4HX+MNEaCME+8nRODDoNMFH4rgPaEW
fIEeECj0rMnbAaKQ4dr8+5dWBD85m//6DNxxfkaWbL+NHAUAv6EHunM0sHIoHr7w
qrpOSWYInyYS77gOk626bQ+AmQ4YJm9ZfU8UOCqLCemg3m7CJN3WENcYMgg7ibOL
Si1cKlZ5pZaHpn9h1O5owr4JBmqIGK52myK6nYwQ8ahFJ3POLaG2ILrts54QpWN9
NWZWwjsn7Bt8a7K8/1uh
=2UFl
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: