[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#826982: marked as done (hoichess: please make the build reproducible)

Your message dated Thu, 8 Sep 2016 16:47:29 +0200
with message-id <49460ea0-03c3-44dd-67b3-df650449218f@debian.org>
and subject line hoichess, reproducible on amd64
has caused the Debian Bug report #826982,
regarding hoichess: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
826982: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=826982
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: hoichess
Version: 0.10.3-6.1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: fileordering
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that hoichess could not be built reproducibly.
The list of object files is unsorted, which causes a non-deterministic
linking order.

The attached patch fixes this.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds

diff --git a/debian/patches/06-reproducible-build b/debian/patches/06-reproducible-build
new file mode 100644
index 0000000..d6e6e80
--- /dev/null
+++ b/debian/patches/06-reproducible-build
@@ -0,0 +1,13 @@
+--- a/src/Makefile
++++ b/src/Makefile
+@@ -35,8 +35,8 @@
+ OBJS_CHESS   = $(patsubst %.cc,%.o,$(SOURCES_CHESS))
+ OBJS_XIANGQI = $(patsubst %.cc,%.o,$(SOURCES_XIANGQI))
+ 
+-BUILDDIR_OBJS_CHESS   = $(foreach f,$(OBJS_COMMON) $(OBJS_CHESS),$(BUILDDIR_CHESS)/$(f))
+-BUILDDIR_OBJS_XIANGQI = $(foreach f,$(OBJS_COMMON) $(OBJS_XIANGQI),$(BUILDDIR_XIANGQI)/$(f))
++BUILDDIR_OBJS_CHESS   = $(sort $(foreach f,$(OBJS_COMMON) $(OBJS_CHESS),$(BUILDDIR_CHESS)/$(f)))
++BUILDDIR_OBJS_XIANGQI = $(sort $(foreach f,$(OBJS_COMMON) $(OBJS_XIANGQI),$(BUILDDIR_XIANGQI)/$(f)))
+ 
+ 
+ INCLUDE = -I.
diff --git a/debian/patches/series b/debian/patches/series
index bc6946b..4ba8907 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -3,3 +3,4 @@
 03-config.h
 04-debug_printconfig.h
 05-ftbfs-gcc-4.7
+06-reproducible-build

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Hi, this patch is not working anymore unfortunately (the new upstream changed the Makefile and the patch doesn't apply
anymore)

I see amd64 seems fixed now, but armhf and i386 aren't.

I think this might be due to a bug in the toolchain rather than a bug in the software, and I'm closing this one.

Unfortunately I have no skills to check these dbg differences

G.

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
Reply to: