> The package has been accepted on the mentor queue and is available here:
> https://mentors.debian.net/package/fwknop
Thanks, and sorry for the delay in reviewing.
> Note: Right now I do not have access to the git repository but I will
> investigate if I can do something for that.
Ok.
Some notes:
- d/copyright:
This needs an update, according to the diff the new copyright
statement (for "Files: *") is now:
- Copyright 2009-2013, Damien Stuart and Michael Rash
+Copyright (C) 2009-2015 fwknop developers and contributors. For a full
+list of contributors, see the file 'CREDITS'.
- d/rules:
Another way to set bindnow is:
export DEB_BUILD_MAINT_OPTIONS = hardening=+bindnow
Cf. man 1 dpkg-buildflags
- debug packages:
You can drop the -dbg packages, we have automatic -dbgsym packages
now. Cf. e.g. man 1 dh_strip.
(And since the packages are renamed, I think we don't need the
migration handling here.)
- there's a warning about sysmbols during build:
dpkg-gensymbols: warning: some libraries disappeared in the symbols file: libfko.so.2
dpkg-gensymbols: warning: debian/libfko3/DEBIAN/symbols doesn't match completely debian/libfko3.symbols
[..]
not sure if this is a problem or not ...
hm, why "libfko.so.2"
- As for the renaming of the libraries, I'm not sure if we need to do
a bit more. I guess there are no reverse dependencies outside this
source package? But even then, we should help users to get rid of
the libfko2* packages, probably with Breaks: libfko2*
(I see that libfko3-dev has a "Conflicts: libfko-dev".)
Cf. https://wiki.debian.org/RenamingPackages (although I guess we
need only the Breaks. -- Oh, no, we also need Replaces, as e.g.
libfko3-dev installs ./usr/include/fko.h and
./usr/lib/x86_64-linux-gnu/libfko.a
And for the dbg/dbgsym-package we probably do also need
dh_strip --dbgsym-migration ...
And lots of time later I have something which seems to work; cf.
attached diff.