On Wed, 24 Aug 2016 13:12:11 +0200, Franck Joncourt wrote: > The package has been accepted on the mentor queue and is available here: > https://mentors.debian.net/package/fwknop Thanks, and sorry for the delay in reviewing. > Note: Right now I do not have access to the git repository but I will > investigate if I can do something for that. Ok. Some notes: - d/copyright: This needs an update, according to the diff the new copyright statement (for "Files: *") is now: - Copyright 2009-2013, Damien Stuart and Michael Rash +Copyright (C) 2009-2015 fwknop developers and contributors. For a full +list of contributors, see the file 'CREDITS'. - d/rules: Another way to set bindnow is: export DEB_BUILD_MAINT_OPTIONS = hardening=+bindnow Cf. man 1 dpkg-buildflags - debug packages: You can drop the -dbg packages, we have automatic -dbgsym packages now. Cf. e.g. man 1 dh_strip. (And since the packages are renamed, I think we don't need the migration handling here.) - there's a warning about sysmbols during build: dpkg-gensymbols: warning: some libraries disappeared in the symbols file: libfko.so.2 dpkg-gensymbols: warning: debian/libfko3/DEBIAN/symbols doesn't match completely debian/libfko3.symbols [..] not sure if this is a problem or not ... hm, why "libfko.so.2"? - As for the renaming of the libraries, I'm not sure if we need to do a bit more. I guess there are no reverse dependencies outside this source package? But even then, we should help users to get rid of the libfko2* packages, probably with Breaks: libfko2* (I see that libfko3-dev has a "Conflicts: libfko-dev".) Cf. https://wiki.debian.org/RenamingPackages (although I guess we need only the Breaks. -- Oh, no, we also need Replaces, as e.g. libfko3-dev installs ./usr/include/fko.h and ./usr/lib/x86_64-linux-gnu/libfko.a And for the dbg/dbgsym-package we probably do also need dh_strip --dbgsym-migration ... And lots of time later I have something which seems to work; cf. attached diff. Cheers, gregor -- .''`. Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - https://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Babyface Leroy: Rollin' & Tumblin'
diff -Nru fwknop-2.6.9/debian/control fwknop-2.6.9/debian/control
--- fwknop-2.6.9/debian/control 2016-08-10 16:37:21.000000000 +0200
+++ fwknop-2.6.9/debian/control 2016-08-27 14:22:43.000000000 +0200
@@ -15,8 +15,8 @@
Package: libfko3-dev
Architecture: linux-any
Section: libdevel
-Provides: libfko-dev
-Conflicts: libfko-dev
+Breaks: libfko2-dev
+Replaces: libfko2-dev
Suggests: libfko-doc
Depends: ${shlibs:Depends}, libfko3 (= ${binary:Version}), ${misc:Depends}
Description: FireWall KNock OPerator - development library
@@ -34,29 +34,11 @@
.
This package provides the development library and its headers.
-Package: libfko3-dbg
-Architecture: linux-any
-Section: debug
-Depends: libfko3 (= ${binary:Version}), ${misc:Depends}
-Description: FireWall KNock OPerator - debugging symbols
- The FireWall KNock OPerator implements an authorization scheme called
- Single Packet Authorization (SPA), based on Netfilter and libpcap.
- .
- Its main application is to protect services such as OpenSSH with
- an additional layer of security in order to make the exploitation of
- vulnerabilities (both 0-day and unpatched code) much more difficult.
- .
- The authorization server passively listens for authorization packets via
- libcap, so there is no service listening for network connections on the
- traditional port. Access to a protected service is only granted after a
- valid encrypted and non-replayed packet is detected.
- .
- This package provides the debugging symbols for the library as well as for
- the fwknop server and client programs (C version only).
-
Package: libfko3
Section: libs
Architecture: linux-any
+Breaks: libfko2
+Replaces: libfko2
Pre-Depends: ${misc:Pre-Depends}
Depends: ${shlibs:Depends}, ${misc:Depends}
Description: FireWall KNock OPerator - shared library
diff -Nru fwknop-2.6.9/debian/rules fwknop-2.6.9/debian/rules
--- fwknop-2.6.9/debian/rules 2016-08-10 16:37:21.000000000 +0200
+++ fwknop-2.6.9/debian/rules 2016-08-27 14:22:43.000000000 +0200
@@ -65,4 +65,5 @@
chmod 600 $(CURDIR)/debian/fwknop-server/etc/fwknop/fwknopd.conf
override_dh_strip:
- dh_strip --dbg-package=libfko3-dbg
+ dh_strip -plibfko3 --dbgsym-migration='libfko2-dbg'
+ dh_strip --remaining-packages
Attachment:
signature.asc
Description: Digital Signature