[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#674218: marked as done (makedev: please drop obsolete preinst script)

Your message dated Thu, 09 May 2013 11:18:40 +0000
with message-id <E1UaOrw-0005lb-Vy@franck.debian.org>
and subject line Bug#674218: fixed in makedev 2.3.1-93
has caused the Debian Bug report #674218,
regarding makedev: please drop obsolete preinst script
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
674218: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=674218
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: makedev
Version: 2.3.1-91.1
Severity: wishlist
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu quantal ubuntu-patch

Hi Bdale,

A bug was recently reported in Ubuntu about a debootstrap failure, that
ultimately turned out to be related to the recent change to makedev's
preinst now being set -e.

  https://bugs.launchpad.net/ubuntu/quantal/+source/makedev/+bug/1001460

To make a long story short, makedev's preinst was running commands which,
while they are meant to be totally safe, are unnecessary on any recent
Debian or Ubuntu system and turned out not to be safe in Ubuntu for the
specific case of debootstrapping.

Since nothing in this preinst is needed on on upgrades from any recent
release (one of the upgrade fix-ups only applies to upgrades from lenny -
oldstable - and the other only applies to upgrades from something pre-etch),
I would suggest dropping the preinst entirely as in the attached patch. 
It's unlikely that the specific bug that hit Ubuntu here will ever affect
Debian, but IMHO the fewer preinsts we have in the base system, the better.

Thanks for considering,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org

=== modified file 'debian/changelog'

=== removed file 'debian/preinst'
--- debian/preinst	2012-03-21 10:50:08 +0000
+++ debian/preinst	1970-01-01 00:00:00 +0000
@@ -1,34 +0,0 @@
-#!/bin/sh -e
-
-# Remove a no-longer used conffile
-rm_conffile() {
-    PKGNAME="$1"
-    CONFFILE="$2"
-    if [ -e "$CONFFILE" ]; then
-        md5sum="`md5sum \"$CONFFILE\" | sed -e \"s/ .*//\"`"
-        old_md5sum="`dpkg-query -W -f='${Conffiles}' $PKGNAME | sed -n -e \"\\\\' $CONFFILE'{s/ obsolete$//;s/.* //p}\"`"
-        if [ "$md5sum" != "$old_md5sum" ]; then
-            echo "Obsolete conffile $CONFFILE has been modified by you."
-            echo "Saving as $CONFFILE.dpkg-old ..."
-            mv -f "$CONFFILE" "$CONFFILE".dpkg-old
-        else
-            echo "Removing obsolete conffile $CONFFILE ..."
-            rm -f "$CONFFILE"
-        fi
-    fi
-}
-
-case "$1" in
-install|upgrade)
-    if dpkg --compare-versions "$2" le "2.3.1-87"; then
-	rm_conffile makedev /etc/init.d/makedev
-	update-rc.d makedev remove
-    fi
-esac
-
-rm -f /usr/man/man8/MAKEDEV.8 /usr/man/man8/MAKEDEV-C.8 \
-	/usr/man/man8/MAKEDEV-C.8.gz
-
-#DEBHELPER#
-
-exit 0

--- End Message ---
--- Begin Message --- 
Source: makedev
Source-Version: 2.3.1-93

We believe that the bug you reported is fixed in the latest version of
makedev, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 674218@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Colin Watson <cjwatson@debian.org> (supplier of updated makedev package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 09 May 2013 12:00:49 +0100
Source: makedev
Binary: makedev
Architecture: source all
Version: 2.3.1-93
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Colin Watson <cjwatson@debian.org>
Description: 
 makedev    - creates device files in /dev
Closes: 674218
Changes: 
 makedev (2.3.1-93) unstable; urgency=low
 .
   * QA upload.
   * Mark makedev as Multi-Arch: foreign to allow for mountall to be
     installable with multi-arch (needed for armhf containers on x86; thanks,
     Stéphane Graber).
   * Remove preinst script, which had a buggy version comparison and in any
     case only applied to upgrades from lenny (thanks, Steve Langasek;
     closes: #674218).
Checksums-Sha1: 
 9caa58717549db8cda0145b83a5a095fd90b77e4 1778 makedev_2.3.1-93.dsc
 c9c155f29cd8658bb95b9ccb14fb63523c950784 49994 makedev_2.3.1-93.diff.gz
 8c579e5006c4709c027dfbd09c11dd399cbeff7f 42582 makedev_2.3.1-93_all.deb
Checksums-Sha256: 
 6197c68a58011f0fed922d15cc31c2c73f27dfe0a87ce399540f2d477b1d7eb2 1778 makedev_2.3.1-93.dsc
 7cdb747b03c9543e052d3cf6f2e7377c2196dca5d11c393b100bb09ace416220 49994 makedev_2.3.1-93.diff.gz
 43e93d32318cece9adf01067d9e700dc4600d3627aa15c7e1b238f6b9e2cd276 42582 makedev_2.3.1-93_all.deb
Files: 
 31ffd88f662f1e61a773869fdc90cd37 1778 admin extra makedev_2.3.1-93.dsc
 b7e088bf8b5f66c6e459dbabef299224 49994 admin extra makedev_2.3.1-93.diff.gz
 e438bdc64c4d1a81e13213f03368b4ef 42582 admin extra makedev_2.3.1-93_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Colin Watson <cjwatson@debian.org> -- Debian developer

iQIVAwUBUYuCczk1h9l9hlALAQi01A/+MwEUARwdHJhvoyvF8HX0TBgyhUQvF/mq
XRuETD2HwH3Lkdg4V2JZM/IsstaFPwmCFPoR+ffdEB88VdKwkAxPV4LeNZbxge/1
PkeYErFzFt+3Wi2JFwiCdKOsh+Jy9uukNPAUsQ7U+HWzdmLXEGu63nySOXtuHRft
ztrXPZAeEMhWGE64ImVEiYOlwsn24ZQFSjvblc8RHtgOQxK9fayyIw3ggkWNs+rB
hts2gYxrLSWH0KklgHBL5VDG462/nJu0ywtlu1xij2IfQcgKLJWO/XVWsOoJ37K8
qHBE4o8IPBlatjkAIfHZm3/2a+CNFky0VT4DDaSSp01MbJf4x/aIYwi+E0Ve12Mm
QNEdaKjk9UIPa44Vpbk8BTL8U8nrFUO7USNzlofHMXkaNCvnll8M4+mMbwt7dvMY
DJCDxKZWVMjSvwAA8A83Fwory5FvgOeIGq4HXozmaPAIChRVnud6WVFtDuLQ4Twh
9Pw80YC6yRa6MwHgK5UtJOuDKr7W+jIqmYBTIFCaGiO0sGOrPOd7YI+CVEmdczfx
bkZfhb2yuoMd4jJDOL2Ri82LN6/6O31nvO1l/7fJ66YRr91AkMx/Ds3YUrG53KfD
vvQOY3RtDMfo4uzhieQUoxgCoVjePE1CuzIbLTU3k7HwFxds+FeiM5jXAtEwfrX/
NNN8K99AZ4Q=
=QNvC
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: