[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#564515: marked as done (lastfmsubmitd: install fails if user entered a non existent spool group)



Your message dated Thu, 09 May 2013 11:17:59 +0000
with message-id <E1UaOrH-0005dp-Av@franck.debian.org>
and subject line Bug#564515: fixed in lastfmsubmitd 1.0.6-5
has caused the Debian Bug report #564515,
regarding lastfmsubmitd: install fails if user entered a non existent spool group
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
564515: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=564515
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: lastfmsubmitd
Version: 1.0.5-1.1
Severity: normal
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu lucid ubuntu-patch

:: DESCRIPTION ::
If the user enters a non-existent group at the lastfmsubmitd/spool_group prompt, the installation fails with
chown: invalid group: `lastfm:firstfm'
dpkg: error processing lastfmsubmitd (--configure):
 subprocess post-installation script returned error exit status 1

:: VERSION ::
lastfmsubmitd | 0.36-1 | hardy/universe | source, all
lastfmsubmitd | 0.37-2 | intrepid/universe | source, all
lastfmsubmitd | 0.37-3 | jaunty/universe | source, all
lastfmsubmitd | 1.0.5-1 | karmic/universe | source, all
lastfmsubmitd | 1.0.5-1 | lucid/universe | source, all

:: HOW TO REPRODUCE ::
When prompt with the question: "Group that may send submissions:" enter a group name that doesn't exist on your system and different from the default value "lastfm"

:: WORKAROUND ::
Keep the default.

:: FAULTY CODE ::
in debian/lastfmsubmitd.postinst:

db_get lastfmsubmitd/spool_group
if [ "$RET" ]; then
    for dir in /var/log/lastfm /var/run/lastfm /var/spool/lastfm; do
        chown "lastfm:$RET" $dir
        chmod 2775 $dir
    done
fi


*** /tmp/tmpxsubrf
In Ubuntu, we've applied the attached patch to achieve the following:

  * lastfmsubmitd.postinst: Create spool group if it doesn't exist. (LP: #386240)


The other solution would have been to skip the chown loop if when the group doesn't exists. 

We thought you might be interested in doing the same. 


-- System Information:
Debian Release: squeeze/sid
  APT prefers lucid-updates
  APT policy: (500, 'lucid-updates'), (500, 'lucid-security'), (500, 'lucid-proposed'), (500, 'lucid-backports'), (500, 'lucid')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-9-generic (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -u lastfmsubmitd-1.0.5/debian/changelog lastfmsubmitd-1.0.5/debian/changelog
diff -u lastfmsubmitd-1.0.5/debian/lastfmsubmitd.postinst lastfmsubmitd-1.0.5/debian/lastfmsubmitd.postinst
--- lastfmsubmitd-1.0.5/debian/lastfmsubmitd.postinst
+++ lastfmsubmitd-1.0.5/debian/lastfmsubmitd.postinst
@@ -45,6 +45,9 @@
 
 db_get lastfmsubmitd/spool_group
 if [ "$RET" ]; then
+    if ! getent group "$RET" >/dev/null; then
+        addgroup --force-badname "$RET" 
+    fi
     for dir in /var/log/lastfm /var/run/lastfm /var/spool/lastfm; do
         chown "lastfm:$RET" $dir
         chmod 2775 $dir
diff -u lastfmsubmitd-1.0.5/debian/control lastfmsubmitd-1.0.5/debian/control
--- lastfmsubmitd-1.0.5/debian/control
+++ lastfmsubmitd-1.0.5/debian/control
@@ -1,7 +1,8 @@
 Source: lastfmsubmitd
 Section: sound
 Priority: optional
-Maintainer: Decklin Foster <decklin@red-bean.com>
+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
+XSBC-Original-Maintainer: Decklin Foster <decklin@red-bean.com>
 Build-Depends: debhelper (>= 6), python-dev, po-debconf
 Build-Depends-Indep: python-support (>= 0.6)
 Standards-Version: 3.8.0

--- End Message ---
--- Begin Message ---
Source: lastfmsubmitd
Source-Version: 1.0.6-5

We believe that the bug you reported is fixed in the latest version of
lastfmsubmitd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 564515@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Colin Watson <cjwatson@debian.org> (supplier of updated lastfmsubmitd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 09 May 2013 11:51:16 +0100
Source: lastfmsubmitd
Binary: lastfmsubmitd lastmp
Architecture: source all
Version: 1.0.6-5
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Colin Watson <cjwatson@debian.org>
Description: 
 lastfmsubmitd - submission daemon for the Last.fm social music network
 lastmp     - MPD client for lastfmsubmitd
Closes: 564515
Changes: 
 lastfmsubmitd (1.0.6-5) unstable; urgency=low
 .
   * QA upload.
   * lastfmsubmitd.postinst: Create spool group if it doesn't exist (thanks,
     Jean-Baptiste Lallement; closes: #564515).
   * Add build-arch and build-indep targets to debian/rules.
Checksums-Sha1: 
 99c8d2821371a3a6c30593f7e673088c597dde60 1846 lastfmsubmitd_1.0.6-5.dsc
 401c392c4c4854f8e7270faab87f13bc17206a7e 17204 lastfmsubmitd_1.0.6-5.diff.gz
 297df19aba8b3552a490d8c350a35725dfdcb775 31718 lastfmsubmitd_1.0.6-5_all.deb
 904c904090abe931bf9f39a71a78aaa07ef2ca73 18340 lastmp_1.0.6-5_all.deb
Checksums-Sha256: 
 b0d23f060f0b388bce7d4279eededd092384c691b019709745b44fa78000022e 1846 lastfmsubmitd_1.0.6-5.dsc
 446c3ab18de7c641046e22eccb18d6c20227fe4112657aa0882ce0df33e75fd2 17204 lastfmsubmitd_1.0.6-5.diff.gz
 501380d776624040fd3ac13be2ed4aacc47660d0bc3f15973229dec4d99146f2 31718 lastfmsubmitd_1.0.6-5_all.deb
 e17dad43cabaa1922dfba5a463bdac0c46ce463bbbfea678c87433c5a0f9031e 18340 lastmp_1.0.6-5_all.deb
Files: 
 958f9a2955ede22449842045b6eb0164 1846 sound optional lastfmsubmitd_1.0.6-5.dsc
 94b847d441949d319f5afc5ecb759805 17204 sound optional lastfmsubmitd_1.0.6-5.diff.gz
 42d20dafefaf5af2c9dd5cb4a373c9d1 31718 sound optional lastfmsubmitd_1.0.6-5_all.deb
 4ea49cfd0b841f02fe778d6128b17822 18340 sound optional lastmp_1.0.6-5_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Colin Watson <cjwatson@debian.org> -- Debian developer

iQIVAwUBUYuAXjk1h9l9hlALAQj3ARAAtsGQ1fWGm0AswwQ7ZGso+tk0mSejW/mG
PW5V7pnEDbMBDrHQHkXtHHxwJH8eiaPjlpWoSB6pY4KzheP3f5r5b/YtsFvSBCmQ
jQBCz4sWQgCRXRzRrNBvZ4s7s20A5Z9WlabzWQ71tvm7gJlqSlZOgGAj4sIJ5fWt
TPTXIj9fya5YzM572aT77QXcdtYtloUArs8NK9yXSQX72XWyIxEgcBgulKJOGEfS
DMpo3M8r47Lod5+SVgtSssT1mH9h6IX7qgr3L4TYXruNS7O2QgEVVIm+wz4qRJZN
tafyvci1sQhLElVVANtaf9hBt4kbdHCR17EsWNqNozNDWsgIrfDQmiGucE5zmGwY
EKu3axpOUGtdwXY5GmKl+yjz7nhHm5K/0UI9SLM+0/iMWzvQTan+KMUD4ft3kBNP
uqQju/nbSS6L31/BriarOSyTlDZtlyrDv7TSbVDAVaLikv8K11x0+A0OSy7qoWE0
t6ykv0Up/KWjDwOipWO7VUqkqvoq8RJFEzFZkqAojdO8l+6oA1lftsn1bkzgfotv
9PexpGhhSwZhEPumIxnkW4YKhexX5opg9wr4osHZI/y42m1luHVcLUZJ9Gss15IA
TpEQQ1e/nqh1By4KBTgLWsH8yARU6lwnDhdLjbbkJ/gwKgNeWg+bvwLAWI33PFV9
Iw+k8DnGgys=
=Ih6q
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: