[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#700694: bzr-git: Several issues with DEP-8 tests



Source: bzr-git
Version: 0.6.9-2
Severity: normal
Tags: patch

bzr-git has several problems with DEP-8 tests, which currently makes them fail.

The attached debdiff does the following changes (quoted from the changelog):

- Use $ADTTMP instead of $TMPDIR.
- Drop now default "Features: no-build-needed".
- Add missing dependencies on bzr-git and python-subunit.
- Redirect stderr of git clone to stdout.
- Make tests fail on upstream testsuite failure.

I've not tested it in a clean environment, but these fixes at least make the tests
succeed *for me*.

--
Dmitry Shachnev

-- System Information:
Debian Release: 7.0
  APT prefers unstable
  APT policy: (700, 'unstable'), (500, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-4-686-pae (SMP w/4 CPU cores)
Locale: LANG=ru_RU.utf8, LC_CTYPE=ru_RU.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

-- no debconf information
diff -Nru bzr-git-0.6.9/debian/changelog bzr-git-0.6.9/debian/changelog
--- bzr-git-0.6.9/debian/changelog	2012-12-13 22:21:22.000000000 +0400
+++ bzr-git-0.6.9/debian/changelog	2013-02-16 13:56:37.000000000 +0400
@@ -1,3 +1,14 @@
+bzr-git (0.6.9-3) UNRELEASED; urgency=low
+
+  * Several fixes for DEP-8 tests:
+    - Use $ADTTMP instead of $TMPDIR.
+    - Drop now default "Features: no-build-needed".
+    - Add missing dependencies on bzr-git and python-subunit.
+    - Redirect stderr of git clone to stdout.
+    - Make tests fail on upstream testsuite failure.
+
+ -- Dmitry Shachnev <mitya57@gmail.com>  Sat, 16 Feb 2013 13:52:37 +0400
+
 bzr-git (0.6.9-2) experimental; urgency=low
 
   * Orphan package.
diff -Nru bzr-git-0.6.9/debian/tests/control bzr-git-0.6.9/debian/tests/control
--- bzr-git-0.6.9/debian/tests/control	2012-12-13 22:19:31.000000000 +0400
+++ bzr-git-0.6.9/debian/tests/control	2013-02-16 13:40:46.000000000 +0400
@@ -1,6 +1,5 @@
 Tests: testsuite
-Depends: bzr, python-bzrlib.tests, git
-Features: no-build-needed
+Depends: git, bzr-git, python-bzrlib.tests, python-subunit
 
 Tests: git-remote
-Depends: git, bzr
+Depends: git, bzr-git
diff -Nru bzr-git-0.6.9/debian/tests/git-remote bzr-git-0.6.9/debian/tests/git-remote
--- bzr-git-0.6.9/debian/tests/git-remote	2012-12-13 22:19:31.000000000 +0400
+++ bzr-git-0.6.9/debian/tests/git-remote	2013-02-16 13:55:56.000000000 +0400
@@ -1,7 +1,7 @@
 #!/bin/sh -e
 
-cd "$TMPDIR"
+cd "$ADTTMP"
 bzr init foo.bzr
 bzr ci --quiet --unchanged -m "Some commit" foo.bzr
-git clone "bzr::foo.bzr" foo.git
+git clone "bzr::foo.bzr" foo.git 2>&1
 cd foo.git && git log | grep "Some commit"
diff -Nru bzr-git-0.6.9/debian/tests/testsuite bzr-git-0.6.9/debian/tests/testsuite
--- bzr-git-0.6.9/debian/tests/testsuite	2012-12-13 22:19:31.000000000 +0400
+++ bzr-git-0.6.9/debian/tests/testsuite	2013-02-16 13:56:16.000000000 +0400
@@ -1,4 +1,5 @@
 #!/bin/sh
 # Note that since the installed version of the package has to be tested,
 # there is no mucking about with BZR_PLUGINS_AT.
+set -e
 bzr selftest -s bp.git -v --parallel=fork

Reply to: