[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#638336: marked as done (gecko-mediaplayer: build-arch does not build architecture-dependent part)

Your message dated Thu, 12 Jan 2012 20:49:16 +0000
with message-id <E1RlRaG-0005f4-HL@franck.debian.org>
and subject line Bug#638336: fixed in gecko-mediaplayer 1.0.5-1
has caused the Debian Bug report #638336,
regarding gecko-mediaplayer: build-arch does not build architecture-dependent part
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
638336: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=638336
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: gecko-mediaplayer
Version: 1.0.4-1
Severity: important
Justification: policy §4.9
Tags: patch

Hi,

As policy §4.9 says,

	The build-arch target, if provided, should perform all the
	configuration and compilation required for producing all
	architecture-dependant binary packages

In particular, in this package it should not be empty.  How about this
patch?
---
 debian/changelog |    8 ++++++++
 debian/rules     |   13 ++++++-------
 2 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 959000c7..51139d12 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,15 @@
+gecko-mediaplayer (1.0.4-2.1) local; urgency=low
+
+  * debian/rules:
+    - Mark build-arch and build-indep targets phony.
+    - Make build-arch target actually build the architecture-dependent part
+      of the package so the build does not run with (fake) root privileges
+      when autobuilders start to use it.
+    - binary-arch and binary-indep depend on build-arch and build-indep,
+      respectively, to save arch-all builds some time.
+
+ -- Jonathan Nieder <jrnieder@gmail.com>  Thu, 18 Aug 2011 12:51:21 -0500
+
 gecko-mediaplayer (1.0.4-2) unstable; urgency=high
 
   * QA upload.
diff --git a/debian/rules b/debian/rules
index b74e0b4b..9514f966 100755
--- a/debian/rules
+++ b/debian/rules
@@ -36,8 +36,7 @@ configure-stamp:
 
 	touch configure-stamp
 
-build: build-stamp
-
+build-arch: build-stamp
 build-stamp: configure-stamp
 	dh_testdir
 
@@ -67,11 +66,9 @@ install: build
 	rm -rf $(CURDIR)/debian/gecko-mediaplayer/usr/share/doc/gecko-mediaplayer
 
 build-indep:
-build-arch:
-
-binary-indep: build install
+binary-indep: build-indep
 
-binary-arch: build install
+binary-arch: build-arch install
 	dh_testdir
 	dh_testroot
 	dh_installchangelogs ChangeLog
@@ -87,5 +84,7 @@ binary-arch: build install
 	dh_md5sums
 	dh_builddeb
 
+build: build-indep build-arch
 binary: binary-indep binary-arch
-.PHONY: build clean binary-indep binary-arch binary install configure
+.PHONY: build-indep build-arch build binary-indep binary-arch binary
+.PHONY: clean install configure
-- 
1.7.6

--- End Message ---
--- Begin Message --- 
Source: gecko-mediaplayer
Source-Version: 1.0.5-1

We believe that the bug you reported is fixed in the latest version of
gecko-mediaplayer, which is due to be installed in the Debian FTP archive:

gecko-mediaplayer_1.0.5-1.debian.tar.gz
  to main/g/gecko-mediaplayer/gecko-mediaplayer_1.0.5-1.debian.tar.gz
gecko-mediaplayer_1.0.5-1.dsc
  to main/g/gecko-mediaplayer/gecko-mediaplayer_1.0.5-1.dsc
gecko-mediaplayer_1.0.5-1_amd64.deb
  to main/g/gecko-mediaplayer/gecko-mediaplayer_1.0.5-1_amd64.deb
gecko-mediaplayer_1.0.5.orig.tar.gz
  to main/g/gecko-mediaplayer/gecko-mediaplayer_1.0.5.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 638336@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sebastian Ramacher <s.ramacher@gmx.at> (supplier of updated gecko-mediaplayer package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 05 Jan 2012 00:53:13 +0100
Source: gecko-mediaplayer
Binary: gecko-mediaplayer
Architecture: source amd64
Version: 1.0.5-1
Distribution: unstable
Urgency: low
Maintainer: Debian Multimedia Maintainers <pkg-multimedia-maintainers@lists.alioth.debian.org>
Changed-By: Sebastian Ramacher <s.ramacher@gmx.at>
Description: 
 gecko-mediaplayer - Multimedia plug-in for Gecko browsers
Closes: 567169 628997 638336 652152
Changes: 
 gecko-mediaplayer (1.0.5-1) unstable; urgency=low
 .
   [ Sebastian Ramacher ]
   * New upstream release (Closes: #652152).
   * debian/control:
     - add myself to Uploaders.
     - don't depend on specific browsers (Closes: #567169)
     - Build-Dep on dh-autoreconf instead of autotools-dev.
     - Build-Dep on pkg-config (>= 2.26).
     - Remove unnecessary Build-Dep on libidl0.
   * debian/rules:
     - regenerate configure with dh-autoreconf.
   * debian/patches:
     - add 0002-fix-spelling-error.patch to fix spelling mistake in
       src/plugin.cpp.
     - update 0001-nomozalloc.patch to not include diff for configure.
 .
   [ Julien Lavergne ]
   * debian/patches:
     - force-no-gsettings.patch: Remove, since gnome-mplayer provide the
       gsettings schemas.
 .
   [ Brandon Snider ]
   * debian/rules: convert package to dh short form (Closes: #638336).
   * debian/compat: bump compat to 8.
   * debian/control:
     - Build-Dep on debhelper (>= 8)
     - Build-Dep on libgmlib-dev
   * debian/copyright: make it DEP-5 compliant
 .
   [ Aron Xu ]
   * debian/control:
     - Move to Debian Multimedia Team, add Julien and myself to Uploaders.
       (Closes: #628997)
     - Add Vcs-* fields.
Checksums-Sha1: 
 a5f36871ab99a4efe165b2d219fed289e197136b 2016 gecko-mediaplayer_1.0.5-1.dsc
 2a8b87805972d7988eb840840dc12343a6edcc5b 262377 gecko-mediaplayer_1.0.5.orig.tar.gz
 a07dc1c686d1921e6bdc658095217b61eb362dbe 15669 gecko-mediaplayer_1.0.5-1.debian.tar.gz
 7c79ade62da77730b88d7e18df53fdda0c342201 233228 gecko-mediaplayer_1.0.5-1_amd64.deb
Checksums-Sha256: 
 4b08faf05acae4365237e34c331b9db4f7c5f5981ef396ca00d03d18abd8a597 2016 gecko-mediaplayer_1.0.5-1.dsc
 913fd39e70c564cb210c2544a88869f9d1a448184421f000b14b2bc5ba718b49 262377 gecko-mediaplayer_1.0.5.orig.tar.gz
 87521059a49790a9d65b10a55ca4c51adf42665b6fb6cfd73a26d993362b8515 15669 gecko-mediaplayer_1.0.5-1.debian.tar.gz
 ce5087ada6f644791b50949cb91d5bfa943d7168f7c004dfa2de449215257982 233228 gecko-mediaplayer_1.0.5-1_amd64.deb
Files: 
 3c335ffc6e86dd8a816c0ca23ad53bfc 2016 video optional gecko-mediaplayer_1.0.5-1.dsc
 1a96daf878d06452c0fd9a13fd186021 262377 video optional gecko-mediaplayer_1.0.5.orig.tar.gz
 e3306624c45f626a70e8260da59a4e7b 15669 video optional gecko-mediaplayer_1.0.5-1.debian.tar.gz
 e7352468e29a3ca19ae9082fc23386d8 233228 video optional gecko-mediaplayer_1.0.5-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQEcBAEBCgAGBQJPDznCAAoJEEmrPP2rYrC4vHUH/3W413ri4kND+z3BpbFXZF67
szNiZ7jy9FlXohCEzIfuPunTaS3TARrEKiXJpINdLr3D+AX2lDUeY45IYYm2ui68
uFZYl7HY1adb0mYNpdQQMffn+pVowiMemExTD96qBzJGJy9VOefjLN09JdNEZbpD
5+P79K/dhPsKdaP36bSZuwUdBxUml2QVG32PTO2arUIYYhcm11zJwU4ykka1X6pV
S1P4/vAzKtcQfltg/C1ZPQVqOqJNJC1H35lXJWl0pCK4ef9vVybErhRCENMVHk2e
W/IsiDWI3nt7IbnhoZzNDeIA8IukB10YnOb58ggsAZ58btJ7ccbW0zl9Bgkm8Hk=
=rOpU
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: