[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#470758: marked as done (Does not reset current recursion level on new MAIL FROM)

Your message dated Sun, 13 Nov 2011 22:37:27 +0000
with message-id <[🔎] E1RPig3-0003al-8N@franck.debian.org>
and subject line Bug#648510: Removed package(s) from unstable
has caused the Debian Bug report #470758,
regarding Does not reset current recursion level on new MAIL FROM
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
470758: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=470758
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: libspf0
Version: 0.999-1.0.0-p3-3

Please have a look at #464029 for an example of the problem this causes.

Attached is a patch which fixes this within libspf (by resetting the
level in SPF_smtp_from()). I've tested it (together with the patch for
#392927) and it fixes the issue for me.

I am not simply reassigning the bug to libspf, because the library
maintainer/author might not think that changing its code is the correct
thing to do (and decide that the variable should be explicitly reset by
the library client). I have not been able to find any API documentation
which would support either view.

Also, it would be really nice if you could upload a fix for this and
#392927 to etch-proposed-updates...

-- 
Marcin Owsiany <porridge@debian.org>             http://marcin.owsiany.pl/
GnuPG: 1024D/60F41216  FE67 DA2D 0ACA FC5E 3F75  D6F6 3A0D 8AA0 60F4 1216

--- libspf-0.999-1.0.0-p3.orig/src/libspf/main.c
+++ libspf-0.999-1.0.0-p3/src/libspf/main.c
@@ -1830,6 +1831,11 @@
   xvprintf("local-part: [%s]; domain: [%s]; sender: [%s]\n",
     p->local_part, p->current_domain, p->from);
 
+  /*
+   * We need to reset this, otherwise we'll hit the recursion limit after N rejected MAIL FROMs.
+   */
+  p->spf_rlevel = 0;
+
   return(SPF_TRUE);
 }

--- End Message ---
--- Begin Message --- 
Version: 0.999-1.0.0-p3.dfsg-3+rm

Dear submitter,

as the package libspf has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see http://bugs.debian.org/648510

The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
ftpmaster@debian.org.

Debian distribution maintenance software
pp.
Luca Falavigna (the ftpmaster behind the curtain)

--- End Message ---
Reply to: