[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#499743: marked as done (gmrun: please add support for "Selected" option in configuration)

Your message dated Mon, 09 Nov 2009 10:32:23 +0000
with message-id <E1N7RXr-0000jx-5w@ries.debian.org>
and subject line Bug#499743: fixed in gmrun 0.9.1-4
has caused the Debian Bug report #499743,
regarding gmrun: please add support for "Selected" option in configuration
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org

499743: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=499743
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: gmrun
Version: 0.9.1-2.4
Severity: wishlist
Tags: patch

Attached is a dpatch to add support for a Selected option in the
configuration file.  Setting it to 1 makes the text selected (any
keypress replaces it), while 0 puts the cursor after the last letter, so
any keypress adds text to the command to be launched.

I also updated the documentation (60-manpage.dpatch), for this, for an
undocumented ShowLast option, and for the patch that fixes #460135.

Dropping the file in debian/patches, updating 00list, and debuilding
works fine here.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.26
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages gmrun depends on:
ii  libatk1.0-0                   1.22.0-1   The ATK accessibility toolkit
ii  libc6                         2.7-13     GNU C Library: Shared libraries
ii  libcairo2                     1.6.4-6    The Cairo 2D vector graphics libra
ii  libgcc1                       1:4.3.2-1  GCC support library
ii  libglib2.0-0                  2.16.5-1   The GLib library of C routines
ii  libgtk2.0-0                   2.12.11-3  The GTK+ graphical user interface 
ii  libpango1.0-0                 1.20.5-2   Layout and rendering of internatio
ii  libstdc++6                    4.3.2-1    The GNU Standard C++ Library v3

gmrun recommends no packages.

gmrun suggests no packages.

-- no debconf information
#! /bin/sh /usr/share/dpatch/dpatch-run
## 50-selectoption.dpatch by Fernando Vezzosi <fv@linuxvar.it>
## DP: add "Selected" config option


--- gmrun-0.9.1/src/main.cc	2008-01-12 00:35:33.000000000 +0100
+++ gmrun-0.9.1/src/main.cc	2008-01-12 02:32:48.000000000 +0100
@@ -599,6 +599,10 @@
   if (!configuration.get_int("ShowLast", shows_last_history_item)) {
     shows_last_history_item = 0;
+  int last_history_selected = 0;
+  if (!configuration.get_int("Selected", last_history_selected)) {
+    last_history_selected = 1;
+  }
   if (shows_last_history_item) {
@@ -612,7 +612,11 @@
   gtk_widget_set_uposition(win, prefs_left, prefs_top);
-  gtk_window_set_focus(GTK_WINDOW(win), compline);
+  if(last_history_selected){
+    gtk_entry_select_region(GTK_ENTRY(compline), 0, strlen(gtk_entry_get_text(GTK_ENTRY(compline))));
+  }else{
+    gtk_entry_set_position(GTK_ENTRY(compline), -1);
+  }
#! /bin/sh /usr/share/dpatch/dpatch-run
## 60-manpage.dpatch by Fernando Vezzosi <fv@linuxvar.it>
## All lines beginning with `## DP:' are a description of the patch.
## DP: Add documentation for cmdline arg, ShowLast and Selected options

diff -urNad gmrun-0.9.1~/debian/gmrun.1 gmrun-0.9.1/debian/gmrun.1
--- gmrun-0.9.1~/debian/gmrun.1	2008-09-21 20:54:22.000000000 +0200
+++ gmrun-0.9.1/debian/gmrun.1	2008-09-21 21:01:32.000000000 +0200
@@ -18,7 +18,7 @@
 gmrun \- Featureful CLI-like GTK+ application launcher
-.B gmrun
+.B gmrun [\fITEXT\fR]
 This manual page documents briefly the
@@ -32,7 +32,9 @@
 .\" respectively.
 \fBgmrun\fP is a program that allows a user to use a CLI-like interface to launch applications from within the X11 windowing environment. It is based on the GTK+ toolkit.
-gmrun does not current accept any command-line parameters. However, gmrun can be customized using a configuration file, ~/.gmrunrc . The system-wide configuration file is /etc/gmrunrc .
+If gmrun is invoked with a command-line parameter, that will be the initial content of the dialog box.
+gmrun can be customized using a configuration file, ~/.gmrunrc . The system-wide configuration file is /etc/gmrunrc .
 The format of the configuration file is simple; "variable = value". To refer to a variable as opposed to setting it, enclose the variable in ${}.
@@ -57,6 +59,12 @@
 .B History
 Number of entered commands which should be kept in gmrun's history(~/.gmrun_history). Using the Up and Down arrow keys within the gmrun window will cycle through the history. You can search backwards through the history with Ctrl+R, and foward with Ctrl+S. To cancel a search, hit Ctrl+G. Otherwise, after you have found the history item you wish to run, hit Enter.
+.B ShowLast
+Whether to show the last command as initial text, or an empty textarea (1 or 0)
+.B Selected
+Whether the initial text should be selected or not (1 or 0)
 As opposed to entering a command, gmrun supports the entering of URLs. The included configuration file(/etc/gmrunrc) gives some examples. To set up your own url, create a variable in /etc/gmrunrc or ~/.gmrunrc with the format of "URL_protocol". For instance, URL_http. Here is an example:

--- End Message ---
--- Begin Message ---
Source: gmrun
Source-Version: 0.9.1-4

We believe that the bug you reported is fixed in the latest version of
gmrun, which is due to be installed in the Debian FTP archive:

  to main/g/gmrun/gmrun_0.9.1-4.diff.gz
  to main/g/gmrun/gmrun_0.9.1-4.dsc
  to main/g/gmrun/gmrun_0.9.1-4_i386.deb

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 499743@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
David Paleino <dapal@debian.org> (supplier of updated gmrun package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.8
Date: Mon, 09 Nov 2009 11:10:40 +0100
Source: gmrun
Binary: gmrun
Architecture: source i386
Version: 0.9.1-4
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: David Paleino <dapal@debian.org>
 gmrun      - Featureful CLI-like GTK+ application launcher
Closes: 109962 460315 499743 554587
 gmrun (0.9.1-4) unstable; urgency=low
   * QA upload.
   * debian/patches/:
     - 60-fix_gtkcompletionline.dpatch added, thanks to Brian M. Carlson
       (Closes: #554587)
     - 70-cmdline.dpatch added, thanks to Fernando Vezzosi
       (Closes: #460315)
     - 80-selectoption.dpatch added, thanks to Fernando Vezzosi
       (Closes: #499743)
   * debian/gmrun.1 updated, thanks to Mauro Lizaur and Fernando
     Vezzosi (Closes: #109962)
 cf0d31131873ca4df914928cadb14a1415b5339f 1006 gmrun_0.9.1-4.dsc
 5c1750459c3ae38e23de9687b067d495ee77b362 9169 gmrun_0.9.1-4.diff.gz
 3858cfa9cec2d27519897f79c25e7f1e963680ca 44698 gmrun_0.9.1-4_i386.deb
 f42604e5a933056a7dd98e4e2b0931f7bf0d59b4e2bf84dfab272697a6c62340 1006 gmrun_0.9.1-4.dsc
 feb89e9b28a888f9bc4edfdff042079c6b62237eed7956f3d560e7f1fc2b8fb8 9169 gmrun_0.9.1-4.diff.gz
 14dd28a4ec5f661fd840247237f890b1753c0aa154b72b17ce08caccc604e49a 44698 gmrun_0.9.1-4_i386.deb
 ac005e515e9ecfeb421a80f961e7bcf3 1006 x11 optional gmrun_0.9.1-4.dsc
 143011c3b1fb253ef9c309c7d12a97b3 9169 x11 optional gmrun_0.9.1-4.diff.gz
 11c289f23a78a7062067993a1f4df8cd 44698 x11 optional gmrun_0.9.1-4_i386.deb

Version: GnuPG v1.4.10 (GNU/Linux)


--- End Message ---

Reply to: