[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#485169: marked as done (jack-tools: FTBFS when converted to new source format 3.0 (quilt): patch files contained in tarballs)

Your message dated Thu, 05 Nov 2009 17:47:08 +0000
with message-id <E1N66QO-0001lm-T5@ries.debian.org>
and subject line Bug#485169: fixed in jack-tools 0.0.2-7
has caused the Debian Bug report #485169,
regarding jack-tools: FTBFS when converted to new source format 3.0 (quilt): patch files contained in tarballs
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org

485169: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=485169
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: jack-tools
Version: 0.0.2-5
Severity: wishlist
Usertags: 3.0-quilt-by-default

To prepare a possible switch to the new source package format "3.0
(quilt)" [1], I converted all source packages and tried to rebuild them.
Unfortunately, jack-tools failed, you can try yourself with those
commands (and dpkg-dev >= 1.14.19 [2]) :

$ apt-get source jack-tools
$ sed -i -e '/^Source:/ aFormat: 3.0 (quilt)' jack-tools-0.0.2/debian/control
$ dpkg-source -b jack-tools-0.0.2
$ dpkg-source -x jack-tools_0.0.2-5.dsc
$ cd jack-tools-0.0.2 && debuild -us -uc

In this process, if the .diff.gz contains changes to upstream files,
dpkg-source will have created a corresponding patch in
debian/patches/debian-changes-0.0.2-5 and will have registered that
patch in a quilt series (debian/patches/series, it is created if needed).
All the patches listed in the "series" file are applied directly during
the extraction (dpkg-source -x). quilt itself is used if available (and
will thus lead to the creation of the .pc directory), otherwise
dpkg-source applies the patches by itself. For more information about the
new source package format see the manual page dpkg-source(1).

In the case of jack-tools, the quilt series is only applicable
after extraction of a tarball/zipfile/jarfile. But dpkg-source
tries to apply the quilt series immediately after unpack 
and will thus fail.

In several cases the usage of tarball(s) in tarball is justified by the
fact that several upstream tarballs have to be combined. The new format
does support unpacking of multiple upstream tarballs and as such, you
probably want to defer fixing this bug until the new format is accepted
and directly make usage of this new feature.

If your package only contains a single tarball, you might want to
reconsider the choice of using a tarball inside a tarball and 
handle the build like do most other Debian packages.

In all cases, those are heavy changes for a simple wishlist bug and
I can understand that you don't fix this until after lenny's release.
I'm merely filing this bug to keep track of the packages that will cause
troubles when we switch to the new format.

As a side note, you must also pay attention to the following points in
your quilt usage to guarantee compatibility with the new source package
- all your patches must be applicable with the "-p1" option of patch
  (and you shouldn't use options in the series file to override this)
- the patches must be in debian/patches/ together with the "series" file
  (you can use QUILT_PATCHES=debian/patches if needed)
- you should not override QUILT_PC to change the location of quilt's
  internal directory (".pc" by default)
- the patches should not reference absolute filenames (in +++/--- lines)
- your clean target must work even if the patches are already applied
- your build target must work with patches applied even if the clean
  target is supposed to unapply them (because dpkg-source -b might
  have applied them back)


[1] http://lists.debian.org/debian-devel-announce/2008/04/msg00004.html
[2] the upcoming dpkg-dev 1.14.20 is more tolerant with patches, you can
grab it here if you want to try with that version:
Raphael Hertzog

--- End Message ---
--- Begin Message ---
Source: jack-tools
Source-Version: 0.0.2-7

We believe that the bug you reported is fixed in the latest version of
jack-tools, which is due to be installed in the Debian FTP archive:

  to main/j/jack-tools/jack-tools_0.0.2-7.debian.tar.gz
  to main/j/jack-tools/jack-tools_0.0.2-7.dsc
  to main/j/jack-tools/jack-tools_0.0.2-7_i386.deb
  to main/j/jack-tools/jack-tools_0.0.2.orig-sw04.tar.bz2
  to main/j/jack-tools/jack-tools_0.0.2.orig-sw05.tar.bz2
  to main/j/jack-tools/jack-tools_0.0.2.orig-sw23.tar.bz2
  to main/j/jack-tools/jack-tools_0.0.2.orig-sw26.tar.bz2
  to main/j/jack-tools/jack-tools_0.0.2.orig-sw27.tar.bz2
  to main/j/jack-tools/jack-tools_0.0.2.orig-sw29.tar.bz2
  to main/j/jack-tools/jack-tools_0.0.2.orig.tar.bz2

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 485169@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Raphaël Hertzog <hertzog@debian.org> (supplier of updated jack-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA256

Format: 1.8
Date: Thu, 05 Nov 2009 17:39:09 +0100
Source: jack-tools
Binary: jack-tools
Architecture: source i386
Version: 0.0.2-7
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Raphaël Hertzog <hertzog@debian.org>
 jack-tools - various JACK tools: plumbing, play, udp, ctl, scope, clock
Closes: 485169 527431
 jack-tools (0.0.2-7) unstable; urgency=low
   * QA upload.
   * Switch to "3.0 (quilt)" with multiple orig tarballs. Closes: #485169
   * Switch main tarball to bz2 compression to avoid useless change of upstream
     version (it's empty anyway now).
   * Update build-depends to use libjack-dev instead of libjack0.100.0-dev.
     Closes: #527431
 d0844c4aff9e12d8f92e3f6d43c90c92bcfe9064 3118 jack-tools_0.0.2-7.dsc
 7ef1ceefcb4eaf61223c7ef1f923f1699feb7d90 15006 jack-tools_0.0.2.orig-sw04.tar.bz2
 d93f564a0096ac5ac11b6dbf17d21b7fd993c8f7 37413 jack-tools_0.0.2.orig-sw05.tar.bz2
 291c576e0a536b01d6ae6ff544bc638937453a08 13085 jack-tools_0.0.2.orig-sw23.tar.bz2
 d494f8161cd4ef911a42ba0b1d3228774f4c73e6 2723 jack-tools_0.0.2.orig-sw26.tar.bz2
 7a4780e7d7df351a05570efd30a5940f9d3b2f99 99188 jack-tools_0.0.2.orig-sw27.tar.bz2
 4ac5e31b195a9c7d69ca16687f092b54fdd8b0fa 17907 jack-tools_0.0.2.orig-sw29.tar.bz2
 6321583e5ff163f817fd7e22ebbfa68f6066b734 137 jack-tools_0.0.2.orig.tar.bz2
 a40ac544b0151e973ce5f1863dcd1d37e36165dc 4554 jack-tools_0.0.2-7.debian.tar.gz
 f55ed25dc826765ecb9d04b0bace59401f62cc39 70910 jack-tools_0.0.2-7_i386.deb
 deda00b829986d4499bdffbc9ce0823561f0b4812880ea66ffa3188fb44f0333 3118 jack-tools_0.0.2-7.dsc
 7b0b1738e36e71f80ded29704242619c06462530e240f059bf10619c00159ce1 15006 jack-tools_0.0.2.orig-sw04.tar.bz2
 a9207fd7263fdccd728c8df6c3ff91342107a879bc03632e395acca0c1afa8a5 37413 jack-tools_0.0.2.orig-sw05.tar.bz2
 d4fbc13d3dce1ebbffd1f4ba5c2279b2921ff943c2d325f382b4fdf15bdb85df 13085 jack-tools_0.0.2.orig-sw23.tar.bz2
 5230328789049af6ed98c7c75d756a7e7a6faf81a98cb3d1db7a584184efff09 2723 jack-tools_0.0.2.orig-sw26.tar.bz2
 0ac38e8431fadf0fc65a406c3e11e4a1eea42ec262373bb3a574a72fe716e91f 99188 jack-tools_0.0.2.orig-sw27.tar.bz2
 389ec0b99863004247a1811239f8ab2cad31327de62bea93820b702a6100abe5 17907 jack-tools_0.0.2.orig-sw29.tar.bz2
 8f8aae25597f79d60619981c7716a6e3b7c8501d8ea8896c51f60351d083eb2a 137 jack-tools_0.0.2.orig.tar.bz2
 af564292e967b2a29e014788a0142fe391b0fb2612baf35754b225b6823b8532 4554 jack-tools_0.0.2-7.debian.tar.gz
 279f40a6b8abb4234c6f1f85d8a7e8bbbf1daae1fc05d7f33ae430b6c8084cd9 70910 jack-tools_0.0.2-7_i386.deb
 db8fee2dd6d87b742851aa3c77547e94 3118 sound optional jack-tools_0.0.2-7.dsc
 071dcdfae67bb97c287c86007e4fbaa2 15006 sound optional jack-tools_0.0.2.orig-sw04.tar.bz2
 81569c13f6c6894ecaaf88ef10234973 37413 sound optional jack-tools_0.0.2.orig-sw05.tar.bz2
 4fe36ff3ca98bcf297392ce62c88fbb0 13085 sound optional jack-tools_0.0.2.orig-sw23.tar.bz2
 6921c5d5189a39c3a3369743ae9f3b0c 2723 sound optional jack-tools_0.0.2.orig-sw26.tar.bz2
 721463a67a206199d81e21d821fa440d 99188 sound optional jack-tools_0.0.2.orig-sw27.tar.bz2
 a9d6c0a81ebc96936638b0242bc92a4b 17907 sound optional jack-tools_0.0.2.orig-sw29.tar.bz2
 c4121d0674b7f33e274f40456b2c3f93 137 sound optional jack-tools_0.0.2.orig.tar.bz2
 1a4ef2a3edfce2e3ff02333aeea72842 4554 sound optional jack-tools_0.0.2-7.debian.tar.gz
 944d4bb980139ead45a11e890a172611 70910 sound optional jack-tools_0.0.2-7_i386.deb

Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Signed by Raphael Hertzog


--- End Message ---

Reply to: