[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#551515: defoma: Do not register non-existant fonts from .hints

Package: defoma
Version: 0.11.10-0.2
Severity: normal

There always seems to be packages in Debian that list wrong or
otherwise non-existing paths or file names in the "begin" lines in
their .hints files.  For instance, lenny contains at least 11 such
broken .hints files.

Currently, defoma-font silently accepts these bogus entries and
creates bogus references (such as dangling symlinks) for such
non-existing font files.

I would strongly suggest that this behaviour be changed as

   1. If the begin line points to a non-existing file, do not try
   to register the font (but do continue to support
   unregister/purge for such dead entries!).
   2. If at all possible, report any such failures loudly, so font
   packagers will know their package is broken.

Something like this in defoma-font.pl sub hintfile_read() in the
'end' branch:

            } elsif ($Debian::Defoma::Id::Register and not -f $font) {
                printe("$hintfile($lnum): $font: ",
                       "Font file does not exist!");
                $font = '';
                @hints = ();

And then in each sub com_[re]register*()
   $Debian::Defoma::Id::Register = 1;

If necessary, add the Register variable in the appropriate module
with a default value of 0.

-- System Information:
Debian Release: 5.0.3
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.31jbj3.4-43 (SMP w/4 CPU cores)
Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages defoma depends on:
ii  file                  4.26-1             Determines file type using "magic"
ii  perl                  5.10.0-19lenny2    Larry Wall's Practical Extraction 
ii  whiptail              0.52.2-11.3+lenny1 Displays user-friendly dialog boxe

Versions of packages defoma recommends:
pn  libft-perl                    <none>     (no description available)

Versions of packages defoma suggests:
ii  defoma-doc                   0.11.10-0.2 Debian Font Manager documentation
pn  dfontmgr                     <none>      (no description available)
ii  psfontmgr                    0.11.10-0.2 PostScript font manager -- part of
ii  x-ttcidfont-conf             31          TrueType and CID fonts configurati

-- no debconf information

Reply to: