[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#123272: crash segfaults on wrong command line input

tags 123272 - patch

Aurélien GÉRÔME <ag@roxor.cx> writes:

> I did a patch for this crappy (non-)indented C source code.
> It will go in my upload in a few hours...

The patch is problematic in several ways:

 * nsub is an optional argument; its absence is not an error.
 * The if branch you are patching doesn't actually use nsub; only the
   first three arguments are passed to old_main().
 * From a cursory gdb session, the reason crashme segfaults is that it
   executes illegal instructions, not in the options parsing.



Reply to: