Bug#277044: marked as done ("--restrict-read-only /" should permit subpaths)
Your message dated Wed, 16 Feb 2005 13:17:26 -0500
with message-id <E1D1Tjq-0002Lm-00@newraff.debian.org>
and subject line Bug#277044: fixed in rdiff-backup 0.13.4-4
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 18 Oct 2004 07:01:40 +0000
>From dean-debian@arctic.org Mon Oct 18 00:01:40 2004
Return-path: <dean-debian@arctic.org>
Received: from twinlark.arctic.org [168.75.98.6]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1CJRWW-00077T-00; Mon, 18 Oct 2004 00:01:40 -0700
Received: (qmail 9083 invoked from network); 18 Oct 2004 07:01:37 -0000
Received: from unknown (HELO localhost) (127.0.0.1)
by 127.0.0.1 with AES256-SHA encrypted SMTP; 18 Oct 2004 07:01:37 -0000
Date: Mon, 18 Oct 2004 00:01:37 -0700 (PDT)
From: dean gaudet <dean-debian@arctic.org>
To: submit@bugs.debian.org
Subject: "--restrict-read-only /" should permit subpaths
Message-ID: <Pine.LNX.4.61.0410172354300.15674@twinlark.arctic.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
Package: rdiff-backup
Version: 0.13.4-3
"rdiff-backup --server --restrict-read-only /tmp" permits backups of
/tmp/foo -- this is expected according to the docs.
"rdiff-backup --server --restrict-read-only /" does not permit backups of
any subdirectory -- this looks like an oversight, the docs imply it should
work. the patch below fixes this behaviour.
-dean
--- rdiff-backup-0.13.4/rdiff_backup/Security.py.dg1 2004-06-04 09:59:22.000000000 -0700
+++ rdiff-backup-0.13.4/rdiff_backup/Security.py 2004-10-17 23:52:14.000000000 -0700
@@ -195,6 +195,7 @@
"""Require rpath not to step outside retricted directory"""
if Globals.restrict_path and rpath.conn is Globals.local_connection:
normalized, restrict = rpath.normalize().path, Globals.restrict_path
+ if restrict == "/": return
components = normalized.split("/")
# 3 cases for restricted dir /usr/foo: /var, /usr/foobar, /usr/foo/..
if (not normalized.startswith(restrict) or
---------------------------------------
Received: (at 277044-close) by bugs.debian.org; 16 Feb 2005 18:23:18 +0000
>From katie@ftp-master.debian.org Wed Feb 16 10:23:18 2005
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1D1TpW-0000nk-00; Wed, 16 Feb 2005 10:23:18 -0800
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1D1Tjq-0002Lm-00; Wed, 16 Feb 2005 13:17:26 -0500
From: Daniel Baumann <daniel.baumann@panthera-systems.net>
To: 277044-close@bugs.debian.org
X-Katie: $Revision: 1.55 $
Subject: Bug#277044: fixed in rdiff-backup 0.13.4-4
Message-Id: <E1D1Tjq-0002Lm-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Wed, 16 Feb 2005 13:17:26 -0500
Delivered-To: 277044-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
X-CrossAssassin-Score: 10
Source: rdiff-backup
Source-Version: 0.13.4-4
We believe that the bug you reported is fixed in the latest version of
rdiff-backup, which is due to be installed in the Debian FTP archive:
rdiff-backup_0.13.4-4.diff.gz
to pool/main/r/rdiff-backup/rdiff-backup_0.13.4-4.diff.gz
rdiff-backup_0.13.4-4.dsc
to pool/main/r/rdiff-backup/rdiff-backup_0.13.4-4.dsc
rdiff-backup_0.13.4-4_i386.deb
to pool/main/r/rdiff-backup/rdiff-backup_0.13.4-4_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 277044@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Daniel Baumann <daniel.baumann@panthera-systems.net> (supplier of updated rdiff-backup package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Tue, 15 Feb 2005 18:29:00 +0100
Source: rdiff-backup
Binary: rdiff-backup
Architecture: source i386
Version: 0.13.4-4
Distribution: unstable
Urgency: low
Maintainer: Daniel Baumann <daniel.baumann@panthera-systems.net>
Changed-By: Daniel Baumann <daniel.baumann@panthera-systems.net>
Description:
rdiff-backup - incremental backups using binary deltas
Closes: 225471 225485 235875 241906 252960 256266 260018 261578 270715 277044
Changes:
rdiff-backup (0.13.4-4) unstable; urgency=low
.
* New maintainer (Closes: #261578).
* Took over Alec Berrymans <alec@thened.net> interim package.
* debian/* redone and updated to new policy.
* debian/control: added correct python depency (Closes: #252960).
* Added rdiff-backup-hardlinks.dpatch to insure flag '--no-hard-links' is not
overridden by filesystem abilities and to fix handling of hard links on Mac
OS X (Thanks to Dave Vasilevsky <djvasi@gmail.com>).
* Added typo-fix.dpatch to fix an error message typo (Thanks to Thomas Jarosch
<thomas.jarosch@intra2net.com>).
* Added patch from CVS to fix broken '--calculate-average' flag (Thanks to
Dean Gaudet <dean@arctic.org>, Closes: #241906, #225471, #225485).
* Patched hard link test with afs-hardlinks.dpatch to only enable hard links
if able to link across directories. AFS only allows hard links within a
directory (Closes: #260018).
* Patched error message thrown when invoking after an unsuccessful backup with
typo-fix-2.dpatch (Closes: #256266).
* Added patch backup_warn_if_infinite_regress.dpatch backported from CVS to
fix handling of destination directory as subdirectories of source directory
(Closes: #235875).
* Patched types of files not to be compressed with no-compress-regexp.dpatch
(Closes: #270715).
* Added patch restrict-read-only.dpatch to correct the behavior of the
'--restrict-read-only' flag to bring it in line with the documented behavior
(Thanks to Dean Gaudet <dean@arctic.org>, Closes: #277044).
Files:
a06092300c15b2b5530eebe828eade39 724 utils optional rdiff-backup_0.13.4-4.dsc
ba4818732f83a92a3acd4decd2b6ddba 7849 utils optional rdiff-backup_0.13.4-4.diff.gz
22d0f5daf9a6aa93b2951787602ed375 31142 utils optional rdiff-backup_0.13.4-4_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
iEYEARECAAYFAkITitEACgkQELuA/Ba9d8YH1wCfXAwt4u5eegUuRqnWTdLYSPJJ
+xQAoNuMS3J1wFf4HOmYEW/VTZ6GtNc9
=8Zcw
-----END PGP SIGNATURE-----
Reply to: