[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#248798: marked as done (hnb: Ability to expand subtrees would be nice; here's a patch!)



Your message dated Wed, 26 May 2004 01:17:04 -0400
with message-id <E1BSqmm-0000RJ-00@newraff.debian.org>
and subject line Bug#248798: fixed in hnb 1.9.17-4
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 13 May 2004 04:17:48 +0000
>From mlbrownlow@comcast.net Wed May 12 21:17:48 2004
Return-path: <mlbrownlow@comcast.net>
Received: from rwcrmhc13.comcast.net [204.127.198.39] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1BO7fI-0002Kc-00; Wed, 12 May 2004 21:17:48 -0700
Received: from localhost (c-67-174-88-131.client.comcast.net[67.174.88.131])
          by comcast.net (rwcrmhc13) with ESMTP
          id <20040513041718015000peipe>
          (Authid: mlbrownlow);
          Thu, 13 May 2004 04:17:18 +0000
Received: from mike by localhost with local (Exim 4.32)
	id 1BO7gV-0007ZO-0Y; Wed, 12 May 2004 23:19:03 -0500
Content-Type: multipart/mixed; boundary="===============1690164642=="
MIME-Version: 1.0
From: "Michael L. Brownlow" <mlbrownlow@comcast.net>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: hnb: Ability to expand subtrees would be nice; here's a patch!
X-Mailer: reportbug 2.58
Date: Wed, 12 May 2004 23:19:03 -0500
Message-Id: <E1BO7gV-0007ZO-0Y@localhost>
Sender: "Michael L. Brownlow" <mlbrownlow@comcast.net>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-7.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 
X-CrossAssassin-Score: 1

This is a multi-part MIME message sent by reportbug.

--===============1690164642==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Package: hnb
Version: 1.9.17-3
Severity: wishlist


The only tree expand/collapse functions involved the whole tree.  See
attached patch for the ability to expand/collapse a subtree.  It also
binds '[' and ']' for these purposes along with entries in the node menu
item for the default configuration file. Already generated user
configurations will need to be hand edited to take advantage of the new
functionality.

-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.6.5
Locale: LANG=C, LC_CTYPE=C

Versions of packages hnb depends on:
ii  libc6                       2.3.2.ds1-12 GNU C Library: Shared libraries an
ii  libncurses5                 5.4-3        Shared libraries for terminal hand

-- no debconf information

--===============1690164642==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="hnb-subtree.patch"

diff -ur hnb-1.9.17.orig/src/expanded.c hnb-1.9.17/src/expanded.c
--- hnb-1.9.17.orig/src/expanded.c	2003-03-13 15:31:18.000000000 -0600
+++ hnb-1.9.17/src/expanded.c	2004-05-12 22:49:05.000000000 -0500
@@ -47,6 +47,15 @@
 			tnode = node_recurse (tnode);
 		}
 		cli_outfun ("expanded all nodes");
+	} else if(!strcmp(argv[1],"--subtree")) {
+	        node_setflag(pos,F_expanded,1);
+		Node *tnode = node_right(pos);
+
+		while ((tnode != node_down(pos))&&(tnode != pos)) {
+			node_setflag(tnode,F_expanded,1);
+			tnode = node_recurse (tnode);
+		}
+		cli_outfun ("expanded subtree");
 	}
 	return (int) pos;
 }
@@ -71,6 +80,15 @@
 			tnode = node_recurse (tnode);
 		}
 		cli_outfun ("collapsed all nodes");
+	} else if(!strcmp(argv[1],"--subtree")) {
+	        node_setflag(pos,F_expanded,0);
+		Node *tnode = node_right(pos);
+
+		while ((tnode != node_down(pos))&&(tnode != pos)) {
+			node_setflag(tnode,F_expanded,0);
+			tnode = node_recurse (tnode);
+		}
+		cli_outfun ("collapsed subtree");
 	}
 	
 	return (int) pos;
diff -ur hnb-1.9.17.orig/src/hnbrc.inc hnb-1.9.17/src/hnbrc.inc
--- hnb-1.9.17.orig/src/hnbrc.inc	2003-03-14 00:08:35.000000000 -0600
+++ hnb-1.9.17/src/hnbrc.inc	2004-05-12 23:06:52.000000000 -0500
@@ -216,6 +216,8 @@
 		\n\
 		bind + expand\n\
 		bind - collapse\n\
+		bind ] \"expand --subtree\"\n\
+		bind [ \"collapse --subtree\"\n\
 		\n\
 		bind ^Z restore_state\n\
 		\n\
@@ -515,17 +517,19 @@
 		menu \"Edit\" \"---------\" \"\"\n\
 		menu \"Edit\" \"Search ^F\" \"macro m_search\"\n\
 	##### node\n\
-		menu \"Entry\" \"--------------\" \"\"\n\
-		menu \"Entry\" \"edit    return\" \"edit\"\n\
-		menu \"Entry\" \"delete     del\" \"remove\"\n\
-		menu \"Entry\" \"--------------\" \"\"\n\
-		menu \"Entry\" \"do action   ^A\" \"action\"\n\
-		menu \"Entry\" \"indent      >\" \"indent\"\n\
-		menu \"Entry\" \"outdent     <\" \"outdent\"\n\
-		menu \"Entry\" \"toggle todo ^T\" \"toggle_todo\"\n\
-		menu \"Entry\" \"toggle done ^D\" \"toggle_done\"\n\
-		menu \"Entry\" \"expand      +\" \"expand\"\n\
-		menu \"Entry\" \"collapse    -\" \"collapse\"\n\
+		menu \"Entry\" \"-------------------\" \"\"\n\
+		menu \"Entry\" \"edit         return\" \"edit\"\n\
+		menu \"Entry\" \"delete          del\" \"remove\"\n\
+		menu \"Entry\" \"-------------------\" \"\"\n\
+		menu \"Entry\" \"do action        ^A\" \"action\"\n\
+		menu \"Entry\" \"indent           >\" \"indent\"\n\
+		menu \"Entry\" \"outdent          <\" \"outdent\"\n\
+		menu \"Entry\" \"toggle todo      ^T\" \"toggle_todo\"\n\
+		menu \"Entry\" \"toggle done      ^D\" \"toggle_done\"\n\
+		menu \"Entry\" \"expand           +\" \"expand\"\n\
+		menu \"Entry\" \"expand subtree   ]\" \"expand --subtree\"\n\
+		menu \"Entry\" \"collapse         -\" \"collapse\"\n\
+		menu \"Entry\" \"collapse subtree [\" \"collapse --subtree\"\n\
 	##### level\n\
 		menu \"Level\" \"------------\" \"\"\n\
 		menu \"Level\" \"sort      ^S\" \"sort -a\"\n\

--===============1690164642==--

---------------------------------------
Received: (at 248798-close) by bugs.debian.org; 26 May 2004 05:23:03 +0000
>From katie@ftp-master.debian.org Tue May 25 22:23:03 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1BSqsY-0001Eh-00; Tue, 25 May 2004 22:23:03 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1BSqmm-0000RJ-00; Wed, 26 May 2004 01:17:04 -0400
From: James Morrison <phython@debian.org>
To: 248798-close@bugs.debian.org
X-Katie: $Revision: 1.49 $
Subject: Bug#248798: fixed in hnb 1.9.17-4
Message-Id: <E1BSqmm-0000RJ-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Wed, 26 May 2004 01:17:04 -0400
Delivered-To: 248798-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 
X-CrossAssassin-Score: 4

Source: hnb
Source-Version: 1.9.17-4

We believe that the bug you reported is fixed in the latest version of
hnb, which is due to be installed in the Debian FTP archive:

hnb_1.9.17-4.diff.gz
  to pool/main/h/hnb/hnb_1.9.17-4.diff.gz
hnb_1.9.17-4.dsc
  to pool/main/h/hnb/hnb_1.9.17-4.dsc
hnb_1.9.17-4_sparc.deb
  to pool/main/h/hnb/hnb_1.9.17-4_sparc.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 248798@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
James Morrison <phython@debian.org> (supplier of updated hnb package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Wed, 26 May 2004 00:08:48 -0400
Source: hnb
Binary: hnb
Architecture: source sparc
Version: 1.9.17-4
Distribution: unstable
Urgency: low
Maintainer: James Morrison <phython@debian.org>
Changed-By: James Morrison <phython@debian.org>
Description: 
 hnb        - Hierarchical notebook
Closes: 228413 231256 245875 248798
Changes: 
 hnb (1.9.17-4) unstable; urgency=low
 .
   * Add recursive expand/collapse. (Closes: #248798)
   * Update maintainer, properly this time!
   * Unset 'done' flag when toggling off a todo item. (Closes: #231256)
   * Return NULL if node is NULL in node_get. (Closes: #245875)
   * Provide an alternate hnbrc file. (Closes: #228413)
Files: 
 ac131efb421b3229af28f00422307e19 582 misc optional hnb_1.9.17-4.dsc
 576d0d9def407e6280b38c3b0e0bd146 7727 misc optional hnb_1.9.17-4.diff.gz
 d9e46bfa9e3745b7229fa7012341868e 88786 misc optional hnb_1.9.17-4_sparc.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAtCNi72f7x2KLjmkRAlJUAJ4vsHUnEzwegzSZbF/C+hEmHWzIYACfW/Sl
Cgd/LjIgxZAbLeNJ7vVVq0U=
=HTkX
-----END PGP SIGNATURE-----



Reply to: