[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#212777: marked as done (cdfs-src: does not understand the --rootcmd option of make-kpkg)

Your message dated Wed, 14 Apr 2004 20:47:03 -0400
with message-id <E1BDv1z-0004Gf-00@newraff.debian.org>
and subject line Bug#212777: fixed in cdfs-src 2.4.20+2.6.3-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

Received: (at submit) by bugs.debian.org; 25 Sep 2003 23:25:32 +0000
>From Nicolas.Boullis@free.fr Thu Sep 25 18:25:19 2003
Return-path: <Nicolas.Boullis@free.fr>
Received: from postfix3-1.free.fr [] 
	by master.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1A2fU7-00060N-00; Thu, 25 Sep 2003 18:25:19 -0500
Received: from Nestor.home (parmentier-1-82-67-25-78.fbx.proxad.net [])
	by postfix3-1.free.fr (Postfix) with ESMTP
	id AAE6AC054; Fri, 26 Sep 2003 01:25:18 +0200 (CEST)
Received: from tintin.home ([] helo=tintin)
	by Nestor.home with esmtp (Exim 3.35 #1 (Debian))
	id 1A2fU6-0001Vp-00; Fri, 26 Sep 2003 01:25:18 +0200
Received: from nboullis by tintin with local (Exim 3.36 #1 (Debian))
	id 1A2fU5-0001b0-00; Fri, 26 Sep 2003 01:25:17 +0200
Date: Fri, 26 Sep 2003 01:25:17 +0200
From: Nicolas Boullis <nboullis@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: cdfs-src: does not understand the --rootcmd option of make-kpkg
Message-ID: <20030925232513.GA6104@tintin>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="y0ulUmNC+osPPQO6"
Content-Disposition: inline
X-Reportbug-Version: 2.29
User-Agent: Mutt/1.5.4i
Sender: Nicolas Boullis <Nicolas.Boullis@free.fr>
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-11.3 required=4.0
	autolearn=ham version=2.53-bugs.debian.org_2003_9_21
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_9_21 (

Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Package: cdfs-src
Version: 0.5c-1
Severity: minor


The current version of cdfs-src does not understand the --rootcmd option 
of make-kpkg. This is because the debian/rules make script does not use 
the $(ROOT_CMD) variable.

The attached patch modifies debian/rules to use this variable.



-- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux tintin 2.4.22-tintin-test #1 Wed Sep 24 02:32:07 CEST 2003 i686
Locale: LANG=C, LC_CTYPE=fr_FR@euro

Versions of packages cdfs-src depends on:
ii  debhelper                     4.1.73     helper programs for debian/rules
ii  kernel-package                8.058      A utility for building Linux kerne
ii  make                          3.80-2     The GNU version of the "make" util

-- no debconf information

Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="cdfs.patch"

diff -ru cdfs-src-0.5c/debian.binary/rules cdfs-src-0.5c.new/debian.binary/rules
--- cdfs-src-0.5c/debian.binary/rules	2002-05-03 15:52:10.000000000 +0200
+++ cdfs-src-0.5c.new/debian.binary/rules	2003-09-26 01:20:34.000000000 +0200
@@ -8,6 +8,11 @@
 # This is the debhelper compatability version to use.
 export DH_COMPAT=2
+# unset ROOT_CMD if already running as root
+ifeq ($(shell id -u),0)
 ifdef KDREV
 FULLVER := $(shell dpkg-parsechangelog |grep ^Version | cut -f2 -d' ')+$(KDREV)
 DEBDEP := (= $(KDREV))
@@ -93,7 +98,8 @@
 # should configure the module so it is ready for compilation (mostly
 # useful for calling configure)
 .PHONY: kdist_config
-kdist_config: configure
+	$(ROOT_CMD) $(MAKE) -f debian/rules configure
 # the kdist_image target is called by make-kpkg modules_image. It is
@@ -102,9 +108,11 @@
 # seperate binary-modules target to make testing the package building
 # easier
 .PHONY: kdist_image
-kdist_image: kdist_targets clean
+kdist_image: kdist_targets
+	$(ROOT_CMD) $(MAKE) -f debian/rules clean
-kdist_targets: clean configure build install binary_modules
+	$(ROOT_CMD) $(MAKE) -f debian/rules clean configure build install binary_modules
 # a wrapper rule
 .PHONY: kdist
@@ -113,11 +121,12 @@
 		REV="$(KDREV)" KEMAIL="$(KEMAIL)" sh -v debian/genchanges.sh
 	# Only now can we clean up.
-	debian/rules clean
+	$(ROOT_CMD) $(MAKE) -f debian/rules clean
 # the kdist_clean target is called by make-kpkg modules_clean. It is
 # responsible for cleaning up any changes that have been made by the
 # other kdist_commands (except for the .deb files created).
 .PHONY: kdist_clean
-kdist_clean: clean
+	$(ROOT_CMD) $(MAKE) -f debian/rules clean


Received: (at 212777-close) by bugs.debian.org; 15 Apr 2004 00:53:06 +0000
>From katie@ftp-master.debian.org Wed Apr 14 17:53:06 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1BDv7q-00062M-00; Wed, 14 Apr 2004 17:53:06 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1BDv1z-0004Gf-00; Wed, 14 Apr 2004 20:47:03 -0400
From: Eduard Bloch <blade@debian.org>
To: 212777-close@bugs.debian.org
X-Katie: $Revision: 1.47 $
Subject: Bug#212777: fixed in cdfs-src 2.4.20+2.6.3-1
Message-Id: <E1BDv1z-0004Gf-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Wed, 14 Apr 2004 20:47:03 -0400
Delivered-To: 212777-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-5.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-CrossAssassin-Score: 4

Source: cdfs-src
Source-Version: 2.4.20+2.6.3-1

We believe that the bug you reported is fixed in the latest version of
cdfs-src, which is due to be installed in the Debian FTP archive:

  to pool/main/c/cdfs-src/cdfs-src_2.4.20+2.6.3-1.dsc
  to pool/main/c/cdfs-src/cdfs-src_2.4.20+2.6.3-1.tar.gz
  to pool/main/c/cdfs-src/cdfs-src_2.4.20+2.6.3-1_all.deb

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 212777@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Eduard Bloch <blade@debian.org> (supplier of updated cdfs-src package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.7
Date: Wed, 14 Apr 2004 17:20:16 +0200
Source: cdfs-src
Binary: cdfs-src
Architecture: source all
Version: 2.4.20+2.6.3-1
Distribution: unstable
Urgency: low
Maintainer: Eduard Bloch <blade@debian.org>
Changed-By: Eduard Bloch <blade@debian.org>
 cdfs-src   - shows the tracks on a CD as normal files
Closes: 141868 147097 153989 212777 212778 238329 242240
 cdfs-src (2.4.20+2.6.3-1) unstable; urgency=low
   * New (old) maintainer (closes: #242240)
   * new upstream releases (closes: #212778, #238329)
   * new version scheme choosen by upstream, we combine the two strings to one
   * changed to use module-assistant includes and one unified rules file
     (closes: #141868, #147097, #212777)
   * cdfs.tar compressed with bzip2 now, README.Debian updated (closes:#153989)
 6040f3255d234af9d5b602074537213a 525 misc optional cdfs-src_2.4.20+2.6.3-1.dsc
 6405c25ab8e9f7c8a71da4ea1a603d2f 106161 misc optional cdfs-src_2.4.20+2.6.3-1.tar.gz
 8c5f0851e3091d53b7d49bf73d4072fc 83316 misc optional cdfs-src_2.4.20+2.6.3-1_all.deb

Version: GnuPG v1.2.4 (GNU/Linux)


Reply to: