Bug#190287: marked as done (wanpipe: bad defaults hardcoded)
Your message dated Tue, 23 Sep 2003 14:15:24 +1000
with message-id <20030923041524.GA811@deprecation.cyrius.com>
and subject line wanpipe has been removed
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 23 Apr 2003 06:24:58 +0000
>From bam@snoopy.apana.org.au Wed Apr 23 01:24:56 2003
Return-path: <bam@snoopy.apana.org.au>
Received: from snoopy.apana.org.au [203.12.237.97] (postfix)
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 198Dgb-0007EO-00; Wed, 23 Apr 2003 01:24:53 -0500
Received: from localhost (localhost [127.0.0.1])
by snoopy.apana.org.au (Postfix) with ESMTP
id 6FC24896E; Wed, 23 Apr 2003 16:24:49 +1000 (EST)
Received: from snoopy.apana.org.au ([127.0.0.1])
by localhost (snoopy [127.0.0.1]) (amavisd-new, port 10024) with ESMTP
id 09325-08; Wed, 23 Apr 2003 16:24:42 +1000 (EST)
Received: by snoopy.apana.org.au (Postfix, from userid 1003)
id 5999C897E; Wed, 23 Apr 2003 16:24:41 +1000 (EST)
From: Brian May <bam@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: wanpipe: bad defaults hardcoded
X-Mailer: reportbug 1.50
Date: Wed, 23 Apr 2003 16:24:40 +1000
Message-Id: <20030423062441.5999C897E@snoopy.apana.org.au>
X-Virus-Scanned: by amavisd-new-20030314-p1 (Debian)
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-3.1 required=4.0
tests=HAS_PACKAGE,PATCH_UNIFIED_DIFF,SPAM_PHRASE_00_01
version=2.44
X-Spam-Level:
Package: wanpipe
Version: 2.1.1-2.1
Severity: important
wanpipe: Wanpipe Module: /lib/modules/2.4.20-686/misc/wanrouter.o not found !!!! WANPIPE drivers must be compiled as modules
Check kernel configuration in /usr/src/linux/.config:
CONFIG_WAN_ROUTER=m
CONFIG_VENDOR_SANGOMA=m
However, the driver is in this directory:
melbourne1:/etc/wanpipe# modprobe -l | grep wanrouter
/lib/modules/2.4.20-686/kernel/net/wanrouter/wanrouter.o
Hardcoding the full path name to the driver is a silly idea, as modprobe
is used load the driver, and it will automatically work out where the
driver is.
Also wanpipe says wanpipe1 is in use, when it hasn't been configured.
This is because the case of the d is wrong:
melbourne1:/usr/sbin# cat /proc/net/wanrouter/wanpipe1
device is not configured!
The following patch solves these issues:
--- wanpipe.old Wed Apr 23 16:02:03 2003
+++ wanpipe Wed Apr 23 16:20:32 2003
@@ -135,20 +135,6 @@
echo "Starting WAN Router..."
echo "`date`: starting WAN router" > $ROUTER_LOG
- [ -f "$MOD1" ] || {
- mod_error $MOD1
- return 1
- }
-
- [ -f "$MOD2" ] || {
- mod_error $MOD2
- return 1
- }
- [ -f "$MOD3" ] || {
- mod_error $MOD3
- return 1
- }
-
# [ -f "$ROUTER_CONF" ] || {
# error "Configuration file $ROUTER_CONF not found"
# return 1
@@ -331,7 +317,7 @@
cd $ROUTER_PROC
ac_list=`ls wanpipe*`;
for ac_wan in $ac_list; do
- res=`grep "Device is not configured" $ROUTER_PROC/$ac_wan`
+ res=`grep -i "Device is not configured" $ROUTER_PROC/$ac_wan`
[ -z "$res" ] && {
echo -n "$ac_wan "
}
@@ -354,7 +340,7 @@
cd $ROUTER_PROC
- res=`grep "Device is not configured" $ROUTER_PROC/$device`
+ res=`grep -i "Device is not configured" $ROUTER_PROC/$device`
[ -z "$res" ] && {
#Device running
return 0
@@ -373,7 +359,7 @@
cd $ROUTER_PROC
WAN_LIST=`ls wanpipe*`
for wan in $WAN_LIST; do
- res=`grep "Device is not configured" $ROUTER_PROC/$wan`
+ res=`grep -i "Device is not configured" $ROUTER_PROC/$wan`
[ -z "$res" ] && {
echo "Devices still running:"
print_active_devices;
@@ -397,9 +383,6 @@
REDHAT=/usr/src/redhat
ROUTER_PROC=/proc/net/wanrouter
WAN_DRIVERS=wanpipe
-MOD1=/lib/modules/$(uname -r)/misc/wanrouter.o
-MOD2=/lib/modules/$(uname -r)/net/wanpipe.o
-MOD3=/lib/modules/$(uname -r)/net/sdladrv.o
# Ignore interrupt signals.
trap '' 2
@@ -475,7 +458,7 @@
router_load && touch $ROUTER_LOCK
}
- res=`grep "Device is not configured" $ROUTER_PROC/$dev`
+ res=`grep -i "Device is not configured" $ROUTER_PROC/$dev`
[ -z "$res" ] && {
echo "Device $dev is still running"
echo -e "Run wanpipe stop $dev first\n"
-- System Information
Debian Release: 3.0
Architecture: i386
Kernel: Linux snoopy 2.4.19 #1 Wed Oct 30 11:36:54 EST 2002 i686
Locale: LANG=C, LC_CTYPE=
---------------------------------------
Received: (at 190287-done) by bugs.debian.org; 23 Sep 2003 04:16:07 +0000
>From tbm@cyrius.com Mon Sep 22 23:16:05 2003
Return-path: <tbm@cyrius.com>
Received: from bangpath.uucico.de [195.71.9.197]
by master.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1A1eao-0007ht-00; Mon, 22 Sep 2003 23:16:03 -0500
Received: by bangpath.uucico.de (Postfix, from userid 10)
id 3006426B95; Tue, 23 Sep 2003 06:16:02 +0200 (CEST)
Received: by deprecation.cyrius.com (Postfix, from userid 1000)
id EF00CFECC; Tue, 23 Sep 2003 14:15:24 +1000 (EST)
Date: Tue, 23 Sep 2003 14:15:24 +1000
From: Martin Michlmayr <tbm@cyrius.com>
To: 132099-done@bugs.debian.org, 190287-done@bugs.debian.org,
190288-done@bugs.debian.org
Subject: wanpipe has been removed
Message-ID: <20030923041524.GA811@deprecation.cyrius.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.4i
Delivered-To: 190287-done@bugs.debian.org
X-Spam-Status: No, hits=-5.3 required=4.0
tests=BAYES_60,EMAIL_ATTRIBUTION,QUOTED_EMAIL_TEXT,
SIGNATURE_SHORT_SPARSE
version=2.53-bugs.debian.org_2003_9_21
X-Spam-Level:
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_9_21 (1.174.2.15-2003-03-30-exp)
Closing wanpipe's other bugs since the package has been removed from
Debian unstable.
----- Forwarded message from Colin Watson <cjwatson@debian.org> -----
From: Colin Watson <cjwatson@debian.org>
Subject: Re: why RC?
Date: Tue, 23 Sep 2003 01:37:27 +0100
To: Martin Michlmayr <tbm@cyrius.com>
Cc: 190619-done@bugs.debian.org, tmancill@debian.org
User-Agent: Mutt/1.3.28i
X-Spam-Status: No, hits=-5.0 required=5.0
tests=EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES,
REPLY_WITH_QUOTES,USER_AGENT_MUTT
autolearn=ham version=2.55
On Sat, Sep 13, 2003 at 03:55:07PM +1000, Martin Michlmayr wrote:
> Please remove wanpipe; it has been orphaned for a long time, doesn't
> have build-deps and is generally out of date; in #190619 the original
> maintainer said he'd request the removal but never got around to it.
This has been done now, so I'm closing this bug as no longer applicable:
=========================================================================
[Date: Mon, 22 Sep 2003 11:58:16 -0400] [ftpmaster: James Troup]
Removed the following packages from unstable:
wanpipe | 2.1.1-2.2 | source, i386
Closed bugs: 179392
------------------- Reason -------------------
ROM; orphaned, out-of-date, FTBFS.
----------------------------------------------
=========================================================================
Cheers,
--
Colin Watson [cjwatson@flatline.org.uk]
----- End forwarded message -----
--
Martin Michlmayr
tbm@cyrius.com
Reply to: