Bug#182157: wrong assumption on char signedness
Package: blackened
Version: 1.8.1-3
Severity: important
Hi,
char is per default unsigned on arm, powerpc and s390. There iare two warnings
fileio.c:648: warning: comparison is always true due to limited range of data
type
fileio.c:697: warning: comparison is always true due to limited range of data
type
during build of your package that might cause a runtime error. Please check
http://buildd.debian.org/fetch.php?&pkg=blackened&ver=1.8.1-3&arch=s390&stamp=1044806788&file=log&as=raw
for details.
In your case the variable c should be defined as int. Defining it as
char is even wrong on i386, since the char 0xff is then interpreted as EOF.
On the platforms mentioned above the EOF condition is never true, leading to
an infinite loop.
Thanks,
Gerhard
Reply to: