[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: review for datasette/0.65.2-1



Hi Jeroen,

Thanks for catching these and for the housekeeping on d/rules!

> table.js in missing-sources

Removed. Added lintian override with comment noting it's a false positive
(long lines, not minified).

> codemirror-5.57.0.min.css missing from d/missing-sources

Added codemirror-5.57.0.css from the 5.57.0 tag [0]. Updated README accordingly.

> stack limit for all 32-bit archs

Noted on extending to sh4, m68k, etc. Will keep that in mind for the future!

Best,
Mahangu

[0] https://github.com/codemirror/codemirror5/blob/5.57.0/lib/codemirror.css


On Thu, Dec 4, 2025 at 10:58 PM Jeroen Ploemen <jcfp@debian.org> wrote:
hi Mahangu,

was doing some last minute checks before upload when I noticed these:

* for datasette/static/table.js, the file in missing-sources seems to
  be identical to the one in the orig tarball - neither is minified,
  it just has a long line that triggers the lintian hit. So there's
  no need for this to make an appearance in missing-sources.

* datasette/static/codemirror-5.57.0.min.css on the other hand is
  actually minified, but not present in d/missing-sources. I guess
  lintian only looks for certain types of files, and css isn't among
  them. Anyway, the original appears to live at [1] (and probably
  somewhere in a codemirror tarball as well).


I also changed the stack limit to cover all 32 bit archs, since
there's a few ports that are also 32 bit (sh4, mk68, etc.), and did
some housekeeping to trim down long lines in d/rules and remove
overrides made redundant by other changes.


[1]https://github.com/codemirror/codemirror5/blob/master/lib/codemirror.css

Reply to: