Hi Jeroen,
Thanks again for the thorough review! I believe I have addressed all your feedback:
> upstream/0.65.2 tag still points to the old source import
Fixed. Tag now points to newest upstream commit (2c25896).
> vendored copy of pint gets installed into the binary pkg
Added "datasette/vendored/" to debian/clean as you suggested. Also added
execute_after_dh_auto_install to remove it from the installed package.
> control: unnecessary hardcoded python deps on binary pkg
Removed all except python3-markupsafe. Kept it explicit as you suggested
since it's not in setup.py install_requires (only a transitive dep via Jinja2).
> control: build-deps on python3-platformdirs, -typing-extensions, -flex* unused
Removed all four packages from Build-Depends.
> patches: remove-vendored-pint patch header contains boilerplate
Removed DEP3 template boilerplate from patch header.
> rules: '--with python3' is redundant
Removed. Using only "dh $@ --buildsystem=pybuild".
> rules: override_dh_auto_build -> execute_after_dh_auto_build
Changed to execute_after_dh_auto_build and removed redundant
dh_auto_build call.
> copyright: vendored copy of pint missing
Added Files stanza for datasette/vendored/pint/* with BSD-3-Clause license.
> lintian: unused-override application-in-library-section
Old override removed. New override added for image-file-in-usr-lib
(favicon.png is part of web UI).
> lintian: package-contains-documentation-outside-usr-share-doc,
> vcs-control-file, privacy-breach-generic
Removed docs directory from build and installed package. The docs were
copied for tests via PYBUILD_BEFORE_TEST and accidentally installed.
These are .rst source files, not built HTML - comprehensive docs are
available at
docs.datasette.io.
> lintian: source-contains-prebuilt-_javascript_-object
Added overrides to debian/source/lintian-overrides for all five JS files,
with comment referencing debian/missing-sources/.
> Why extend-diff-ignore for setup.cfg and .eggs/?
Removed setup.cfg - confirmed it's not modified during build. Kept .eggs/
since setuptools creates it during build for pytest_runner.
> Why include-binaries for tests/spatialite.db?
Removed. I originally added it preemptively, but since spatialite.db is in
the orig tarball and not modified by any patch, it looks like we don't need
to do this. Thanks!
Also fixed a Salsa i386 build issue: the test suite was exhausting thread limits
due to 32-bit address space constraints. Added ulimit -s 1024 for i386 builds
to reduce per-thread stack size.
Ready for re-review. Looking forward to your feedback!
Best,
Mahangu