[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: sphinxext-opengraph new upstream version and tests



On Fri, 31 Dec 2021 17:25:34 -1000
Chiara Marmo <marmochiaskl@gmail.com> wrote:

> I think the configuration is better now, as the CI passed too.

Using @builddeps@ may seem attractive at first, but is best reserved
for autopkgtests that actually do a full build. In most other cases
redundant extra stuff gets installed that's only needed at build
time, such as dh-python and setuptools in this case.

In addition, python packages that run tests at build time typically
have the full set of module dependencies as build-deps that one also
expects to find as deps on the (main) binary pkg. For such packages,
using @builddeps@ causes dependencies of the package being tested to
get duplicated as test deps, meaning any missing ones - for example
resulting from a packaging or helper application bug - could easily
be overlooked. After all, the autopkgtest would pass even for a
severely broken binary package with all python deps missing.

> Please let me know if the package is ready for the upload.

The debhelper compat level could do with a bump to the current
version. Other than that, things look fine.

> Also, happy new year 2022 to all the people on the list!

Indeed!

Attachment: pgp_eTRo5T9X7.pgp
Description: OpenPGP digital signature


Reply to: