[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: sphinxext-opengraph new upstream version and tests



Thanks Jeroen for your time and your review

Enabling the CI on salsa for your package can be really helpful to
verify things work as expected. As an added benefit, it also lowers
the time and effort needed to review a package.

Indeed, I have enabled it.
 
Anyway, the current autopkgtest has a number of obvious flaws:
* the binary package it's trying to test isn't actually installed at
  all because it's not listed as a test dependency;
* the same goes for the supported python versions the test loops over
  (i.e. the necessary dependency on python3-all is missing).
* on the other hand, dependencies of the package being tested (such
  as python3-sphinx) should not be duplicated as a test dependency;
* within the control file, the field identifying tests in a separate
  file is called 'Tests', not 'Test-Command'.

I think the configuration is better now, as the CI passed too.
Please let me know if the package is ready for the upload.

Also, happy new year 2022 to all the people on the list!

Best,

Chiara
 

Reply to: