Hi Thomas,Thanks for the review, and it's nice to see you found a number of problems! I have to admit I did not prepare a new package since a long time, probably forgot a lot of things, and copied others from other packages of mine...
On 2020-04-19 14:09+0200, Thomas Goirand wrote:
Hi Felix, Thanks for working on this. Here's my comments. I'm sorry that there's a lot to say on what you did... :/ On 4/19/20 11:53 AM, Félix Sipma wrote:dget -x https://mentors.debian.net/debian/pool/main/s/sphinx-autoapi/sphinx-autoapi_1.2.1-1.dscLooking at your debian/copyright, I'd strongly suggest releasing the Debian packaging under the same license. For me that's a blocker for sponsoring the package (it may be ok for others to sponsor).
OK. I prefer using GPL-3+, but nevermind, I would really like to getthis package in sid soon. Other sponsors are still to be found, so I turned it to Expat.
You wrote in d/control as if the 2nd line of Description: was the continuation of the short description. This is not the case. Please write a proper short description (ie: the first line after "Description:") and a long description (what goes after that first line) as *not* the continuation of the first line. It's very much ok to repeat the short description in the long one. This is also a blocker for me to sponsor the package.
Sorry about this, I guess I wanted to write a small description, forgot about it, and just put the long description instead. It should be fixed now.
You're packaging the doc "as-is" without using Sphinx to build it. Any reason why, or you just don't know how yet? :) I'd suggest looking at other Python package building a -doc package to fix this. I'd also suggest packaging the doc in a separate -doc package.
Woops, I guess I didn't look closely to the build logs... And I did this for a package used for generating doc: I should be punished for that :).
Also, please remove: [import-orig] merge-mode = replace from debian/gbp.conf. This is typically something that goes into ~/.gbp.conf rather than on individual packages.
I don't agree with you on this one. To me, this kind of setting should be put in the package, to have an uniform way of updating/building/etc. a given package, whoever the uploader could be.
Can you explain in more details than in debian/rules why you're overriding override_dh_auto_clean ? What does it try to download, apart from the build dependencies? Can't you set $clean_source = 0; in your ~/.sbuildrc instead?
Mmh, I don't remember about this... I probably copied it from another of my packages, without looking at it. It works without, so I removed it. I'll try to find what this other package is to see if I can fix it properly :-).
Note that I found and patched another access to the internet during build (see 0001-Use-local-object-inventory-files-for-sphinx.patch).
More generally, I disagree with needing special settings in ~/.sbuildrc (or other user configuration, or special command line arguments) before updating a package. I think that is just making life harder for (potential) future uploaders.
I hope this helps,
Sure, thanks! I have to say that I was starting filling quite demotivated because of not finding a sponsor for this little package... (And I have the same issue for other haskell packages, maybe I should finally complete the procedure to apply for becoming a DD...). I hope I fixed the issues you found and that you will agree with my argument for the debian/gbp.conf setting.
The new package is at https://mentors.debian.net/debian/pool/main/s/sphinx-autoapi/sphinx-autoapi_1.3.0-1.dsc Regards, -- Félix
Attachment:
signature.asc
Description: PGP signature