Re: [felix+debian@gueux.org: Bug#955862: RFS: sphinx-autoapi/1.2.1-1 [ITP]]

[Thomas Goirand <zigo@debian.org>]

Hi Felix,

Thanks for working on this. Here's my comments. I'm sorry that there's a
lot to say on what you did... :/

On 4/19/20 11:53 AM, Félix Sipma wrote:
>   dget -x  	https://mentors.debian.net/debian/pool/main/s/sphinx-autoapi/sphinx-autoapi_1.2.1-1.dsc

Looking at your debian/copyright, I'd strongly suggest releasing the
Debian packaging under the same license. For me that's a blocker for
sponsoring the package (it may be ok for others to sponsor).

You wrote in d/control as if the 2nd line of Description: was the
continuation of the short description. This is not the case. Please
write a proper short description (ie: the first line after
"Description:") and a long description (what goes after that first line)
as *not* the continuation of the first line. It's very much ok to repeat
the short description in the long one. This is also a blocker for me to
sponsor the package.

You're packaging the doc "as-is" without using Sphinx to build it. Any
reason why, or you just don't know how yet? :) I'd suggest looking at
other Python package building a -doc package to fix this. I'd also
suggest packaging the doc in a separate -doc package.

Also, please remove:

[import-orig]
merge-mode = replace

from debian/gbp.conf. This is typically something that goes into
~/.gbp.conf rather than on individual packages.

Can you explain in more details than in debian/rules why you're
overriding override_dh_auto_clean ? What does it try to download, apart
from the build dependencies? Can't you set $clean_source = 0; in your
~/.sbuildrc instead?

I hope this helps,
Cheers,

Thomas Goirand (zigo)